René's URL Explorer Experiment


Title: Leftover code in `sysconfig.expand_makefile_vars` · Issue #128978 · python/cpython · GitHub

Open Graph Title: Leftover code in `sysconfig.expand_makefile_vars` · Issue #128978 · python/cpython

X Title: Leftover code in `sysconfig.expand_makefile_vars` · Issue #128978 · python/cpython

Description: Bug report Bug description: I think there is some leftover code in sysconfig.expand_makefile_vars (4a53a39): cpython/Lib/sysconfig/__init__.py Lines 727 to 734 in 4dade05 while True: m = re.search(_findvar1_rx, s) or re.search(_findvar2_...

Open Graph Description: Bug report Bug description: I think there is some leftover code in sysconfig.expand_makefile_vars (4a53a39): cpython/Lib/sysconfig/__init__.py Lines 727 to 734 in 4dade05 while True: m = re.search(...

X Description: Bug report Bug description: I think there is some leftover code in sysconfig.expand_makefile_vars (4a53a39): cpython/Lib/sysconfig/__init__.py Lines 727 to 734 in 4dade05 while True: m = re.search(...

Opengraph URL: https://github.com/python/cpython/issues/128978

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Leftover code in `sysconfig.expand_makefile_vars`","articleBody":"# Bug report\n\n### Bug description:\n\nI think there is some leftover code in `sysconfig.expand_makefile_vars` (4a53a397c311567f05553bc25a28aebaba4f6f65):\n\nhttps://github.com/python/cpython/blob/4dade055f4e18a7e91bc70293abb4db745ad16ca/Lib/sysconfig/__init__.py#L727-L734\n\nThe `_findvar1_rx` and `_findvar2_rx` variables are not declared at all (they were moved to `sysconfig/__main__.py`). Since the function is publicly named (but not exported nor documented), I prefer backporting the changes of #110785, namely re-use the patterns as is.\n\ncc @FFY00\n\n### CPython versions tested on:\n\nCPython main branch\n\n### Operating systems tested on:\n\n_No response_\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-128979\n* gh-129065\n* gh-129066 (not needed)\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/picnixz","@type":"Person","name":"picnixz"},"datePublished":"2025-01-18T10:03:31Z","url":"https://github.com/python/cpython/issues/128978"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:62be0d6e-f6ed-c45f-628a-03f7ca0135be
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE500:928E2:38D455B:4BB2D1C:6B021B6D
html-safe-noncecfa0ee8aab8923b19c8aed68d5b2858c4c4aea2012ac2d76847cf479e4604846
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTAwOjkyOEUyOjM4RDQ1NUI6NEJCMkQxQzo2QjAyMUI2RCIsInZpc2l0b3JfaWQiOiI5NTU2MDQ3NDc0MDkzMDAzMzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9bcc7bb9c790f46c896474925b455d1ef89a911e60f2676862929d184c307daf
hovercard-subject-tagissue:2796894296
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/128978/issue_layout
twitter:imagehttps://opengraph.githubassets.com/99fbac2cf882f495aa5963cc8b73889701725505bb645e1bf87b44b0ecbdf4e8/python/cpython/issues/128978
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/99fbac2cf882f495aa5963cc8b73889701725505bb645e1bf87b44b0ecbdf4e8/python/cpython/issues/128978
og:image:altBug report Bug description: I think there is some leftover code in sysconfig.expand_makefile_vars (4a53a39): cpython/Lib/sysconfig/__init__.py Lines 727 to 734 in 4dade05 while True: m = re.search(...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepicnixz
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/128978#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F128978
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F128978
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/128978
Reloadhttps://github.com/python/cpython/issues/128978
Reloadhttps://github.com/python/cpython/issues/128978
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/128978
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/128978
Leftover code in sysconfig.expand_makefile_varshttps://github.com/python/cpython/issues/128978#top
https://github.com/picnixz
3.13only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.13%22
3.14bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.14%22
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/picnixz
picnixzhttps://github.com/picnixz
on Jan 18, 2025https://github.com/python/cpython/issues/128978#issue-2796894296
4a53a39https://github.com/python/cpython/commit/4a53a397c311567f05553bc25a28aebaba4f6f65
cpython/Lib/sysconfig/__init__.pyhttps://github.com/python/cpython/blob/4dade055f4e18a7e91bc70293abb4db745ad16ca/Lib/sysconfig/__init__.py#L727-L734
4dade05https://github.com/python/cpython/commit/4dade055f4e18a7e91bc70293abb4db745ad16ca
#110785https://github.com/python/cpython/pull/110785
@FFY00https://github.com/FFY00
gh-128978: Fix a NameError in sysconfig.expand_makefile_vars #128979https://github.com/python/cpython/pull/128979
[3.13] gh-128978: Fix a NameError in sysconfig.expand_makefile_vars (GH-128979) #129065https://github.com/python/cpython/pull/129065
[3.12] gh-128978: Fix a NameError in sysconfig.expand_makefile_vars (GH-128979) #129066https://github.com/python/cpython/pull/129066
picnixzhttps://github.com/picnixz
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
on Jan 18, 2025https://github.com/python/cpython/issues/128978#event-15985499415
picnixzhttps://github.com/picnixz
on Jan 18, 2025https://github.com/python/cpython/issues/128978#event-15985499425
picnixzhttps://github.com/picnixz
3.13only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.13%22
3.14bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.14%22
3.12only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.12%22
on Jan 18, 2025https://github.com/python/cpython/issues/128978#event-15985504749
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
on Jan 20, 2025https://github.com/python/cpython/issues/128978#issuecomment-2602355700
https://github.com/picnixz
picnixzhttps://github.com/picnixz
on Jan 20, 2025https://github.com/python/cpython/issues/128978#issuecomment-2602377298
https://github.com/search?q=repo%3Apython%2Fcpython+expand_makefile_vars&type=commitshttps://github.com/search?q=repo%3Apython%2Fcpython+expand_makefile_vars&type=commits
https://github.com/picnixz
picnixzhttps://github.com/picnixz
on Jan 20, 2025https://github.com/python/cpython/issues/128978#issuecomment-2602382159
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
on Jan 20, 2025https://github.com/python/cpython/issues/128978#issuecomment-2602394612
picnixzhttps://github.com/picnixz
on Jan 20, 2025https://github.com/python/cpython/issues/128978#event-15998953787
gh-128978: Fix a `NameError` in `sysconfig.expand_makefile_vars` (#12…https://github.com/python/cpython/commit/df66ff14b49f4388625212f6bc86b754cb51d4eb
gh-128978https://github.com/python/cpython/issues/128978
#12…https://github.com/python/cpython/pull/128979
df66ff1https://github.com/python/cpython/commit/df66ff14b49f4388625212f6bc86b754cb51d4eb
miss-islingtonhttps://github.com/miss-islington
on Jan 20, 2025https://github.com/python/cpython/issues/128978#event-15998955613
pythongh-128978: Fix a `NameError` in `sysconfig.expand_makefile_vars` (https://github.com/miss-islington/cpython/commit/9356f95a265e54b5e4d62c0e6d45da2bb30d6a14
pythongh-128978https://github.com/python/cpython/issues/128978
9356f95https://github.com/miss-islington/cpython/commit/9356f95a265e54b5e4d62c0e6d45da2bb30d6a14
pythongh-128978: Fix a `NameError` in `sysconfig.expand_makefile_vars` (https://github.com/miss-islington/cpython/commit/837e5d27fc97903b519f283c08d859a233323836
pythongh-128978https://github.com/python/cpython/issues/128978
837e5d2https://github.com/miss-islington/cpython/commit/837e5d27fc97903b519f283c08d859a233323836
picnixzhttps://github.com/picnixz
3.12only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.12%22
on Jan 20, 2025https://github.com/python/cpython/issues/128978#event-15998983150
picnixzhttps://github.com/picnixz
on Jan 20, 2025https://github.com/python/cpython/issues/128978#event-15999322244
[3.13] gh-128978: Fix a `NameError` in `sysconfig.expand_makefile_var…https://github.com/python/cpython/commit/55d3d8165c0aa522d90fe92b92ade74beb27d9f9
gh-128978https://github.com/python/cpython/issues/128978
55d3d81https://github.com/python/cpython/commit/55d3d8165c0aa522d90fe92b92ade74beb27d9f9
picnixzhttps://github.com/picnixz
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jan 20, 2025https://github.com/python/cpython/issues/128978#event-15999799925
https://github.com/FFY00
FFY00https://github.com/FFY00
on Jan 20, 2025https://github.com/python/cpython/issues/128978#issuecomment-2602685530
https://github.com/search?q=expand_makefile_vars%20language:Python&type=code&l=Pythonhttps://github.com/search?q=expand_makefile_vars%20language:Python&type=code&l=Python
srinivasreddyhttps://github.com/srinivasreddy
on Jan 21, 2025https://github.com/python/cpython/issues/128978#event-16008332431
pythongh-128978: Fix a `NameError` in `sysconfig.expand_makefile_vars` (https://github.com/srinivasreddy/cpython/commit/598cb086e2a666cc5af9fbfeec8949bf56839a89
pythongh-128978https://github.com/python/cpython/issues/128978
598cb08https://github.com/srinivasreddy/cpython/commit/598cb086e2a666cc5af9fbfeec8949bf56839a89
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/128978
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/128978
picnixzhttps://github.com/picnixz
3.13only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.13%22
3.14bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.14%22
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.