Title: KeyboardInterrupt about test for REPL was directly captured by the test program · Issue #128676 · python/cpython · GitHub
Open Graph Title: KeyboardInterrupt about test for REPL was directly captured by the test program · Issue #128676 · python/cpython
X Title: KeyboardInterrupt about test for REPL was directly captured by the test program · Issue #128676 · python/cpython
Description: Bug report Bug description: When I was writing test for PR #128467 # under class TestPyReplCompleter(line ≈ 806) Lib/test/test_pyrepl/test_pyrepl.py def test_completion_menu_cleared_after_KeyboardInterrupt(self): events = itertools.chain...
Open Graph Description: Bug report Bug description: When I was writing test for PR #128467 # under class TestPyReplCompleter(line ≈ 806) Lib/test/test_pyrepl/test_pyrepl.py def test_completion_menu_cleared_after_KeyboardI...
X Description: Bug report Bug description: When I was writing test for PR #128467 # under class TestPyReplCompleter(line ≈ 806) Lib/test/test_pyrepl/test_pyrepl.py def test_completion_menu_cleared_after_KeyboardI...
Opengraph URL: https://github.com/python/cpython/issues/128676
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"KeyboardInterrupt about test for REPL was directly captured by the test program","articleBody":"# Bug report\r\n\r\n### Bug description:\r\n\r\nWhen I was writing test for PR #128467\r\n\r\n```python\r\n# under class TestPyReplCompleter(line ≈ 806) Lib/test/test_pyrepl/test_pyrepl.py\r\n def test_completion_menu_cleared_after_KeyboardInterrupt(self):\r\n events = itertools.chain(\r\n code_to_events(\"int.\"),\r\n [\r\n Event(evt=\"key\", data=\"\\t\", raw=bytearray(b\"\\t\")),\r\n Event(evt=\"key\", data=\"\\t\", raw=bytearray(b\"\\t\")),\r\n Event(evt=\"key\", data=\"\\x03\", raw=bytearray(b\"\\x03\")), # Ctrl+C\r\n ],\r\n )\r\n\r\n namespace = {}\r\n reader = self.prepare_reader(events, namespace)\r\n output = multiline_input(reader, namespace)\r\n\r\n self.assertEqual(clean_screen(reader.screen), \"int.\") # asser condition isn't good now\r\n\r\n```\r\n\r\nI found the `KeyboardInterrupt` caused by `Event(evt=\"key\", data=\"\\x03\", raw=bytearray(b\"\\x03\"))` will be directly captured by the test program itself\r\n\r\n``````powershell\r\n# result of \".\\python.bat -m test test_pyrepl.test_pyrepl -v\"\r\n== Tests result: INTERRUPTED ==\r\n\r\n1 test omitted:\r\n test_pyrepl.test_pyrepl\r\n\r\nTest suite interrupted by signal SIGINT.\r\n\r\nTotal duration: 1.3 sec\r\nTotal tests: run=0\r\nTotal test files: run=0/1\r\nResult: INTERRUPTED\r\n``````\r\n\r\nSo I added a traceback in the test function\r\n\r\n``````python\r\n def test_completion_menu_cleared_after_KeyboardInterrupt(self):\r\n events = itertools.chain(\r\n code_to_events(\"int.\"),\r\n [\r\n Event(evt=\"key\", data=\"\\t\", raw=bytearray(b\"\\t\")),\r\n Event(evt=\"key\", data=\"\\t\", raw=bytearray(b\"\\t\")),\r\n Event(evt=\"key\", data=\"\\x03\", raw=bytearray(b\"\\x03\")), # Ctrl+C\r\n ],\r\n )\r\n\r\n namespace = {}\r\n reader = self.prepare_reader(events, namespace)\r\n\r\n try:\r\n output = multiline_input(reader, namespace)\r\n except KeyboardInterrupt:\r\n traceback.print_exc()\r\n\r\n self.assertEqual(clean_screen(reader.screen), \"int.\")\r\n\r\n``````\r\n\r\nI also added `traceback.print_exc()` in `Lib/_pyrepl/simple_interact.py(line ≈ 164)`(the user-facing REPL)\r\n\r\n```python\r\n except KeyboardInterrupt:\r\n traceback.print_exc() # here\r\n r = _get_reader()\r\n if r.input_trans is r.isearch_trans:\r\n r.do_cmd((\"isearch-end\", [\"\"]))\r\n if r.cmpltn_menu_choices:\r\n r.cmpltn_reset()\r\n r.pos = len(r.get_unicode())\r\n r.dirty = True\r\n r.refresh()\r\n r.in_bracketed_paste = False\r\n console.write(\"\\nKeyboardInterrupt\\n\")\r\n console.resetbuffer()\r\n```\r\n\r\nrecompile and run\r\n\r\n```python\r\nPython 3.14.0a3+ (heads/clean_suggestion-dirty:9801a103467, Jan 9 2025, 14:45:54) [MSC v.1942 64 bit (AMD64)] on win32\r\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\r\n\u003e\u003e\u003e Traceback (most recent call last):\r\n File \"E:\\0000__Python_Project\\00__cpython\\Lib\\_pyrepl\\simple_interact.py\", line 151, in run_multiline_interactive_console\r\n statement = multiline_input(more_lines, ps1, ps2)\r\n File \"E:\\0000__Python_Project\\00__cpython\\Lib\\_pyrepl\\readline.py\", line 389, in multiline_input\r\n return reader.readline()\r\n ~~~~~~~~~~~~~~~^^\r\n File \"E:\\0000__Python_Project\\00__cpython\\Lib\\_pyrepl\\reader.py\", line 801, in readline\r\n self.handle1()\r\n ~~~~~~~~~~~~^^\r\n File \"E:\\0000__Python_Project\\00__cpython\\Lib\\_pyrepl\\reader.py\", line 756, in handle1\r\n self.console.wait(100)\r\n ~~~~~~~~~~~~~~~~~^^^^^\r\n File \"E:\\0000__Python_Project\\00__cpython\\Lib\\_pyrepl\\windows_console.py\", line 486, in wait\r\n time.sleep(0.01)\r\n ~~~~~~~~~~^^^^^^\r\nKeyboardInterrupt\r\n\r\nKeyboardInterrupt\r\n\u003e\u003e\u003e\r\n```\r\n\r\nAt the same time, the related error in the test is\r\n\r\n```python\r\nFile \"E:\\0000__Python_Project\\00__cpython\\Lib\\test\\test_pyrepl\\test_pyrepl.py\", line 864, in test_completion_menu_cleared_after_KeyboardInterrupt\r\n output = multiline_input(reader, namespace)\r\n File \"E:\\0000__Python_Project\\00__cpython\\Lib\\test\\test_pyrepl\\support.py\", line 18, in multiline_input\r\n return reader.readline()\r\n ~~~~~~~~~~~~~~~^^\r\n File \"E:\\0000__Python_Project\\00__cpython\\Lib\\_pyrepl\\reader.py\", line 801, in readline\r\n self.handle1()\r\n ~~~~~~~~~~~~^^\r\n File \"E:\\0000__Python_Project\\00__cpython\\Lib\\_pyrepl\\reader.py\", line 784, in handle1\r\n self.do_cmd(cmd)\r\n ~~~~~~~~~~~^^^^^\r\n File \"E:\\0000__Python_Project\\00__cpython\\Lib\\_pyrepl\\reader.py\", line 709, in do_cmd\r\n command.do()\r\n ~~~~~~~~~~^^\r\n File \"E:\\0000__Python_Project\\00__cpython\\Lib\\_pyrepl\\commands.py\", line 227, in do\r\n raise KeyboardInterrupt\r\nKeyboardInterrupt\r\nFAIL\r\n\r\n# something...\r\n\r\n======================================================================\r\nFAIL: test_completion_menu_cleared_after_KeyboardInterrupt (test.test_pyrepl.test_pyrepl.TestPyReplCompleter.test_completion_menu_cleared_after_KeyboardInterrupt)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n File \"E:\\0000__Python_Project\\00__cpython\\Lib\\test\\test_pyrepl\\test_pyrepl.py\", line 868, in test_completion_menu_cleared_after_KeyboardInterrupt\r\n self.assertEqual(clean_screen(reader.screen), \"int.\")\r\n ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\nAssertionError: 'int.as_integer_ratio( int.denominator [259 chars]int.' != 'int.'\r\n+ int.\r\n- int.as_integer_ratio( int.denominator int.mro()\r\n- int.bit_count( int.from_bytes( int.numerator\r\n- int.bit_length( int.imag int.real\r\n- int.conjugate( int.is_integer( int.to_bytes(\r\n- \u003e\u003e\u003eint.\r\n\r\n\r\n----------------------------------------------------------------------\r\n\r\n```\r\n\r\nSo the `KeyboardInterrupt` in test did not behave correctly as if the user pressed `Ctrl+C`, but was directly captured by the test program\r\n\r\n\r\n### CPython versions tested on:\r\n\r\nCPython main branch\r\n\r\n### Operating systems tested on:\r\n\r\nWindows","author":{"url":"https://github.com/Natural-selection1","@type":"Person","name":"Natural-selection1"},"datePublished":"2025-01-09T13:11:39.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/128676/cpython/issues/128676"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:1ad6c285-2511-1d40-8a32-acf330739966 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8368:CF40E:97237:D5538:696A6A49 |
| html-safe-nonce | 6492bd4b6733ab24a5479116934b9efbd6fd61188bce95246480162259ff6342 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzY4OkNGNDBFOjk3MjM3OkQ1NTM4OjY5NkE2QTQ5IiwidmlzaXRvcl9pZCI6Ijc4Mzg3MTU5ODU4Nzc2OTA5NTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 93afbc3ab760ba9ab1367d49b01b2b0980f19b608d5b248620af0a9da91adc54 |
| hovercard-subject-tag | issue:2777805940 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/128676/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c5cfac9e511617e602b4ed4f3f4659358bce2e6c5cbdeb93ca3f5973218b0486/python/cpython/issues/128676 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c5cfac9e511617e602b4ed4f3f4659358bce2e6c5cbdeb93ca3f5973218b0486/python/cpython/issues/128676 |
| og:image:alt | Bug report Bug description: When I was writing test for PR #128467 # under class TestPyReplCompleter(line ≈ 806) Lib/test/test_pyrepl/test_pyrepl.py def test_completion_menu_cleared_after_KeyboardI... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Natural-selection1 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6fea32d5b7276b841b7a803796d9715bc6cfb31ed549fdf9de2948ac25d12ba6 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f2d9f6432a5a115ec709295ae70623f33bb80aee |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width