Title: Explicit imports in tkinter.simpledialog · Issue #127930 · python/cpython · GitHub
Open Graph Title: Explicit imports in tkinter.simpledialog · Issue #127930 · python/cpython
X Title: Explicit imports in tkinter.simpledialog · Issue #127930 · python/cpython
Description: Feature or enhancement Proposal: In #14864, most of the tkinter submodules were changed to use explicit imports instead of from tkinter import *. tkinter.simpledialog didn't get that update, and is the only one still using the star impor...
Open Graph Description: Feature or enhancement Proposal: In #14864, most of the tkinter submodules were changed to use explicit imports instead of from tkinter import *. tkinter.simpledialog didn't get that update, and is...
X Description: Feature or enhancement Proposal: In #14864, most of the tkinter submodules were changed to use explicit imports instead of from tkinter import *. tkinter.simpledialog didn't get that update, an...
Opengraph URL: https://github.com/python/cpython/issues/127930
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Explicit imports in tkinter.simpledialog","articleBody":"# Feature or enhancement\n\n### Proposal:\n\nIn https://github.com/python/cpython/pull/14864, most of the tkinter submodules were changed to use explicit imports instead of `from tkinter import *`. tkinter.simpledialog didn't get that update, and is the only one still using the star import. I think we should update simpledialog to use explicit imports as well.\n\nThis is best practice, and also relevant to typeshed, where stubtest detects the extra constants imported into tkinter.simpledialog and emits a warning that they're not present in the stubs.\n\n### Has this already been discussed elsewhere?\n\nThis is a minor feature, which does not need previous discussion elsewhere\n\n### Links to previous discussion of this feature:\n\n_No response_\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-127931\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/tungol","@type":"Person","name":"tungol"},"datePublished":"2024-12-13T21:20:01.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/127930/cpython/issues/127930"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:de11f99f-9d17-8310-ee5e-cb478b4e1003 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9586:1691AA:587BD74:7CAC069:6A4FFA8A |
| html-safe-nonce | 71e880bd82f720db7c32e0bb29e68ed238de6a22cebca9a5501fa343f3426652 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTg2OjE2OTFBQTo1ODdCRDc0OjdDQUMwNjk6NkE0RkZBOEEiLCJ2aXNpdG9yX2lkIjoiODMwMDY0NzgyNzQ3NTc5MDQ3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 36df77ddc74ee4b87b1ba6011b10181062d7eeb666fd3a94959d46a0e3c48ca0 |
| hovercard-subject-tag | issue:2739227499 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/127930/issue_layout |
| twitter:image | https://opengraph.githubassets.com/458d52e5becccf8eab3758efaf43643fd71a41f4ebf31b991930a44bcc37d2af/python/cpython/issues/127930 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/458d52e5becccf8eab3758efaf43643fd71a41f4ebf31b991930a44bcc37d2af/python/cpython/issues/127930 |
| og:image:alt | Feature or enhancement Proposal: In #14864, most of the tkinter submodules were changed to use explicit imports instead of from tkinter import *. tkinter.simpledialog didn't get that update, and is... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tungol |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3bd0ff5d28a87b4801a63fb38c2a21a91b0a700dca159dc9416aeae05771b899 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 67a336083e4dcb40224dc2c01cd4c7ed413bdb09 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width