Title: test_ssl often fails against OpenSSL 3.4.0 · Issue #127026 · python/cpython · GitHub
Open Graph Title: test_ssl often fails against OpenSSL 3.4.0 · Issue #127026 · python/cpython
X Title: test_ssl often fails against OpenSSL 3.4.0 · Issue #127026 · python/cpython
Description: Bug report Bug description: test_ssl often fails on the main, 3.13 and 3.12 branches when running make test. (This is on an M1 MacBook Pro running MacOS 15.1.) Sometimes it fails the first time, succeeds when rerun, fails both times, or ...
Open Graph Description: Bug report Bug description: test_ssl often fails on the main, 3.13 and 3.12 branches when running make test. (This is on an M1 MacBook Pro running MacOS 15.1.) Sometimes it fails the first time, su...
X Description: Bug report Bug description: test_ssl often fails on the main, 3.13 and 3.12 branches when running make test. (This is on an M1 MacBook Pro running MacOS 15.1.) Sometimes it fails the first time, su...
Opengraph URL: https://github.com/python/cpython/issues/127026
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"test_ssl often fails against OpenSSL 3.4.0","articleBody":"# Bug report\n\n### Bug description:\n\n`test_ssl` often fails on the `main`, `3.13` and `3.12` branches when running `make test`. (This is on an M1 MacBook Pro running MacOS 15.1.) Sometimes it fails the first time, succeeds when rerun, fails both times, or doesn't fail at all. Though the tracebacks seem to be substantially different, the fundamental problem on 3.13 and main seems to be a bad TLS certificate. I see a different error on 3.12.\n\nHere's the latest (long) failure traceback on `main`:\n\n```\nTraceback (most recent call last):\n File \"/Users/skip/src/python/cpython/Lib/test/test_ssl.py\", line 2262, in wrap_conn\n self.sslconn = self.server.context.wrap_socket(\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^\n self.sock, server_side=True)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/Users/skip/src/python/cpython/Lib/ssl.py\", line 455, in wrap_socket\n return self.sslsocket_class._create(\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^\n sock=sock,\n ^^^^^^^^^^\n ...\u003c5 lines>...\n session=session\n ^^^^^^^^^^^^^^^\n )\n ^\n File \"/Users/skip/src/python/cpython/Lib/ssl.py\", line 1076, in _create\n self.do_handshake()\n ~~~~~~~~~~~~~~~~~^^\n File \"/Users/skip/src/python/cpython/Lib/ssl.py\", line 1372, in do_handshake\n self._sslobj.do_handshake()\n ~~~~~~~~~~~~~~~~~~~~~~~~~^^\n ssl.SSLError: [SSL: SSLV3_ALERT_BAD_CERTIFICATE] ssl/tls alert bad certificate (_ssl.c:1024)\n server: new connection from ('127.0.0.1', 62987)\n server: new connection from ('127.0.0.1', 62988)\n\n server: bad connection attempt from ('127.0.0.1', 62984):\nTraceback (most recent call last):\n File \"/Users/skip/src/python/cpython/Lib/test/test_ssl.py\", line 2262, in wrap_conn\n self.sslconn = self.server.context.wrap_socket(\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^\n self.sock, server_side=True)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/Users/skip/src/python/cpython/Lib/ssl.py\", line 455, in wrap_socket\n return self.sslsocket_class._create(\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^\n sock=sock,\n ^^^^^^^^^^\n ...\u003c5 lines>...\n session=session\n ^^^^^^^^^^^^^^^\n )\n ^\n File \"/Users/skip/src/python/cpython/Lib/ssl.py\", line 1076, in _create\n self.do_handshake()\n ~~~~~~~~~~~~~~~~~^^\n File \"/Users/skip/src/python/cpython/Lib/ssl.py\", line 1372, in do_handshake\n self._sslobj.do_handshake()\n ~~~~~~~~~~~~~~~~~~~~~~~~~^^\n ssl.SSLError: [SSL: SSLV3_ALERT_BAD_CERTIFICATE] ssl/tls alert bad certificate (_ssl.c:1024)\n\n server: bad connection attempt from ('127.0.0.1', 62987):\nTraceback (most recent call last):\n File \"/Users/skip/src/python/cpython/Lib/test/test_ssl.py\", line 2262, in wrap_conn\n self.sslconn = self.server.context.wrap_socket(\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^\n self.sock, server_side=True)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/Users/skip/src/python/cpython/Lib/ssl.py\", line 455, in wrap_socket\n return self.sslsocket_class._create(\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^\n sock=sock,\n ^^^^^^^^^^\n ...\u003c5 lines>...\n session=session\n ^^^^^^^^^^^^^^^\n )\n ^\n File \"/Users/skip/src/python/cpython/Lib/ssl.py\", line 1076, in _create\n self.do_handshake()\n ~~~~~~~~~~~~~~~~~^^\n File \"/Users/skip/src/python/cpython/Lib/ssl.py\", line 1372, in do_handshake\n self._sslobj.do_handshake()\n ~~~~~~~~~~~~~~~~~~~~~~~~~^^\n ssl.SSLError: [SSL: SSLV3_ALERT_BAD_CERTIFICATE] ssl/tls alert bad certificate (_ssl.c:1024)\n server: connection cipher is now ('TLS_AES_256_GCM_SHA384', 'TLSv1.3', 256)\n Connection reset by peer: ('127.0.0.1', 62988)\n server: new connection from ('127.0.0.1', 62993)\n```\n\nHere's the latest traceback from the `3.13` branch`:\n\n```\nRe-running test_ssl in verbose mode (matching: test_wrong_cert_tls13)\ntest_ssl: testing with 'OpenSSL 3.4.0 22 Oct 2024' (3, 4, 0, 0, 0)\n under Mac ('15.1', ('', '', ''), 'arm64')\n HAS_SNI = True\n OP_ALL = 0x80000050\n OP_NO_TLSv1_1 = 0x10000000\ntest_wrong_cert_tls13 (test.test_ssl.ThreadedTests.test_wrong_cert_tls13) ... server: new connection from ('127.0.0.1', 53960)\n\n server: bad connection attempt from ('127.0.0.1', 53960):\nTraceback (most recent call last):\n File \"/Users/skip/src/python/py3.13/Lib/test/test_ssl.py\", line 2275, in wrap_conn\n self.sslconn = self.server.context.wrap_socket(\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^\n self.sock, server_side=True)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/Users/skip/src/python/py3.13/Lib/ssl.py\", line 455, in wrap_socket\n return self.sslsocket_class._create(\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^\n sock=sock,\n ^^^^^^^^^^\n ...\u003c5 lines>...\n session=session\n ^^^^^^^^^^^^^^^\n )\n ^\n File \"/Users/skip/src/python/py3.13/Lib/ssl.py\", line 1076, in _create\n self.do_handshake()\n ~~~~~~~~~~~~~~~~~^^\n File \"/Users/skip/src/python/py3.13/Lib/ssl.py\", line 1372, in do_handshake\n self._sslobj.do_handshake()\n ~~~~~~~~~~~~~~~~~~~~~~~~~^^\n ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self-signed certificate (_ssl.c:1020)\nFAIL\n```\n\n3.12:\n\n```\n% ./python.exe -m test test_ssl\nUsing random seed: 2271976119\n0:00:00 load avg: 1.25 Run 1 test sequentially\n0:00:00 load avg: 1.25 [1/1] test_ssl\ntest test_ssl failed -- Traceback (most recent call last):\n File \"/Users/skip/src/python/py3.12/Lib/test/test_ssl.py\", line 4882, in test_preauth_data_to_tls_server\n self.assertIn(\"before TLS handshake with data\", wrap_error.args[1])\nAssertionError: 'before TLS handshake with data' not found in '[SSL] record layer failure (_ssl.c:1000)'\n```\n\nJust after the above failure, I ran the same command and it succeeded...\n\n\nIn all three cases, `_ssl...so` was linked against OpenSSL 3.4.0, for example:\n\n```\n% otool -L Modules/_ssl.cpython-313t-darwin.so\nModules/_ssl.cpython-313t-darwin.so:\n\t/opt/homebrew/opt/openssl@3/lib/libssl.3.dylib (compatibility version 3.0.0, current version 3.0.0)\n\t/opt/homebrew/opt/openssl@3/lib/libcrypto.3.dylib (compatibility version 3.0.0, current version 3.0.0)\n\t/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1351.0.0)\n(py313t) ~/src/python/py3.13% ls -l /opt/homebrew/opt/openssl@3\nlrwxr-xr-x 1 skip admin 25 Oct 31 14:02 /opt/homebrew/opt/openssl@3 -> ../Cellar/openssl@3/3.4.0\n```\n\nI don't recall if I saw failures against earlier OpenSSL versions. Is 3.4.0 maybe different enough that the `_ssl.c` code has to be tweaked a bit?\n\n\n### CPython versions tested on:\n\n3.12, 3.13, CPython main branch\n\n### Operating systems tested on:\n\nmacOS","author":{"url":"https://github.com/smontanaro","@type":"Person","name":"smontanaro"},"datePublished":"2024-11-19T17:04:46Z","url":"https://github.com/python/cpython/issues/127026"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:f34669d0-c3a9-b7e2-3dcb-b3dd6fab496b |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9ADC:62F48:1861119:2002142:6B023F3C |
| html-safe-nonce | d3dc3e85bd4f228235bc401eb17123f480feb6aaeca856129debc09d3865a0d4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QURDOjYyRjQ4OjE4NjExMTk6MjAwMjE0Mjo2QjAyM0YzQyIsInZpc2l0b3JfaWQiOiIzNzM3MDU1NjA3MzAwMTc3NzI0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ccdb415a9ba1b56f3916b9411ce51f7ef46603fc0002afde5b1d0c54b46d33aa |
| hovercard-subject-tag | issue:2672895486 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/127026/issue_layout |
| twitter:image | https://opengraph.githubassets.com/b8a54361142729924512137c2df90d98af7e60c2804c75ae1f14cfe87f98765b/python/cpython/issues/127026 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b8a54361142729924512137c2df90d98af7e60c2804c75ae1f14cfe87f98765b/python/cpython/issues/127026 |
| og:image:alt | Bug report Bug description: test_ssl often fails on the main, 3.13 and 3.12 branches when running make test. (This is on an M1 MacBook Pro running MacOS 15.1.) Sometimes it fails the first time, su... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | smontanaro |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width