René's URL Explorer Experiment


Title: Move const folding to the peephole optimizer · Issue #126835 · python/cpython · GitHub

Open Graph Title: Move const folding to the peephole optimizer · Issue #126835 · python/cpython

X Title: Move const folding to the peephole optimizer · Issue #126835 · python/cpython

Description: Feature or enhancement Proposal: For additional context see #126830 (comment). Flow graph optimizer has more information and can do better job. The problem is that we need to convert from UNARY_OP(-, CONST(1)) to CONST(-1), still before ...

Open Graph Description: Feature or enhancement Proposal: For additional context see #126830 (comment). Flow graph optimizer has more information and can do better job. The problem is that we need to convert from UNARY_OP(...

X Description: Feature or enhancement Proposal: For additional context see #126830 (comment). Flow graph optimizer has more information and can do better job. The problem is that we need to convert from UNARY_OP(...

Opengraph URL: https://github.com/python/cpython/issues/126835

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Move const folding to the peephole optimizer","articleBody":"# Feature or enhancement\n\n### Proposal:\n\nFor additional context see https://github.com/python/cpython/pull/126830#issuecomment-2476525196.\n\nFlow graph optimizer has more information and can do better job.\n\nThe problem is that we need to convert from `UNARY_OP(-, CONST(1))` to `CONST(-1)`, still before the code generation phase, because this leads to a few problems, one of which is shown below.\n```python\nx = 1\n\nmatch x:\n    case -0:\n        y = 0\n```\n\n```\neclips4@nixos ~/p/p/cpython (remove-ast-optimizer)\u003e ./python example.py\n  File \"/home/eclips4/programming/programming-languages/cpython/example.py\", line 4\n    case -0:\n         ^^\nSyntaxError: patterns may only match literals and attribute lookups\n```\n\n\ncc @markshannon \n\n\n\n### Has this already been discussed elsewhere?\n\nNo response given\n\n### Links to previous discussion of this feature:\n\n_No response_\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-128802\n* gh-129426\n* gh-129550\n* gh-129568\n* gh-129634\n* gh-129703\n* gh-129963\n* gh-130016\n* gh-130032\n* gh-130109\n* gh-130769\n* gh-131054\n* gh-131826\n* gh-131830\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/Eclips4","@type":"Person","name":"Eclips4"},"datePublished":"2024-11-14T18:08:07.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":122},"url":"https://github.com/126835/cpython/issues/126835"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:c4c97742-bd9c-27ac-c955-9af63f9f6985
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD3D4:3A6082:23C3CFC:2EB305D:696B5AE1
html-safe-nonce7d3467d6b15091dd5a59417f6898e26f7c4e4b4bf94bd43e3ebab0c96f9f02dc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEM0Q0OjNBNjA4MjoyM0MzQ0ZDOjJFQjMwNUQ6Njk2QjVBRTEiLCJ2aXNpdG9yX2lkIjoiODc5OTI2MTUyNDQzMDExNzYwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3455d9a62998b4a10949d256b1ce715bce6da75043d8686b6edab7b27b17fbba
hovercard-subject-tagissue:2659638853
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/126835/issue_layout
twitter:imagehttps://opengraph.githubassets.com/219e0e8c6ad3277b548d9920421eb8d71b248eedf0aa6a45a045b76684ce9223/python/cpython/issues/126835
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/219e0e8c6ad3277b548d9920421eb8d71b248eedf0aa6a45a045b76684ce9223/python/cpython/issues/126835
og:image:altFeature or enhancement Proposal: For additional context see #126830 (comment). Flow graph optimizer has more information and can do better job. The problem is that we need to convert from UNARY_OP(...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameEclips4
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/126835#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F126835
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F126835
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/126835
Reloadhttps://github.com/python/cpython/issues/126835
Reloadhttps://github.com/python/cpython/issues/126835
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/126835
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/issues/126835
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/126835
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/126835
Move const folding to the peephole optimizerhttps://github.com/python/cpython/issues/126835#top
https://github.com/tomasr8
https://github.com/Eclips4
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
https://github.com/Eclips4
https://github.com/Eclips4
Eclips4https://github.com/Eclips4
on Nov 14, 2024https://github.com/python/cpython/issues/126835#issue-2659638853
#126830 (comment)https://github.com/python/cpython/pull/126830#issuecomment-2476525196
@markshannonhttps://github.com/markshannon
gh-126835: Disable tuple folding in the AST optimizer #128802https://github.com/python/cpython/pull/128802
gh-126835: Move optimization of constant sequence creation from codegen to CFG #129426https://github.com/python/cpython/pull/129426
gh-126835: Move constant unaryop & binop folding to CFG #129550https://github.com/python/cpython/pull/129550
gh-126835: Move constant subscript folding to CFG #129568https://github.com/python/cpython/pull/129568
gh-126835: Fix optimize_if_const_subscr refleaks #129634https://github.com/python/cpython/pull/129634
gh-126835: make CFG optimizer skip over NOP's when looking for const sequence construction #129703https://github.com/python/cpython/pull/129703
gh-126835: Fold unary & binary complex constant expressions during code generation. #129963https://github.com/python/cpython/pull/129963
gh-126835: Remove unused docstring const #130016https://github.com/python/cpython/pull/130016
gh-126835: Move const list & set folding in for_iter & contains from ast_opt.c to flowgraph.c #130032https://github.com/python/cpython/pull/130032
gh-126835: Set location for noped out instructions after constant folding in CFG. #130109https://github.com/python/cpython/pull/130109
gh-126835: Move constant tuple folding to CFG #130769https://github.com/python/cpython/pull/130769
gh-126835: Avoid creating unnecessary tuple when looking for constant sequence during constant folding #131054https://github.com/python/cpython/pull/131054
gh-126835: Refine constant folding tests in test_peepholer.py::TestTranforms #131826https://github.com/python/cpython/pull/131826
gh-126835: Rename AST optimization related stuff after moving const folding to the peephole optimizier #131830https://github.com/python/cpython/pull/131830
Eclips4https://github.com/Eclips4
tomasr8https://github.com/tomasr8
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.