Title: "Check if generated files are up to date" job misses `regen-unicodedata` and `regen-limited-abi` · Issue #126524 · python/cpython · GitHub
Open Graph Title: "Check if generated files are up to date" job misses `regen-unicodedata` and `regen-limited-abi` · Issue #126524 · python/cpython
X Title: "Check if generated files are up to date" job misses `regen-unicodedata` and `regen-limited-abi` · Issue #126524 · python/cpython
Description: Feature or enhancement Currently our regen-all is missing several regen- targets: @echo "Note: make regen-stdlib-module-names, make regen-limited-abi, " @echo "make regen-configure, make regen-sbom, and make regen-unicodedata should be r...
Open Graph Description: Feature or enhancement Currently our regen-all is missing several regen- targets: @echo "Note: make regen-stdlib-module-names, make regen-limited-abi, " @echo "make regen-configure, make regen-sbom...
X Description: Feature or enhancement Currently our regen-all is missing several regen- targets: @echo "Note: make regen-stdlib-module-names, make regen-limited-abi, " @echo "make regen-configure, ...
Opengraph URL: https://github.com/python/cpython/issues/126524
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"\"Check if generated files are up to date\" job misses `regen-unicodedata` and `regen-limited-abi`","articleBody":"# Feature or enhancement\n\nCurrently our `regen-all` is missing several `regen-` targets:\n\n```\n@echo \"Note: make regen-stdlib-module-names, make regen-limited-abi, \"\n@echo \"make regen-configure, make regen-sbom, and make regen-unicodedata should be run manually\"\n```\n\nWhile our CI job to check regenerated files does not check them: https://github.com/python/cpython/blob/2a6b6b33dfe0f3c435abf2829b62ef3f1ef12cd3/.github/workflows/build.yml#L120-L124\n\nThis does not seem right, I think that we should add:\n- `make regen-unicodedata` (it requires internet access, but GitHub jobs always have access, see https://github.com/python/cpython/pull/112120)\n- `make regen-limited-abi` (needs to compile python to get the ABI)\n\nHow long does it work? Testing locally first:\n\n```\nmake regen-unicodedata 9.44s user 0.47s system 27% cpu 35.719 total\nmake regen-limited-abi 2.35s user 0.76s system 77% cpu 4.019 total (with pre-existing cache)\n```\n\nI propose adding these two `make` targets to the test to be extra safe.\nWhat do others think? :)\nIf agreed, I will send a PR.\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-126682\n* gh-127594\n* gh-127595\n* gh-138197\n* gh-138218\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/sobolevn","@type":"Person","name":"sobolevn"},"datePublished":"2024-11-07T06:28:56Z","url":"https://github.com/python/cpython/issues/126524"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:53056c15-545e-b6f7-59f8-c317ef267d85 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D2D8:2A98A:312C99:3DFD8A:6B020980 |
| html-safe-nonce | 5371df1a87e2acf4fa1a5eb31d60826baa497df02f8ba11f64a801656c273531 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkQ4OjJBOThBOjMxMkM5OTozREZEOEE6NkIwMjA5ODAiLCJ2aXNpdG9yX2lkIjoiNzYzODc0MTg4MzQwMDg4MjU2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 847338945278ea92910a2ab6637e9e88feae8ee3c2ee7e07647ec201f15b6ddd |
| hovercard-subject-tag | issue:2640013348 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/126524/issue_layout |
| twitter:image | https://opengraph.githubassets.com/5022fcadcbb3e1722511f6fcc1afcbf6bc6e80d27bcacba50bbc8765ce6097f8/python/cpython/issues/126524 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5022fcadcbb3e1722511f6fcc1afcbf6bc6e80d27bcacba50bbc8765ce6097f8/python/cpython/issues/126524 |
| og:image:alt | Feature or enhancement Currently our regen-all is missing several regen- targets: @echo "Note: make regen-stdlib-module-names, make regen-limited-abi, " @echo "make regen-configure, make regen-sbom... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sobolevn |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width