René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"test_ssl: ConnectionHandler shuts down ThreadedEchoServer","articleBody":"\r\nRecently, `test_ssl` has been failing intermittently but frequently on macOS buildbots, see for example [here](https://buildbot.python.org/#/builders/725/builds/8906) (but look at the *first* failure; the re-run is #126499).\r\n\r\n\r\nIf `read()` in a `ThreadedEchoServer`'s `ConnectionHandler` thread raises `OSError` (except `ConnectionError`), the `ConnectionHandler` shuts down the entire server, preventing further connections.\r\n\r\nAs far as I can see, this is done to avoid the server thread getting stuck, forgotten, in its accept loop. However, since 2011 (5b95eb90a7167285b6544b50865227c584943c9a) the server is used as a context manager, and its `__exit__` does `stop()` and `join()`.\r\n(I'm not sure if we *always* used `with` since that commit, but currently we do.)\r\n\r\nThe most common failure I saw is the following. Note that it's the *third* `connect` call in this test: presumably, if the server thread started shutting down after the first `connect` it had enough time by now. But sometimes the same happens with the second `connect`, in this test or another one.\r\n```\r\nTraceback (most recent call last):\r\n  File \"/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ssl.py\", line 1897, in test_connect_with_context\r\n    s.connect(self.server_addr)\r\n    ~~~~~~~~~^^^^^^^^^^^^^^^^^^\r\n  File \"/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/ssl.py\", line 1405, in connect\r\n    self._real_connect(addr, False)\r\n    ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^\r\n  File \"/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/ssl.py\", line 1392, in _real_connect\r\n    super().connect(addr)\r\n    ~~~~~~~~~~~~~~~^^^^^^\r\nConnectionRefusedError: [Errno 61] Connection refused\r\n```\r\n\r\nI'll send a PR soon.\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-126503\n* gh-126571\n* gh-126572\n* gh-133148\n* gh-134030\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/encukou","@type":"Person","name":"encukou"},"datePublished":"2024-11-06T14:13:29.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/126500/cpython/issues/126500"}