René's URL Explorer Experiment


Title: The return value of function `math.isclose` can be somewhat misleading · Issue #126165 · python/cpython · GitHub

Open Graph Title: The return value of function `math.isclose` can be somewhat misleading · Issue #126165 · python/cpython

X Title: The return value of function `math.isclose` can be somewhat misleading · Issue #126165 · python/cpython

Description: Documentation The following example may be misleading to people who are not familiar with the function: >>> math.isclose(math.sin(0), 0) ... True >>> math.isclose(math.sin(math.pi), 0) ... False >>> To a newbie, the above results seem ri...

Open Graph Description: Documentation The following example may be misleading to people who are not familiar with the function: >>> math.isclose(math.sin(0), 0) ... True >>> math.isclose(math.sin(math.pi), 0) ... False >>...

X Description: Documentation The following example may be misleading to people who are not familiar with the function: >>> math.isclose(math.sin(0), 0) ... True >>> math.isclose(math.sin(math.pi...

Opengraph URL: https://github.com/python/cpython/issues/126165

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"The return value of function `math.isclose` can be somewhat misleading","articleBody":"# Documentation\r\n\r\nThe following example may be misleading to people who are not familiar with the function:\r\n\r\n```python\r\n\u003e\u003e\u003e math.isclose(math.sin(0), 0)\r\n... True\r\n\u003e\u003e\u003e math.isclose(math.sin(math.pi), 0)\r\n... False\r\n\u003e\u003e\u003e \r\n```\r\n\r\nTo a newbie, the above results seem ridiculous. Correspondingly, the result in `numpy` is as follows:\r\n\r\n```python\r\n\u003e\u003e\u003e numpy.isclose(math.sin(0), 0)\r\n... np.True_\r\n\u003e\u003e\u003e numpy.isclose(math.sin(math.pi), 0)\r\n... np.True_\r\n\u003e\u003e\u003e \r\n```\r\n\r\nFor reference, some values are given here:\r\n\r\n```python\r\n\u003e\u003e\u003e math.sin(0)\r\n... 0.0\r\n\u003e\u003e\u003e math.sin(math.pi)\r\n... 1.2246467991473532e-16\r\n\u003e\u003e\u003e \r\n```\r\n\r\nI think, the reason for this is that the default value of parameter `abs_tol` for function `math.isclose` is too small. Here are the definitions of the two functions mentioned above:\r\n\r\n```python\r\nmath.isclose(a, b, *, rel_tol=1e-09, abs_tol=0.0)\r\nnumpy.isclose(a, b, rtol=1e-05, atol=1e-08, equal_nan=False)\r\n```\r\n\r\nI think we might need to state this in the docstring of function `math.isclose`, ~~or increase the value of the default parameter `abs_tol` appropriately.~~\r\n\r\nBy the way, the `numpy` version I'm using here is *v2.1*.\r\n\r\nIf there is something wrong with my previous content, please feel free to point it out, thank you!\r\n\r\n\r\n### CPython versions tested on:\r\n\r\n3.13\r\n\r\n### Operating systems tested on:\r\n\r\nWindows\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-126215\n* gh-126380\n* gh-126381\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/Xiaokang2022","@type":"Person","name":"Xiaokang2022"},"datePublished":"2024-10-30T03:31:04.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":16},"url":"https://github.com/126165/cpython/issues/126165"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:d2f100f2-862c-408c-6ab9-819cb1890605
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA07C:388B78:DE153E:11F6628:696B0485
html-safe-noncefda1efc9cbccdd75442824b11f611b68d9c5aa3c3e858017e6829d1cbd4acdba
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDdDOjM4OEI3ODpERTE1M0U6MTFGNjYyODo2OTZCMDQ4NSIsInZpc2l0b3JfaWQiOiI2Mzg5NzcyNjMwNzE3MzAxODkzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac342ce72c5b6421c19fe0fbc97d553ad23131b5871feb3391329dabccb970803b
hovercard-subject-tagissue:2622780097
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/126165/issue_layout
twitter:imagehttps://opengraph.githubassets.com/5c1d91bb8f003845514b69ff65c88b31aa794e43363c086a111ac8be17e9bc5b/python/cpython/issues/126165
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5c1d91bb8f003845514b69ff65c88b31aa794e43363c086a111ac8be17e9bc5b/python/cpython/issues/126165
og:image:altDocumentation The following example may be misleading to people who are not familiar with the function: >>> math.isclose(math.sin(0), 0) ... True >>> math.isclose(math.sin(math.pi), 0) ... False >>...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameXiaokang2022
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/126165#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F126165
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F126165
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/126165
Reloadhttps://github.com/python/cpython/issues/126165
Reloadhttps://github.com/python/cpython/issues/126165
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/126165
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/issues/126165
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/126165
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/126165
The return value of function math.isclose can be somewhat misleadinghttps://github.com/python/cpython/issues/126165#top
docsDocumentation in the Doc dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22docs%22
https://github.com/Xiaokang2022
https://github.com/Xiaokang2022
Xiaokang2022https://github.com/Xiaokang2022
on Oct 30, 2024https://github.com/python/cpython/issues/126165#issue-2622780097
gh-126165: Improve docs of function math.isclose #126215https://github.com/python/cpython/pull/126215
[3.13] gh-126165: Improve docs of function math.isclose (GH-126215) #126380https://github.com/python/cpython/pull/126380
[3.12] gh-126165: Improve docs of function math.isclose (GH-126215) #126381https://github.com/python/cpython/pull/126381
docsDocumentation in the Doc dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22docs%22
docs issueshttps://github.com/orgs/python/projects/52
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.