René's URL Explorer Experiment


Title: Incorrect format passed to `__annotate__` function · Issue #125507 · python/cpython · GitHub

Open Graph Title: Incorrect format passed to `__annotate__` function · Issue #125507 · python/cpython

X Title: Incorrect format passed to `__annotate__` function · Issue #125507 · python/cpython

Description: Bug report Consider this example: class My: def __annotate__(format): assert format == 2, format return {} import annotationlib annotationlib.get_annotations(My, format=2) This will fail with: Traceback (most recent call last): File "/Us...

Open Graph Description: Bug report Consider this example: class My: def __annotate__(format): assert format == 2, format return {} import annotationlib annotationlib.get_annotations(My, format=2) This will fail with: Trac...

X Description: Bug report Consider this example: class My: def __annotate__(format): assert format == 2, format return {} import annotationlib annotationlib.get_annotations(My, format=2) This will fail with: Trac...

Opengraph URL: https://github.com/python/cpython/issues/125507

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Incorrect format passed to `__annotate__` function","articleBody":"# Bug report\n\nConsider this example:\n\n```python\nclass My:\n    def __annotate__(format):\n        assert format == 2, format\n        return {}\n\nimport annotationlib\nannotationlib.get_annotations(My, format=2)\n```\n\nThis will fail with:\n\n```\nTraceback (most recent call last):\n  File \"/Users/sobolev/Desktop/cpython2/ex.py\", line 7, in \u003cmodule\u003e\n    annotationlib.get_annotations(My, format=2)\n    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^\n  File \"/Users/sobolev/Desktop/cpython2/Lib/annotationlib.py\", line 688, in get_annotations\n    return dict(_get_dunder_annotations(obj))\n                ~~~~~~~~~~~~~~~~~~~~~~~^^^^^\n  File \"/Users/sobolev/Desktop/cpython2/Lib/annotationlib.py\", line 817, in _get_dunder_annotations\n    ann = _BASE_GET_ANNOTATIONS(obj)\n  File \"/Users/sobolev/Desktop/cpython2/ex.py\", line 3, in __annotate__\n    assert format == 2, format\n           ^^^^^^^^^^^\nAssertionError: 1\n```\n\nI think that we should still pass the format in `_BASE_GET_ANNOTATIONS`.\n\nI will try to fix this, since this affects my other PR: https://github.com/python/cpython/pull/122262\n\nCC @JelleZijlstra \n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-125534\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/sobolevn","@type":"Person","name":"sobolevn"},"datePublished":"2024-10-15T09:44:02.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":9},"url":"https://github.com/125507/cpython/issues/125507"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:8c0cbd15-f61d-9c70-6e84-7fe56be0b3fe
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8D3E:2DCEFE:14D321:1BEDAE:696B3070
html-safe-noncea7c01ad23935bb555e35000e1e2a4b83e553f670e1217c666bee785087a601ac
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDNFOjJEQ0VGRToxNEQzMjE6MUJFREFFOjY5NkIzMDcwIiwidmlzaXRvcl9pZCI6IjM0MDk3NzYyNzMyMjk4MjAwMTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4008f0f66dc53692823c0522711c8734ca802e6f47aa789670ea2cfb3c040312
hovercard-subject-tagissue:2588218527
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/125507/issue_layout
twitter:imagehttps://opengraph.githubassets.com/3bd875bd71fe0ef795786c126c064bd02100f3f3261d8026553fd304b895e4b1/python/cpython/issues/125507
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3bd875bd71fe0ef795786c126c064bd02100f3f3261d8026553fd304b895e4b1/python/cpython/issues/125507
og:image:altBug report Consider this example: class My: def __annotate__(format): assert format == 2, format return {} import annotationlib annotationlib.get_annotations(My, format=2) This will fail with: Trac...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesobolevn
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/125507#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F125507
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F125507
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/125507
Reloadhttps://github.com/python/cpython/issues/125507
Reloadhttps://github.com/python/cpython/issues/125507
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/125507
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/issues/125507
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/125507
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/125507
Incorrect format passed to __annotate__ functionhttps://github.com/python/cpython/issues/125507#top
https://github.com/sobolevn
3.14bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.14%22
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
topic-typinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-typing%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/sobolevn
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
on Oct 15, 2024https://github.com/python/cpython/issues/125507#issue-2588218527
#122262https://github.com/python/cpython/pull/122262
@JelleZijlstrahttps://github.com/JelleZijlstra
gh-125507: Call annotate(FORWARDREF) before trying __annotations__ #125534https://github.com/python/cpython/pull/125534
sobolevnhttps://github.com/sobolevn
3.14bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.14%22
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
topic-typinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-typing%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.