Title: ZoneInfo comparison fails on free-threaded build · Issue #125243 · python/cpython · GitHub
Open Graph Title: ZoneInfo comparison fails on free-threaded build · Issue #125243 · python/cpython
X Title: ZoneInfo comparison fails on free-threaded build · Issue #125243 · python/cpython
Description: Bug report Bug description: (originally noticed by @davidhewitt in #116738 (comment)) Very infrequently, PyO3 tests for timezone conversions will fail with errors like: ---- conversions::chrono_tz::tests::test_into_pyobject stdout ---- t...
Open Graph Description: Bug report Bug description: (originally noticed by @davidhewitt in #116738 (comment)) Very infrequently, PyO3 tests for timezone conversions will fail with errors like: ---- conversions::chrono_tz:...
X Description: Bug report Bug description: (originally noticed by @davidhewitt in #116738 (comment)) Very infrequently, PyO3 tests for timezone conversions will fail with errors like: ---- conversions::chrono_tz:...
Opengraph URL: https://github.com/python/cpython/issues/125243
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ZoneInfo comparison fails on free-threaded build","articleBody":"# Bug report\n\n### Bug description:\n\n(originally noticed by @davidhewitt in https://github.com/python/cpython/issues/116738#issuecomment-2404360445)\n\nVery infrequently, PyO3 tests for timezone conversions will fail with errors like:\n\n```\n---- conversions::chrono_tz::tests::test_into_pyobject stdout ----\nthread 'conversions::chrono_tz::tests::test_into_pyobject' panicked at src/conversions/chrono_tz.rs:120:17:\nzoneinfo.ZoneInfo(key='UTC') != zoneinfo.ZoneInfo(key='UTC')\n```\n\nUnfortunately, I don't have an easier way to trigger this besides \"run the PyO3 tests over and over until you see a failure\", since I think triggering it requires many threads simultaneously using the C API which happens automatically with cargo for the PyO3 tests.\n\nThe test code is here:\n\nhttps://github.com/PyO3/pyo3/blob/eacebb8db101d05ae4ccf0396e314b098455ecd3/src/conversions/chrono_tz.rs#L116-L134\n\nI believe that rust is more or less doing the equivalent of this C code:\n\n```\n#include \u003cPython.h\u003e\n\nint main()\n{\n if (Py_IsInitialized() == 0) {\n Py_InitializeEx(0);\n\n PyObject *mod = PyImport_ImportModule(\"zoneinfo\");\n\n if (mod == NULL) {\n PyErr_PrintEx(0);\n return -1;\n }\n\n PyObject *zoneinfo = PyObject_GetAttrString(mod, \"ZoneInfo\");\n\n if (zoneinfo == NULL) {\n PyErr_PrintEx(0);\n return -1;\n }\n\n PyObject *arg = PyUnicode_FromString(\"Europe/Paris\");\n\n PyObject *obj1 = PyObject_CallOneArg(zoneinfo, arg);\n PyObject *obj2 = PyObject_CallOneArg(zoneinfo, arg);\n\n PyObject *result = PyObject_RichCompare(obj1, obj2, Py_EQ);\n\n PyObject_Print(result, stderr, Py_PRINT_RAW);\n }\n\n return 0;\n}\n```\n\nThis doesn't fail, which makes me suspect triggering it requires touching the C API in other threads.\n\n### CPython versions tested on:\n\n3.13\n\n### Operating systems tested on:\n\nmacOS\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-125281\n* gh-125414\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/ngoldbaum","@type":"Person","name":"ngoldbaum"},"datePublished":"2024-10-10T09:44:51.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":10},"url":"https://github.com/125243/cpython/issues/125243"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:6de49d62-e257-5dd9-71bd-ec9a355de29f |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D4A0:30DAA3:4741D:5F5F7:696A6A40 |
| html-safe-nonce | 72aef023f748452bab0b6086e06f8a1ee7dfaf93d34598f8d9d20d6dc7242bf6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENEEwOjMwREFBMzo0NzQxRDo1RjVGNzo2OTZBNkE0MCIsInZpc2l0b3JfaWQiOiIxODM3ODUyMjcxOTE5NjU1NDg4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 3b134efeb9183c6fac3678946c82e1d979db3f3d60f1ea834bf4d543eecee8be |
| hovercard-subject-tag | issue:2578257829 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/125243/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c61e41f75b92efad09c7ee73fc9c17065bf84f8132152b8c47d1810c1fac2251/python/cpython/issues/125243 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c61e41f75b92efad09c7ee73fc9c17065bf84f8132152b8c47d1810c1fac2251/python/cpython/issues/125243 |
| og:image:alt | Bug report Bug description: (originally noticed by @davidhewitt in #116738 (comment)) Very infrequently, PyO3 tests for timezone conversions will fail with errors like: ---- conversions::chrono_tz:... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ngoldbaum |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6fea32d5b7276b841b7a803796d9715bc6cfb31ed549fdf9de2948ac25d12ba6 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f2d9f6432a5a115ec709295ae70623f33bb80aee |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width