René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Split Up _testsinglephase.c and _testmultiphase.c","articleBody":"(low priority)\r\n\r\n`Modules/_testsinglephase.c` and `Modules/_testmultiphase.c` both contain the implementations of multiple modules.  We should consider splitting up both files, so each contained module has its own file.\r\n\r\nHere are several reasons why this may be worth doing:\r\n\r\n* testing with a module hidden in another's .so file is awkward and makes those tests harder to understand\r\n* it's easier to accidentally leak C-module global data between modules when they are implemented in the same file\r\n* when adding a new module, it's trickier (less familiar) to implement it in an existing file than in a new file [^1]\r\n\r\n[^1]: However, adding it to an existing file is also simpler in how adding a new file involves tweaking the build.  See [the devguide](https://devguide.python.org/developer-workflow/extension-modules/#adding-an-extension-module-to-cpython).\r\n\r\nFurthermore, both files were added to test specific import functionality.  As far as I can tell[^2], that never included any need for the multiple-modules-in-one-file approach.  However, currently they are the only place where we're testing the feature, regardless of how unintentionally or superficially.  [gh-124978](https://github.com/python/cpython/issues/124978) targets fixing that lack of explicit testing, including moving away from `_testsinglephase.c` and `_testmultiphase.c` (e.g. using the dedicated `Modules/_testimportmultiple.c`).\r\n\r\n[^2]: I personally added `Modules/_testsinglephase.c` and @encukou added `_testmultiphase.c`.\r\n\r\nAll that said, splitting up the files is a fairly low priority task.  The status quo isn't ideal but it isn't that bad either.\r\n\r\n----\r\n\r\nHere's how I see us taking care of this:\r\n\r\n1. make sure multiple-modules-in-one-file is tested via the dedicated `Modules/_testimportmultiple.c` [^2] (see [gh-124978](https://github.com/python/cpython/issues/124978))\r\n2. create the `Modules/_testsinglephase` directory\r\n3. move each module from `_testsinglephase.c` to its own file  (see [the devguide](https://devguide.python.org/developer-workflow/extension-modules/#adding-an-extension-module-to-cpython))\r\n4. update the relevant tests\r\n5. delete `Modules/_testsinglephase.c`\r\n6. repeat steps 2-5 for `Modules/_testmultiphase.c`","author":{"url":"https://github.com/ericsnowcurrently","@type":"Person","name":"ericsnowcurrently"},"datePublished":"2024-10-04T19:47:48.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/124983/cpython/issues/124983"}