René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`test_pkgutil` should clean up `spam` module","articleBody":"When running the tests with --randomize, as is done by the buildbots,  @mhsmith  came across this failure:\r\n\r\n```\r\n======================================================================\r\nERROR: test_find_class (test.test_pickle.CUnpicklerTests.test_find_class)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/Users/msmith/git/python/cpython/Lib/test/pickletester.py\", line 1265, in test_find_class\r\n    self.assertRaises(ModuleNotFoundError, unpickler.find_class, 'spam', 'log')\r\n    ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n  File \"/Users/msmith/git/python/cpython/Lib/unittest/case.py\", line 804, in assertRaises\r\n    return context.handle('assertRaises', args, kwargs)\r\n           ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n  File \"/Users/msmith/git/python/cpython/Lib/unittest/case.py\", line 238, in handle\r\n    callable_obj(*args, **kwargs)\r\n    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^\r\nAttributeError: module 'spam' has no attribute 'log'\r\n\r\n======================================================================\r\nERROR: test_find_class (test.test_pickle.PyUnpicklerTests.test_find_class)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/Users/msmith/git/python/cpython/Lib/test/pickletester.py\", line 1265, in test_find_class\r\n    self.assertRaises(ModuleNotFoundError, unpickler.find_class, 'spam', 'log')\r\n    ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n  File \"/Users/msmith/git/python/cpython/Lib/unittest/case.py\", line 804, in assertRaises\r\n    return context.handle('assertRaises', args, kwargs)\r\n           ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n  File \"/Users/msmith/git/python/cpython/Lib/unittest/case.py\", line 238, in handle\r\n    callable_obj(*args, **kwargs)\r\n    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^\r\n  File \"/Users/msmith/git/python/cpython/Lib/pickle.py\", line 1620, in find_class\r\n    return getattr(sys.modules[module], name)\r\nAttributeError: module 'spam' has no attribute 'log'\r\n\r\n----------------------------------------------------------------------\r\nRan 857 tests in 2.954s\r\n\r\nFAILED (errors=2, skipped=31)\r\ntest test_pickle failed\r\n```\r\n\r\nThis can be reproduced by running only test_pkgutil and test_pickle, in that order. test_pkgutil leaves behind a `spam` module in `sys.modules`, while test_pickle assumes there is no such module.\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-123036\n* gh-123781\n* gh-123782\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/encukou","@type":"Person","name":"encukou"},"datePublished":"2024-09-06T13:22:52.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/123780/cpython/issues/123780"}