René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"zipfile.Path regression","articleBody":"# Bug report\n\n### Bug description:\n\n#122906 introduced a regression with directories that look like Windows drive letters (on Linux):\n\n```python\n\u003e\u003e\u003e import io, zipfile\n\u003e\u003e\u003e zf = zipfile.ZipFile(io.BytesIO(), \"w\")\n\u003e\u003e\u003e zf.writestr(\"d:/foo\", \"bar\")\n\u003e\u003e\u003e zf.extractall(\"a\")\n\u003e\u003e\u003e open(\"a/d:/foo\").read()\n'bar'\n\u003e\u003e\u003e p = zipfile.Path(zf)\n\u003e\u003e\u003e x = p / \"d\" / \"foo\"\n\u003e\u003e\u003e y = p / \"d:\" / \"foo\"\n\u003e\u003e\u003e list(p.iterdir())   # before: [Path(None, 'd:/')]\n[Path(None, 'd/')]\n\u003e\u003e\u003e p.root.namelist()   # before: ['d:/foo', 'd:/']\n['d/foo', 'd/']\n\u003e\u003e\u003e x.exists()          # before: False\nTrue\n\u003e\u003e\u003e y.exists()          # before: True\nFalse\n\u003e\u003e\u003e zf.extractall(\"b\")  # before: worked like above\nKeyError: \"There is no item named 'd/foo' in the archive\"\n\u003e\u003e\u003e x.read_text()       # before: FileNotFoundError\nKeyError: \"There is no item named 'd/foo' in the archive\"\n\u003e\u003e\u003e y.read_text()       # before: worked\nFileNotFoundError: ...\n```\n\nThis is the result of `_sanitize()` unconditionally treating a directory that looks like a drive letter as such and removing the colon, regardless of operating system:\n\nhttps://github.com/python/cpython/blob/58fdb169c8a93925541fecc74ba73c566147f2ca/Lib/zipfile/_path/__init__.py#L141\n\nWhereas `_extract_member()` uses `os.path.splitdrive()` (which is a no-op on Linux):\n\nhttps://github.com/python/cpython/blob/58fdb169c8a93925541fecc74ba73c566147f2ca/Lib/zipfile/__init__.py#L1807\n\n### CPython versions tested on:\n\n3.12\n\n### Operating systems tested on:\n\nLinux\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-123354\n* gh-123410\n* gh-123411\n* gh-123425\n* gh-123426\n* gh-123432\n* gh-123433\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/obfusk","@type":"Person","name":"obfusk"},"datePublished":"2024-08-23T19:02:11.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":28},"url":"https://github.com/123270/cpython/issues/123270"}