René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"importlib.resources.files() doesn't work correctly when importlib library is compiled","articleBody":"# Bug report\r\n\r\n### Bug description:\r\n\r\nIf `importlib` library is compiled (in particular `_common.py`), then any package, that uses bare `files()` to get its resources, breaks, because `_infer_caller` returns wrong frame (as mentioned in https://github.com/python/cpython/pull/123037#issuecomment-2294431430, `__file__` in https://github.com/python/cpython/blob/35d8ac7cd7ed6cd3d84af721dce970da59bd5f68/Lib/importlib/resources/_common.py#L96 is not valid)\r\n\r\nReproducer:\r\n```python\r\nimport importlib\r\nimport os\r\nimport pathlib\r\nimport py_compile\r\nimport shutil\r\nimport sys\r\nimport tempfile\r\nimport textwrap\r\n\r\n\r\ndef compile(tempdir):\r\n    target_dir = pathlib.Path(tempdir) / 'cimportlib'\r\n    souce_dir = pathlib.Path(importlib.__file__).parent\r\n    shutil.copytree(souce_dir, target_dir, ignore=lambda *_: ['__pycache__'])\r\n\r\n    for dirpath, _, filenames in os.walk(target_dir):\r\n        for filename in filenames:\r\n            if filename != \"_common.py\":\r\n                continue\r\n            source_path = pathlib.Path(dirpath) / filename\r\n            cfile = source_path.with_suffix('.pyc')\r\n            py_compile.compile(source_path, cfile)\r\n            pathlib.Path.unlink(source_path)\r\n\r\n\r\ndef create_package(tempdir):\r\n    package_dir = pathlib.Path(tempdir) / 'somepkg'\r\n    package_dir.mkdir()\r\n    contents = {\r\n        \"__init__.py\": textwrap.dedent(\r\n            \"\"\"\r\n            import cimportlib.resources as res\r\n            val = res.files().joinpath('resource.txt').read_text(encoding='utf-8')\r\n            \"\"\"\r\n        ),\r\n        \"resource.txt\": \"data\",\r\n    }\r\n\r\n    for file, content in contents.items():\r\n        path = pathlib.Path(package_dir) / file\r\n        path.write_text(content)\r\n\r\n\r\ndef main():\r\n    with tempfile.TemporaryDirectory() as tempdir:\r\n        compile(tempdir)\r\n        create_package(tempdir)\r\n        sys.path.insert(0, str(tempdir))\r\n        print(importlib.import_module('somepkg').val)\r\n\r\n\r\nif __name__ == \"__main__\":\r\n    raise SystemExit(main())\r\n\r\n```\r\nExpectation:\r\n```console\r\ndata\r\n```\r\nActual outcome:\r\n```console\r\nFileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpngnuw441/cimportlib/resources/resource.txt'\r\n```\r\nIt may be important for frozen python applications, as they don't include source code\r\n\r\n### CPython versions tested on:\r\n\r\n3.12, CPython main branch\r\n\r\n### Operating systems tested on:\r\n\r\nLinux, Windows\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-123102\n* gh-124021\n* gh-124024\n* gh-124131\n* gh-128581\n* gh-128600\n* gh-137914\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/Gatsik","@type":"Person","name":"Gatsik"},"datePublished":"2024-08-17T00:24:57.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":6},"url":"https://github.com/123085/cpython/issues/123085"}