René's URL Explorer Experiment


Title: `test_asyncio` `test_to_thread_concurrent` flaky · Issue #122957 · python/cpython · GitHub

Open Graph Title: `test_asyncio` `test_to_thread_concurrent` flaky · Issue #122957 · python/cpython

X Title: `test_asyncio` `test_to_thread_concurrent` flaky · Issue #122957 · python/cpython

Description: The call_count counter on mock.Mock is not atomic, so updates may be lost: cpython/Lib/test/test_asyncio/test_threads.py Lines 32 to 41 in ab094d1 async def test_to_thread_concurrent(self): func = mock.Mock() futs = [] for _ in range(10)...

Open Graph Description: The call_count counter on mock.Mock is not atomic, so updates may be lost: cpython/Lib/test/test_asyncio/test_threads.py Lines 32 to 41 in ab094d1 async def test_to_thread_concurrent(self): func = ...

X Description: The call_count counter on mock.Mock is not atomic, so updates may be lost: cpython/Lib/test/test_asyncio/test_threads.py Lines 32 to 41 in ab094d1 async def test_to_thread_concurrent(self): func = ...

Opengraph URL: https://github.com/python/cpython/issues/122957

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`test_asyncio` `test_to_thread_concurrent` flaky","articleBody":"The `call_count` counter on `mock.Mock` is not atomic, so updates may be lost:\r\n\r\nhttps://github.com/python/cpython/blob/ab094d1b2b348f670743f88e52d1a3f2cab5abd5/Lib/test/test_asyncio/test_threads.py#L32-L41\r\n\r\nThis leads to occasional errors like:\r\n\r\n```\r\nFile \"Lib/test/test_asyncio/test_threads.py\", line 41, in test_to_thread_concurrent\r\nself.assertEqual(func.call_count, 10)\r\n~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^\r\nAssertionError: 9 != 10\r\n```\r\n\r\nI think the update is not actually atomic even with the GIL because of the use of `_delegating_property` in `Mock`, but I'm not entirely sure. The failures are definitely more likely to occur in the free-threaded build.\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-124039\n* gh-124067\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/colesbury","@type":"Person","name":"colesbury"},"datePublished":"2024-08-12T19:22:00.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/122957/cpython/issues/122957"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:873139a0-9f96-3899-214b-d374ed3ea566
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA5DA:B267E:A0983D:DAEC67:6A51E5B2
html-safe-noncea50cb8cf7c0f57b6ff5128159d0811f481e01bf2df644acbc13bcb90b8780adc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNURBOkIyNjdFOkEwOTgzRDpEQUVDNjc6NkE1MUU1QjIiLCJ2aXNpdG9yX2lkIjoiOTExMjE1ODQ1NjEyMzYxNDY0MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb63f5dc97d2d71fe40cfd3ecda888de9c1f0baed31c5d9dfe6227c94028d1fa4
hovercard-subject-tagissue:2461726896
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/122957/issue_layout
twitter:imagehttps://opengraph.githubassets.com/de6f5d89459f0198d7100244e0624b4a679620960e2352004a06ee7abdb77aac/python/cpython/issues/122957
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/de6f5d89459f0198d7100244e0624b4a679620960e2352004a06ee7abdb77aac/python/cpython/issues/122957
og:image:altThe call_count counter on mock.Mock is not atomic, so updates may be lost: cpython/Lib/test/test_asyncio/test_threads.py Lines 32 to 41 in ab094d1 async def test_to_thread_concurrent(self): func = ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecolesbury
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/122957#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F122957
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F122957
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/122957
Reloadhttps://github.com/python/cpython/issues/122957
Reloadhttps://github.com/python/cpython/issues/122957
Please reload this pagehttps://github.com/python/cpython/issues/122957
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/122957
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
#124039https://github.com/python/cpython/pull/124039
test_asyncio test_to_thread_concurrent flakyhttps://github.com/python/cpython/issues/122957#top
#124039https://github.com/python/cpython/pull/124039
testsTests in the Lib/test dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22tests%22
topic-asynciohttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-asyncio%22
topic-free-threadinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-free-threading%22
https://github.com/colesbury
colesburyhttps://github.com/colesbury
on Aug 12, 2024https://github.com/python/cpython/issues/122957#issue-2461726896
cpython/Lib/test/test_asyncio/test_threads.pyhttps://github.com/python/cpython/blob/ab094d1b2b348f670743f88e52d1a3f2cab5abd5/Lib/test/test_asyncio/test_threads.py#L32-L41
ab094d1https://github.com/python/cpython/commit/ab094d1b2b348f670743f88e52d1a3f2cab5abd5
gh-122957: Fix test flakiness in free-thread build #124039https://github.com/python/cpython/pull/124039
[3.13] gh-122957: Fix test flakiness in asyncio test in free-thread build (GH-124039) #124067https://github.com/python/cpython/pull/124067
testsTests in the Lib/test dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22tests%22
topic-asynciohttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-asyncio%22
topic-free-threadinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-free-threading%22
asynciohttps://github.com/orgs/python/projects/29
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.