René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Merge m_atan2() and c_atan2() helper functions (or replace libm's atan2)","articleBody":"# Feature or enhancement\n\n### Proposal:\n\nWith #29179, many workarounds for buggy libm implementations were removed.  Yet, there is ``m_atan2()``:\nhttps://github.com/python/cpython/blob/d0b92dd5ca46a10558857adeb7bb48ecf39fa783/Modules/mathmodule.c#L546-L572\nand\nhttps://github.com/python/cpython/blob/d0b92dd5ca46a10558857adeb7bb48ecf39fa783/Modules/cmathmodule.c#L329-L355\n\nThey are identical, the second one just uses ``Py_complex`` to keep arguments.\n\nWe should either 1) move first helper to ``_math.h`` and reuse it in the ``cmathmodule.c`` or 2) just remove these helpers.  I'll provide patch for 1) proposal.\n\nBut 2) looks also safe for me: it seems that ``c_atan2()`` helper was used only for ``cmath.phase()`` and ``cmath.polar()``; libm's ``atan2()`` used for the rest - and this don't poses any problems in CI or build bots.  (\"Problem\" values *are* tested, e.g. infinities and nans for ``acos()``.)  \n\n### Has this already been discussed elsewhere?\n\nThis is a minor feature, which does not need previous discussion elsewhere\n\n### Links to previous discussion of this feature:\n\n_No response_\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-122682\n* gh-122715\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/skirpichev","@type":"Person","name":"skirpichev"},"datePublished":"2024-08-05T07:50:40.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/122681/cpython/issues/122681"}