Title: inlined comprehension implementation in symtable - missing test or redundant code · Issue #122560 · python/cpython · GitHub
Open Graph Title: inlined comprehension implementation in symtable - missing test or redundant code · Issue #122560 · python/cpython
X Title: inlined comprehension implementation in symtable - missing test or redundant code · Issue #122560 · python/cpython
Description: No test fails if I remove the symtable code that modifies the symtable for an inlined comprehension: #122557 I don't know whether this step is necessary. Would suggest we find a test covering it or remove it. Linked PRs gh-122582
Open Graph Description: No test fails if I remove the symtable code that modifies the symtable for an inlined comprehension: #122557 I don't know whether this step is necessary. Would suggest we find a test covering it or...
X Description: No test fails if I remove the symtable code that modifies the symtable for an inlined comprehension: #122557 I don't know whether this step is necessary. Would suggest we find a test covering i...
Opengraph URL: https://github.com/python/cpython/issues/122560
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"inlined comprehension implementation in symtable - missing test or redundant code","articleBody":"No test fails if I remove the symtable code that modifies the symtable for an inlined comprehension:\r\nhttps://github.com/python/cpython/pull/122557\r\n\r\nI don't know whether this step is necessary. Would suggest we find a test covering it or remove it.\r\n\r\n\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-122582\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/iritkatriel","@type":"Person","name":"iritkatriel"},"datePublished":"2024-08-01T13:00:59.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":10},"url":"https://github.com/122560/cpython/issues/122560"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:32f5faaf-675e-e606-9df0-36bc52ed9b09 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C328:2D943D:5279A1:738F7B:696A0E8E |
| html-safe-nonce | 47a511835825c41336b0f546acec0be2d16956eec09dc6516ba24184af23c974 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzI4OjJEOTQzRDo1Mjc5QTE6NzM4RjdCOjY5NkEwRThFIiwidmlzaXRvcl9pZCI6IjY4NTU3NjU5ODIzNTM5NTIzOTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | bd65fd22720d9b2dd0254b34306fe309d1606e4b1080afc665c8054a0cffc5ce |
| hovercard-subject-tag | issue:2442400043 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/122560/issue_layout |
| twitter:image | https://opengraph.githubassets.com/bcad4e88ceeb598d7fd43c1c49d21dbef2e574cbc75f8f1ecd03dfc3709e687c/python/cpython/issues/122560 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bcad4e88ceeb598d7fd43c1c49d21dbef2e574cbc75f8f1ecd03dfc3709e687c/python/cpython/issues/122560 |
| og:image:alt | No test fails if I remove the symtable code that modifies the symtable for an inlined comprehension: #122557 I don't know whether this step is necessary. Would suggest we find a test covering it or... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | iritkatriel |
| hostname | github.com |
| expected-hostname | github.com |
| None | 699227a00bbb7fe1eec276d2ae1c3a93068bc5ba483bd9dc4b2a27a8f4f2f595 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7266b2d935baa1c6474b16dd9feaa5ca30607261 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width