René's URL Explorer Experiment


Title: Improve performances of `fnmatch.translate` · Issue #122288 · python/cpython · GitHub

Open Graph Title: Improve performances of `fnmatch.translate` · Issue #122288 · python/cpython

X Title: Improve performances of `fnmatch.translate` · Issue #122288 · python/cpython

Description: Feature or enhancement Proposal: I implemented fnmatch.translate and fnmatch.filter in C in #121446 but the performances for fnmatch.filter are less pronounced than those in fnmatch.translate. While I believe that the factor 2x improveme...

Open Graph Description: Feature or enhancement Proposal: I implemented fnmatch.translate and fnmatch.filter in C in #121446 but the performances for fnmatch.filter are less pronounced than those in fnmatch.translate. Whil...

X Description: Feature or enhancement Proposal: I implemented fnmatch.translate and fnmatch.filter in C in #121446 but the performances for fnmatch.filter are less pronounced than those in fnmatch.translate. Whil...

Opengraph URL: https://github.com/python/cpython/issues/122288

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Improve performances of `fnmatch.translate`","articleBody":"# Feature or enhancement\r\n\r\n### Proposal:\r\n\r\nI implemented `fnmatch.translate` and `fnmatch.filter` in C in #121446 but the performances for `fnmatch.filter` are less pronounced than those in `fnmatch.translate`. While I believe that the factor 2x improvement brought by the C implementation is worthwhile for `fnmatch.translate`, this comes at a high maintenance cost. Instead, I translated (no pun intended) the implementation in Python and obtained the following timings (PGO build):\r\n\r\n```\r\n+------------------------------------------+-----------------------+-----------------------+\r\n| Benchmark                                | fnmatch-translate-ref | fnmatch-translate-py  |\r\n+==========================================+=======================+=======================+\r\n| abc/[!]b-ac-z9-1]/def/\\*?/*/**c/?*[][!]  | 6.09 us               | 3.99 us: 1.53x faster |\r\n+------------------------------------------+-----------------------+-----------------------+\r\n| !abc/[!]b-ac-z9-1]/def/\\*?/*/**c/?*[][!] | 6.39 us               | 4.07 us: 1.57x faster |\r\n+------------------------------------------+-----------------------+-----------------------+\r\n| a**?**cd**?**??k***                      | 2.24 us               | 1.51 us: 1.49x faster |\r\n+------------------------------------------+-----------------------+-----------------------+\r\n| a/**/b/**/c                              | 1.97 us               | 1.12 us: 1.76x faster |\r\n+------------------------------------------+-----------------------+-----------------------+\r\n| man/man1/bash.1                          | 3.00 us               | 1.21 us: 2.48x faster |\r\n+------------------------------------------+-----------------------+-----------------------+\r\n| a*b*c*d*e*f*g*h*i*j*k*l*m*n*o**          | 5.40 us               | 3.33 us: 1.62x faster |\r\n+------------------------------------------+-----------------------+-----------------------+\r\n| Geometric mean                           | (ref)                 | 1.71x faster          |\r\n+------------------------------------------+-----------------------+-----------------------+\r\n``` \r\n\r\nIt's not as good as the benchmarks reported in https://github.com/python/cpython/issues/121445, but I think this could be considered. Note that the improvements are brought by a new (but equivalent) algorithm during the translation phase. Currently, the translation algorithm does:\r\n\r\n- Do not compress consecutive '*' into 1 within the same loop iteration.\r\n- Use a sentinel to indicate a wildcard instead.\r\n- Add to a list `re.escape(c)` for every non-special character (i.e, not for groups beginning by `?*[`).\r\n- In a second phase, merge the groups delimited by the sentinels in order to produce the final regex.\r\n\r\nOur (Barney and me) implementation instead does the following:\r\n\r\n- Cache `re.escape` so that the lookup is faster.\r\n- Remember the positions of '*' in the above split instead of using a sentinel object.\r\n  That way, I can easily merge parts during the second phase (technically, it'd be possible to do it in one phase but two passes makes it clearer).\r\n\r\n### Has this already been discussed elsewhere?\r\n\r\nNo response given\r\n\r\n### Links to previous discussion of this feature:\r\n\r\n_No response_\r\n\r\n\u003c!-- gh-linked-prs -->\r\n### Linked PRs\r\n* gh-122289\r\n\u003c!-- /gh-linked-prs -->\r\n","author":{"url":"https://github.com/picnixz","@type":"Person","name":"picnixz"},"datePublished":"2024-07-25T16:05:21Z","url":"https://github.com/python/cpython/issues/122288"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:b7c7afc6-e918-fd08-5fb3-c8bc02f8b3b6
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8474:136CDA:179688D:1F384F3:6B020AE1
html-safe-noncef8ccedeea4ac9f97807a228ffed310307a9dde889357d9a56aecba40f793bc7e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDc0OjEzNkNEQToxNzk2ODhEOjFGMzg0RjM6NkIwMjBBRTEiLCJ2aXNpdG9yX2lkIjoiMTU1NzE1OTE1OTY3MjIxMjE5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbaab11038ee5ead7d49b63e1246b50f10bb463d5db4c4ab6bbcc703a5fa94d2c
hovercard-subject-tagissue:2430427162
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/122288/issue_layout
twitter:imagehttps://opengraph.githubassets.com/198561ec12e0206b3a84be26e13dd52d6eaf7c3df9bac8ef43a91efe6aecca20/python/cpython/issues/122288
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/198561ec12e0206b3a84be26e13dd52d6eaf7c3df9bac8ef43a91efe6aecca20/python/cpython/issues/122288
og:image:altFeature or enhancement Proposal: I implemented fnmatch.translate and fnmatch.filter in C in #121446 but the performances for fnmatch.filter are less pronounced than those in fnmatch.translate. Whil...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepicnixz
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/122288#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F122288
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F122288
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/122288
Reloadhttps://github.com/python/cpython/issues/122288
Reloadhttps://github.com/python/cpython/issues/122288
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/122288
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/122288
Improve performances of fnmatch.translatehttps://github.com/python/cpython/issues/122288#top
performancePerformance or resource usagehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22performance%22
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
https://github.com/picnixz
picnixzhttps://github.com/picnixz
on Jul 25, 2024https://github.com/python/cpython/issues/122288#issue-2430427162
#121446https://github.com/python/cpython/pull/121446
#121445https://github.com/python/cpython/issues/121445
gh-122288: Improve performances of fnmatch.translate #122289https://github.com/python/cpython/pull/122289
picnixzhttps://github.com/picnixz
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
performancePerformance or resource usagehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22performance%22
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
on Jul 25, 2024https://github.com/python/cpython/issues/122288#event-13649221637
https://github.com/barneygale
barneygalehttps://github.com/barneygale
on Aug 14, 2024https://github.com/python/cpython/issues/122288#issuecomment-2289606279
https://github.com/picnixz
picnixzhttps://github.com/picnixz
on Aug 15, 2024https://github.com/python/cpython/issues/122288#issuecomment-2290898969
https://github.com/barneygale
barneygalehttps://github.com/barneygale
on Aug 16, 2024https://github.com/python/cpython/issues/122288#issuecomment-2293949764
https://github.com/picnixz
picnixzhttps://github.com/picnixz
on Aug 17, 2024https://github.com/python/cpython/issues/122288#issuecomment-2294789587
https://github.com/picnixz
picnixzhttps://github.com/picnixz
on Aug 17, 2024https://github.com/python/cpython/issues/122288#issuecomment-2294821516
https://github.com/picnixz
picnixzhttps://github.com/picnixz
on Aug 17, 2024https://github.com/python/cpython/issues/122288#issuecomment-2294824712
barneygalehttps://github.com/barneygale
on Nov 27, 2024https://github.com/python/cpython/issues/122288#event-15455331293
gh-122288: Improve performances of `fnmatch.translate` (#122289)https://github.com/python/cpython/commit/78cb377c622a98b1bf58df40c828e886575a6927
gh-122288https://github.com/python/cpython/issues/122288
#122289https://github.com/python/cpython/pull/122289
78cb377https://github.com/python/cpython/commit/78cb377c622a98b1bf58df40c828e886575a6927
https://github.com/picnixz
picnixzhttps://github.com/picnixz
on Nov 27, 2024https://github.com/python/cpython/issues/122288#issuecomment-2504343193
picnixzhttps://github.com/picnixz
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Nov 27, 2024https://github.com/python/cpython/issues/122288#event-15455382710
ebonnalhttps://github.com/ebonnal
on Jan 12, 2025https://github.com/python/cpython/issues/122288#event-15894562648
pythongh-122288: Improve performances of `fnmatch.translate` (python#…https://github.com/ebonnal/cpython/commit/8390b7735c72094ec79008742fe1c782f30df2b4
pythongh-122288https://github.com/python/cpython/issues/122288
python#…https://github.com/python/cpython/pull/122289
8390b77https://github.com/ebonnal/cpython/commit/8390b7735c72094ec79008742fe1c782f30df2b4
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/122288
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/122288
performancePerformance or resource usagehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22performance%22
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.