René's URL Explorer Experiment


Title: `hashlib.file_digest()` can't handle non-blocking I/O · Issue #122179 · python/cpython · GitHub

Open Graph Title: `hashlib.file_digest()` can't handle non-blocking I/O · Issue #122179 · python/cpython

X Title: `hashlib.file_digest()` can't handle non-blocking I/O · Issue #122179 · python/cpython

Description: Bug report Bug description: This came up in python/typeshed#12414. The current implementation of file_digest() does not check the return value of fileobj.readinto() for None: cpython/Lib/hashlib.py Lines 232 to 236 in 2a5d1eb while True:...

Open Graph Description: Bug report Bug description: This came up in python/typeshed#12414. The current implementation of file_digest() does not check the return value of fileobj.readinto() for None: cpython/Lib/hashlib.py...

X Description: Bug report Bug description: This came up in python/typeshed#12414. The current implementation of file_digest() does not check the return value of fileobj.readinto() for None: cpython/Lib/hashlib.py...

Opengraph URL: https://github.com/python/cpython/issues/122179

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`hashlib.file_digest()` can't handle non-blocking I/O","articleBody":"# Bug report\n\n### Bug description:\n\nThis came up in python/typeshed#12414.\n\nThe current implementation of `file_digest()` does not check the return value of `fileobj.readinto()` for `None`:\n\nhttps://github.com/python/cpython/blob/2a5d1eb7073179a13159bce937afdbe240432e7d/Lib/hashlib.py#L232-L236\n\nWhile buffered file objects can't return `None`, unbuffered ones can when they are doing non-blocking I/O. Specifically, `file_digest()` [is documented](https://docs.python.org/3/library/hashlib.html#hashlib.file_digest) to take `SocketIO` objects, which can very much return `None`:\n\nhttps://github.com/python/cpython/blob/2a5d1eb7073179a13159bce937afdbe240432e7d/Lib/socket.py#L694-L714\n\n### CPython versions tested on:\n\nCPython main branch\n\n### Operating systems tested on:\n\nOther\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-122183\n* gh-132787\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/srittau","@type":"Person","name":"srittau"},"datePublished":"2024-07-23T14:28:35Z","url":"https://github.com/python/cpython/issues/122179"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:fa81046f-b37a-7332-c742-9ec7a09eee2b
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC318:1CEB9:77619:A5E20:6B004F0B
html-safe-noncef30746e4edbd2226adeb895a4a0cc1f28a86b33e539d5d7f151a718b9a4b9dfb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzE4OjFDRUI5Ojc3NjE5OkE1RTIwOjZCMDA0RjBCIiwidmlzaXRvcl9pZCI6Ijg3NjE0Nzk0NTMwNjc5ODg3NDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacbba6d86b72b5f45d444bba8c9d16aca4461a85fd05f0f558e7eb027456364760
hovercard-subject-tagissue:2425364066
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/122179/issue_layout
twitter:imagehttps://opengraph.githubassets.com/32e6b72be30e7b6e31c020ac15bc76da687008d6abd7c463662e6380db3c446c/python/cpython/issues/122179
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/32e6b72be30e7b6e31c020ac15bc76da687008d6abd7c463662e6380db3c446c/python/cpython/issues/122179
og:image:altBug report Bug description: This came up in python/typeshed#12414. The current implementation of file_digest() does not check the return value of fileobj.readinto() for None: cpython/Lib/hashlib.py...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesrittau
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/122179#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F122179
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F122179
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/122179
Reloadhttps://github.com/python/cpython/issues/122179
Reloadhttps://github.com/python/cpython/issues/122179
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/122179
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/122179
hashlib.file_digest() can't handle non-blocking I/Ohttps://github.com/python/cpython/issues/122179#top
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/srittau
srittauhttps://github.com/srittau
on Jul 23, 2024https://github.com/python/cpython/issues/122179#issue-2425364066
python/typeshed#12414https://github.com/python/typeshed/issues/12414
cpython/Lib/hashlib.pyhttps://github.com/python/cpython/blob/2a5d1eb7073179a13159bce937afdbe240432e7d/Lib/hashlib.py#L232-L236
2a5d1ebhttps://github.com/python/cpython/commit/2a5d1eb7073179a13159bce937afdbe240432e7d
is documentedhttps://docs.python.org/3/library/hashlib.html#hashlib.file_digest
cpython/Lib/socket.pyhttps://github.com/python/cpython/blob/2a5d1eb7073179a13159bce937afdbe240432e7d/Lib/socket.py#L694-L714
2a5d1ebhttps://github.com/python/cpython/commit/2a5d1eb7073179a13159bce937afdbe240432e7d
gh-122179: Fix hashlib.file_digest and non-blocking I/O #122183https://github.com/python/cpython/pull/122183
[3.13] gh-122179: Fix hashlib.file_digest and non-blocking I/O #132787https://github.com/python/cpython/pull/132787
srittauhttps://github.com/srittau
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
on Jul 23, 2024https://github.com/python/cpython/issues/122179#event-13616826810
https://github.com/srittau
srittauhttps://github.com/srittau
on Jul 23, 2024https://github.com/python/cpython/issues/122179#issuecomment-2245424153
https://github.com/graingert
graingerthttps://github.com/graingert
on Jul 23, 2024https://github.com/python/cpython/issues/122179#issuecomment-2245451966
https://github.com/graingert
graingerthttps://github.com/graingert
on Jul 23, 2024https://github.com/python/cpython/issues/122179#issuecomment-2245473585
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
on Jul 31, 2024https://github.com/python/cpython/issues/122179#issuecomment-2260900776
https://github.com/srittau
srittauhttps://github.com/srittau
on Jul 31, 2024https://github.com/python/cpython/issues/122179#issuecomment-2260938068
https://github.com/graingert
graingerthttps://github.com/graingert
on Jul 31, 2024https://github.com/python/cpython/issues/122179#issuecomment-2261107227
#54063https://github.com/python/cpython/issues/54063
gpsheadhttps://github.com/gpshead
on Apr 21, 2025https://github.com/python/cpython/issues/122179#event-17343620022
gh-122179: Fix hashlib.file_digest and non-blocking I/O (GH-122183)https://github.com/python/cpython/commit/2b47f46d7dc30d27b2486991fea4acd83553294b
gh-122179https://github.com/python/cpython/issues/122179
GH-122183https://github.com/python/cpython/pull/122183
2b47f46https://github.com/python/cpython/commit/2b47f46d7dc30d27b2486991fea4acd83553294b
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
on Apr 21, 2025https://github.com/python/cpython/issues/122179#issuecomment-2819552666
gpsheadhttps://github.com/gpshead
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Apr 21, 2025https://github.com/python/cpython/issues/122179#event-17343803413
gpsheadhttps://github.com/gpshead
on Apr 21, 2025https://github.com/python/cpython/issues/122179#event-17343979168
[3.13] gh-122179: Fix hashlib.file_digest and non-blocking I/O (GH-13…https://github.com/python/cpython/commit/cdabbc126fb16420903166ad788d39e01230c966
gh-122179https://github.com/python/cpython/issues/122179
GH-13…https://github.com/python/cpython/pull/132787
cdabbc1https://github.com/python/cpython/commit/cdabbc126fb16420903166ad788d39e01230c966
picnixzhttps://github.com/picnixz
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
on Oct 2, 2025https://github.com/python/cpython/issues/122179#event-20057290598
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/122179
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/122179
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.