René's URL Explorer Experiment


Title: enumerate's are slow · Issue #121380 · python/cpython · GitHub

Open Graph Title: enumerate's are slow · Issue #121380 · python/cpython

X Title: enumerate's are slow · Issue #121380 · python/cpython

Description: Performance Improvement Using enumerate(...) in for loops are slow and there are at least +250 enumerate's in CPython Let's take for example this for loop with enumerate: cpython/Lib/genericpath.py Lines 116 to 118 in 5f660e8 for i, c in...

Open Graph Description: Performance Improvement Using enumerate(...) in for loops are slow and there are at least +250 enumerate's in CPython Let's take for example this for loop with enumerate: cpython/Lib/genericpath.py...

X Description: Performance Improvement Using enumerate(...) in for loops are slow and there are at least +250 enumerate's in CPython Let's take for example this for loop with enumerate: cpython/Lib/generi...

Opengraph URL: https://github.com/python/cpython/issues/121380

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"enumerate's are slow","articleBody":"# Performance Improvement\r\n\r\nUsing `enumerate(...)` in `for` loops are slow and there are at least +250 `enumerate`'s in CPython\r\n\r\nLet's take for example this `for` loop with `enumerate`:\r\n\r\nhttps://github.com/python/cpython/blob/5f660e8e2ca3acfb89ccbdd990f072149b6baa6a/Lib/genericpath.py#L116-L118\r\n\r\nIf you remove  `enumerate`, this method will run 5% to 7% faster:\r\n\r\n```python\r\n    i = 0\r\n    for c in s1:\r\n        if c != s2[i]:\r\n            return s1[:i]\r\n        i += 1\r\n```\r\n\r\n Complete performance test script, basically I copied twice the original `commonprefix(m)` and then I modified the last one:\r\n\r\n```python\r\nimport os\r\nimport time\r\n\r\n# From file CPython/Lib/genericpath.py\r\n\r\n# Return the longest prefix of all list elements.\r\ndef old_commonprefix(m):\r\n    \"Given a list of pathnames, returns the longest common leading component\"\r\n    if not m: return ''\r\n    # Some people pass in a list of pathname parts to operate in an OS-agnostic\r\n    # fashion; don't try to translate in that case as that's an abuse of the\r\n    # API and they are already doing what they need to be OS-agnostic and so\r\n    # they most likely won't be using an os.PathLike object in the sublists.\r\n    if not isinstance(m[0], (list, tuple)):\r\n        m = tuple(map(os.fspath, m))\r\n    s1 = min(m)\r\n    s2 = max(m)\r\n    for i, c in enumerate(s1):\r\n        if c != s2[i]:\r\n            return s1[:i]\r\n    return s1\r\n\r\n# Return the longest prefix of all list elements.\r\ndef commonprefix(m):\r\n    \"Given a list of pathnames, returns the longest common leading component\"\r\n    if not m: return ''\r\n    # Some people pass in a list of pathname parts to operate in an OS-agnostic\r\n    # fashion; don't try to translate in that case as that's an abuse of the\r\n    # API and they are already doing what they need to be OS-agnostic and so\r\n    # they most likely won't be using an os.PathLike object in the sublists.\r\n    if not isinstance(m[0], (list, tuple)):\r\n        m = tuple(map(os.fspath, m))\r\n    s1 = min(m)\r\n    s2 = max(m)\r\n    i = 0\r\n    for c in s1:\r\n        if c != s2[i]:\r\n            return s1[:i]\r\n        i += 1\r\n    return s1\r\n\r\ndef perfomance(func):\r\n    start = time.time()\r\n    for _ in range(1000000):\r\n        func([\"/usr/lib\", \"/usr/local/lib\", \"/usr/local/bin\", \"/usr/bin\", \"/usr/local/share\"])\r\n    end = time.time()\r\n    return end - start\r\n\r\nold_perfomance = perfomance(old_commonprefix)\r\nnew_perfomance = perfomance(commonprefix)\r\nperc = (old_perfomance / new_perfomance) * 100\r\n\r\nprint(f\"with enumerate: {old_perfomance} secs\")\r\nprint(f\"without enumerate: {new_perfomance} secs\")\r\nprint(f\"New version is {perc:.2f}% faster\")\r\n```\r\n\r\nYou will get this performance improvement:\r\n\r\n```\r\nwith enumerate: 0.8863015174865723 secs\r\nwithout enumerate: 0.8414063453674316 secs\r\nNew version is 105.34% faster\r\n```\r\n\r\nRunning this commands, you can count and find all `for` loops with `enumerate` in `/Lib` for example\r\n```bash\r\n$ grep -r \"in enumerate\" ./Lib | wc -l\r\n$ grep -rl \"in enumerate\" ./Lib\r\n```\r\n\r\nIf this is useful for CPython, I can create specific issues+PR replacing `enumerate(...)`'s.\r\n\r\n### Has this already been discussed elsewhere?\r\n\r\nNo response given\r\n\r\n### Links to previous discussion of this feature:\r\n\r\n_No response_","author":{"url":"https://github.com/LimaBD","@type":"Person","name":"LimaBD"},"datePublished":"2024-07-04T20:53:20Z","url":"https://github.com/python/cpython/issues/121380"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:8bec6bff-18d1-c56a-3d9a-9ea4f0d96f70
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDC66:16E4ED:1325689:17F4481:6B024A59
html-safe-nonce50af181663b23a37273952af3c950405b4b5c8a9b046daa23b4b45d254700585
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzY2OjE2RTRFRDoxMzI1Njg5OjE3RjQ0ODE6NkIwMjRBNTkiLCJ2aXNpdG9yX2lkIjoiNDkyMDM5NjU2NTY3MzI5ODUyMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd836650f0f32401cf4d37db1c76b6dac2158be487866f9122614de36a23f8887
hovercard-subject-tagissue:2391454115
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/121380/issue_layout
twitter:imagehttps://opengraph.githubassets.com/66058d131f04f2e4ec928c1e496123508813cd41db94f8646ccffa359265ae10/python/cpython/issues/121380
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/66058d131f04f2e4ec928c1e496123508813cd41db94f8646ccffa359265ae10/python/cpython/issues/121380
og:image:altPerformance Improvement Using enumerate(...) in for loops are slow and there are at least +250 enumerate's in CPython Let's take for example this for loop with enumerate: cpython/Lib/genericpath.py...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameLimaBD
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/121380#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F121380
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F121380
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/121380
Reloadhttps://github.com/python/cpython/issues/121380
Reloadhttps://github.com/python/cpython/issues/121380
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/121380
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/121380
enumerate's are slowhttps://github.com/python/cpython/issues/121380#top
performancePerformance or resource usagehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22performance%22
https://github.com/LimaBD
LimaBDhttps://github.com/LimaBD
on Jul 4, 2024https://github.com/python/cpython/issues/121380#issue-2391454115
cpython/Lib/genericpath.pyhttps://github.com/python/cpython/blob/5f660e8e2ca3acfb89ccbdd990f072149b6baa6a/Lib/genericpath.py#L116-L118
5f660e8https://github.com/python/cpython/commit/5f660e8e2ca3acfb89ccbdd990f072149b6baa6a
LimaBDhttps://github.com/LimaBD
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
on Jul 4, 2024https://github.com/python/cpython/issues/121380#event-13398530825
https://github.com/nineteendo
nineteendohttps://github.com/nineteendo
on Jul 4, 2024https://github.com/python/cpython/issues/121380#issuecomment-2209571472
https://github.com/faster-cpython/ideashttps://github.com/faster-cpython/ideas
https://github.com/gaogaotiantian
gaogaotiantianhttps://github.com/gaogaotiantian
on Jul 4, 2024https://github.com/python/cpython/issues/121380#issuecomment-2209589929
rhettingerhttps://github.com/rhettinger
performancePerformance or resource usagehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22performance%22
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
on Jul 5, 2024https://github.com/python/cpython/issues/121380#event-13407074220
https://github.com/rhettinger
rhettingerhttps://github.com/rhettinger
on Jul 5, 2024https://github.com/python/cpython/issues/121380#issuecomment-2211021638
rhettingerhttps://github.com/rhettinger
not plannedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Anot-planned
on Jul 5, 2024https://github.com/python/cpython/issues/121380#event-13407128762
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/121380
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/121380
performancePerformance or resource usagehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22performance%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.