René's URL Explorer Experiment


Title: MSVC pragma to turn compiler optimization off around the _PyEval_EvalFrameDefault is no longer necessary · Issue #121338 · python/cpython · GitHub

Open Graph Title: MSVC pragma to turn compiler optimization off around the _PyEval_EvalFrameDefault is no longer necessary · Issue #121338 · python/cpython

X Title: MSVC pragma to turn compiler optimization off around the _PyEval_EvalFrameDefault is no longer necessary · Issue #121338 · python/cpython

Description: Bug report Bug description: When the Tier 2 interpreter loop was first merged with the Tier 1 interpreter loop, the MSVC compiler would crash when building for PGO, presumably due to the very large size of the function. #111786 introduce...

Open Graph Description: Bug report Bug description: When the Tier 2 interpreter loop was first merged with the Tier 1 interpreter loop, the MSVC compiler would crash when building for PGO, presumably due to the very large...

X Description: Bug report Bug description: When the Tier 2 interpreter loop was first merged with the Tier 1 interpreter loop, the MSVC compiler would crash when building for PGO, presumably due to the very large...

Opengraph URL: https://github.com/python/cpython/issues/121338

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"MSVC pragma to turn compiler optimization off around the _PyEval_EvalFrameDefault is no longer necessary","articleBody":"# Bug report\n\n### Bug description:\n\nWhen the Tier 2 interpreter loop was first merged with the Tier 1 interpreter loop, the MSVC compiler would crash when building for PGO, presumably due to the very large size of the function.  #111786 introduced a `#pragma optimize(\"off\")` to turn off optimization around `_PyEval_EvalFrameDefault` which seems to have side-stepped the crash.\n\n[This crash was reported to the MSVC compiler team](https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1914472), but there hasn't been resolution around that.\n\nIn the intervening time, the interpreter loop has changed significantly again, and it seems that this `#pragma` hack is no longer necessary, either for default builds (which no longer include a Tier 2 interpreter) and `--enable-experimental-jit` builds (which do).  I propose we remove it for the sake of removing what should have been a temporary hack and to give the compiler the fairest shot at doing its best work.  Benchmarking shows no significant change for either a [default build](https://github.com/faster-cpython/benchmarking-public/tree/main/results/bm-20240702-3.14.0a0-a03affd) or a [JIT build](https://github.com/faster-cpython/benchmarking-public/tree/main/results/bm-20240702-3.14.0a0-a03affd-JIT).\n\nI'm not sure whether this should also be backported to 3.13.  It's not really a bugfix, but I would certainly feel better shipping 3.13.0 without a weird compiler workaround (which would be harder to remove after the rc).\n\n### CPython versions tested on:\n\nCPython main branch\n\n### Operating systems tested on:\n\nWindows\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-121340\n* gh-121492\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/mdboom","@type":"Person","name":"mdboom"},"datePublished":"2024-07-03T15:15:50Z","url":"https://github.com/python/cpython/issues/121338"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:15e1c991-d169-989d-2abb-57c29f78d3be
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA892:E0ADF:1CBED78:243002E:6B023AA1
html-safe-nonce5dfd233f9936f06bb8ea4759a6d4536a59bcd4b14fc8096a70f3eac5916bf350
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODkyOkUwQURGOjFDQkVENzg6MjQzMDAyRTo2QjAyM0FBMSIsInZpc2l0b3JfaWQiOiI0MTc2OTgwNzMyMjQzMjI5MzQ1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2d7b2774684ae822bcf7d7c327cb0c812aaff83bf615103abd9598067be7e63d
hovercard-subject-tagissue:2388894933
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/121338/issue_layout
twitter:imagehttps://opengraph.githubassets.com/14a00d6d6338ac3f6c6b35267f3d79e10dfb0d6ba53f51e4faa449c09d359f73/python/cpython/issues/121338
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/14a00d6d6338ac3f6c6b35267f3d79e10dfb0d6ba53f51e4faa449c09d359f73/python/cpython/issues/121338
og:image:altBug report Bug description: When the Tier 2 interpreter loop was first merged with the Tier 1 interpreter loop, the MSVC compiler would crash when building for PGO, presumably due to the very large...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemdboom
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/121338#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F121338
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F121338
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/121338
Reloadhttps://github.com/python/cpython/issues/121338
Reloadhttps://github.com/python/cpython/issues/121338
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/121338
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/121338
MSVC pragma to turn compiler optimization off around the _PyEval_EvalFrameDefault is no longer necessaryhttps://github.com/python/cpython/issues/121338#top
OS-windowshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22OS-windows%22
performancePerformance or resource usagehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22performance%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/mdboom
mdboomhttps://github.com/mdboom
on Jul 3, 2024https://github.com/python/cpython/issues/121338#issue-2388894933
#111786https://github.com/python/cpython/issues/111786
This crash was reported to the MSVC compiler teamhttps://dev.azure.com/devdiv/DevDiv/_workitems/edit/1914472
default buildhttps://github.com/faster-cpython/benchmarking-public/tree/main/results/bm-20240702-3.14.0a0-a03affd
JIT buildhttps://github.com/faster-cpython/benchmarking-public/tree/main/results/bm-20240702-3.14.0a0-a03affd-JIT
gh-121338: Remove #pragma optimize #121340https://github.com/python/cpython/pull/121340
[3.13] gh-121338: Remove GH-pragma optimize (GH-121340) #121492https://github.com/python/cpython/pull/121492
mdboomhttps://github.com/mdboom
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
performancePerformance or resource usagehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22performance%22
OS-windowshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22OS-windows%22
on Jul 3, 2024https://github.com/python/cpython/issues/121338#event-13382447807
mdboomhttps://github.com/mdboom
on Jul 3, 2024https://github.com/python/cpython/issues/121338#event-13383439833
pythongh-121338: Remove #pragma optimizehttps://github.com/mdboom/cpython/commit/a9dbaf421c112b707136af0b7c1537cc62932288
pythongh-121338https://github.com/python/cpython/issues/121338
a9dbaf4https://github.com/mdboom/cpython/commit/a9dbaf421c112b707136af0b7c1537cc62932288
https://github.com/zooba
zoobahttps://github.com/zooba
on Jul 3, 2024https://github.com/python/cpython/issues/121338#issuecomment-2206954884
mdboomhttps://github.com/mdboom
on Jul 8, 2024https://github.com/python/cpython/issues/121338#event-13423426810
gh-121338: Remove #pragma optimize (#121340)https://github.com/python/cpython/commit/d69529d31ccd1510843cfac1ab53bb8cb027541f
gh-121338https://github.com/python/cpython/issues/121338
#121340https://github.com/python/cpython/pull/121340
d69529dhttps://github.com/python/cpython/commit/d69529d31ccd1510843cfac1ab53bb8cb027541f
miss-islingtonhttps://github.com/miss-islington
on Jul 8, 2024https://github.com/python/cpython/issues/121338#event-13423429696
pythongh-121338: Remove GH-pragma optimize (pythonGH-121340)https://github.com/miss-islington/cpython/commit/9ae9659122a0a378c24983101809b2e5cf2b8453
pythongh-121338https://github.com/python/cpython/issues/121338
pythonGH-121340https://github.com/python/cpython/pull/121340
9ae9659https://github.com/miss-islington/cpython/commit/9ae9659122a0a378c24983101809b2e5cf2b8453
mdboomhttps://github.com/mdboom
on Jul 8, 2024https://github.com/python/cpython/issues/121338#event-13423933269
[3.13] gh-121338: Remove GH-pragma optimize (GH-121340) (#121492)https://github.com/python/cpython/commit/0790418a0406cc5419bfd9d718522a749542bbc8
gh-121338https://github.com/python/cpython/issues/121338
GH-121340https://github.com/python/cpython/pull/121340
#121492https://github.com/python/cpython/pull/121492
0790418https://github.com/python/cpython/commit/0790418a0406cc5419bfd9d718522a749542bbc8
estyxxhttps://github.com/estyxx
on Jul 17, 2024https://github.com/python/cpython/issues/121338#event-13533270362
pythongh-121338: Remove #pragma optimize (python#121340)https://github.com/estyxx/cpython/commit/52e5ad27609dfced0461cfdbbf77c61851b96857
pythongh-121338https://github.com/python/cpython/issues/121338
python#121340https://github.com/python/cpython/pull/121340
52e5ad2https://github.com/estyxx/cpython/commit/52e5ad27609dfced0461cfdbbf77c61851b96857
https://github.com/hugovk
hugovkhttps://github.com/hugovk
on Aug 8, 2024https://github.com/python/cpython/issues/121338#issuecomment-2276146662
hugovkhttps://github.com/hugovk
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Aug 8, 2024https://github.com/python/cpython/issues/121338#event-13809061195
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/121338
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/121338
OS-windowshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22OS-windows%22
performancePerformance or resource usagehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22performance%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.