René's URL Explorer Experiment


Title: email: invalid RFC 2047 address header after refolding with email.policy.default · Issue #121284 · python/cpython · GitHub

Open Graph Title: email: invalid RFC 2047 address header after refolding with email.policy.default · Issue #121284 · python/cpython

X Title: email: invalid RFC 2047 address header after refolding with email.policy.default · Issue #121284 · python/cpython

Description: Bug report Bug description: If an email message (modern or legacy) is assigned an address header that is pre-encoded with RFC 2047, calling as_bytes(policy=default) can generate an invalid address header. The resulting header may include...

Open Graph Description: Bug report Bug description: If an email message (modern or legacy) is assigned an address header that is pre-encoded with RFC 2047, calling as_bytes(policy=default) can generate an invalid address ...

X Description: Bug report Bug description: If an email message (modern or legacy) is assigned an address header that is pre-encoded with RFC 2047, calling as_bytes(policy=default) can generate an invalid address ...

Opengraph URL: https://github.com/python/cpython/issues/121284

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"email: invalid RFC 2047 address header after refolding with email.policy.default ","articleBody":"# Bug report\n\n### Bug description:\n\nIf an email message (modern or legacy) is assigned an address header that is pre-encoded with RFC 2047, calling as_bytes(policy=default) can generate an invalid address header. The resulting header may include unquoted RFC 5322 special characters in a way that can alter its meaning.\n\nHere is a minimal example to demonstrate the problem, isolated from much larger code (including Django's django.core.mail.message). Although this example starts with a legacy Message, an example using only the modern email API [is in a later comment](#issuecomment-2207348299):\n\n```python\nimport email.message\nimport email.policy\n\nmessage = email.message.Message()\nmessage[\"To\"] = '=?utf-8?b?TmfGsOG7nWkgbmjhuq1uIGEgdmVyeSB2ZXJ5IGxvbmcs?= name \u003cto@example.com>'\n\nmessage.as_bytes(policy=email.policy.default)\n# b'To: =?utf-8?b?TmfGsOG7nWkgbmjhuq1u?= a very very long, name \u003cto@example.com>\\n\\n'\n```\n\n(The unquoted comma in the resulting display-name is not valid.)\n\nFor a real-world case where this can occur, see [Django ticket 35378](https://code.djangoproject.com/ticket/35378) and anymail/django-anymail#369. (Thanks to @andresmrm for noticing the problem and isolating a test case.)\n\nOddly, as_string(policy=default) doesn't exhibit the problem:\n```python\nmessage.as_string(policy=email.policy.default)\n# 'To: =?utf-8?b?TmfGsOG7nWkgbmjhuq1uIGEgdmVyeSB2ZXJ5IGxvbmcs?= name \u003cto@example.com>\\n\\n'\n```\n\nAlso, the problem does not occur when assigning the non-encoded equivalent to the header:\n```python\nmessage2 = email.message.Message()\nmessage2[\"To\"] = '\"Người nhận a very very long, name\" \u003cto@example.com>'\nmessage2.as_bytes(policy=email.policy.default)\n# b'To:\\n =?utf-8?b?TmfGsOG7nWkgbmjhuq1uIGEgdmVyeSB2ZXJ5IGxvbmcs?= name \u003cto@example.com>\\n\\n'\n```\n\n(Possibly related to #80222)\n\n\n### CPython versions tested on:\n\n3.9, 3.12\n\n### Operating systems tested on:\n\nmacOS\n\n[edits: removed ambiguous use of \"default\" in example comment; clarified this is not a real-world example, but a minimal test case]\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-122754\n* gh-131403\n* gh-131404\n* gh-131405\n* gh-131411\n* gh-131412\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/medmunds","@type":"Person","name":"medmunds"},"datePublished":"2024-07-02T18:05:12Z","url":"https://github.com/python/cpython/issues/121284"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:6e0d75b3-ad1f-c9b6-78d9-1f4183f7d272
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA202:18B602:876F5:BE845:6B0051A7
html-safe-nonce46cf530b7ca47e18db5026724ff6c23299b5d4805fceadce7eec4f60cf9f90e1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjAyOjE4QjYwMjo4NzZGNTpCRTg0NTo2QjAwNTFBNyIsInZpc2l0b3JfaWQiOiI4NzY2NDc3OTQ0NTk3MDA4ODA3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac067d12e37aaeaa1b7c2a471a8e90e57b39a50f874a93b11101095047bf98b1bd
hovercard-subject-tagissue:2386852702
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/121284/issue_layout
twitter:imagehttps://opengraph.githubassets.com/80b6a4101f9a3c4ba3b1f9e94f31e9906731dd00fa179d16619915103c7981ed/python/cpython/issues/121284
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/80b6a4101f9a3c4ba3b1f9e94f31e9906731dd00fa179d16619915103c7981ed/python/cpython/issues/121284
og:image:altBug report Bug description: If an email message (modern or legacy) is assigned an address header that is pre-encoded with RFC 2047, calling as_bytes(policy=default) can generate an invalid address ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemedmunds
hostnamegithub.com
expected-hostnamegithub.com
Nonef420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26e00df917aba0f128135dc073ea0c5e33a70d40
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/121284#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F121284
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F121284
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/121284
Reloadhttps://github.com/python/cpython/issues/121284
Reloadhttps://github.com/python/cpython/issues/121284
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/121284
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/121284
#122754https://github.com/python/cpython/pull/122754
email: invalid RFC 2047 address header after refolding with email.policy.default https://github.com/python/cpython/issues/121284#top
#122754https://github.com/python/cpython/pull/122754
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
topic-emailhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-email%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
type-securityA security issuehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-security%22
https://github.com/medmunds
medmundshttps://github.com/medmunds
on Jul 2, 2024https://github.com/python/cpython/issues/121284#issue-2386852702
is in a later commenthttps://github.com/python/cpython/issues/121284#issuecomment-2207348299
Django ticket 35378https://code.djangoproject.com/ticket/35378
anymail/django-anymail#369https://github.com/anymail/django-anymail/issues/369
@andresmrmhttps://github.com/andresmrm
#80222https://github.com/python/cpython/issues/80222
gh-121284: Fix email address header folding with parsed encoded-word #122754https://github.com/python/cpython/pull/122754
[3.13] gh-121284: Fix email address header folding with parsed encoded-word (GH-122754) #131403https://github.com/python/cpython/pull/131403
[3.12] gh-121284: Fix email address header folding with parsed encoded-word (GH-122754) #131404https://github.com/python/cpython/pull/131404
[3.11] gh-121284: Fix email address header folding with parsed encoded-word (GH-122754) #131405https://github.com/python/cpython/pull/131405
[3.10] gh-121284: Fix email address header folding with parsed encoded-word (GH-122754) #131411https://github.com/python/cpython/pull/131411
[3.9] gh-121284: Fix email address header folding with parsed encoded-word (GH-122754) #131412https://github.com/python/cpython/pull/131412
Nexthttps://github.com/python/cpython/issues/121284?timeline_page=1
medmundshttps://github.com/medmunds
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
on Jul 2, 2024https://github.com/python/cpython/issues/121284#event-13369930344
https://github.com/JamesParrott
JamesParrotthttps://github.com/JamesParrott
on Jul 3, 2024https://github.com/python/cpython/issues/121284#issuecomment-2205961778
https://github.com/python/cpython/blob/main/Lib/email/policy.py#L226https://github.com/python/cpython/blob/main/Lib/email/policy.py#L226
https://github.com/medmunds
medmundshttps://github.com/medmunds
on Jul 3, 2024https://github.com/python/cpython/issues/121284#issuecomment-2207348299
Andrés identifiedhttps://github.com/anymail/django-anymail/issues/369#issuecomment-2056734770
freely mixhttps://datatracker.ietf.org/doc/html/rfc2047#section-8
those workaroundshttps://github.com/django/django/blob/5.0/django/core/mail/message.py#L78-L121
medmundshttps://github.com/medmunds
on Jul 3, 2024https://github.com/python/cpython/issues/121284#event-13386577403
https://github.com/medmunds
medmundshttps://github.com/medmunds
on Jul 3, 2024https://github.com/python/cpython/issues/121284#issuecomment-2207391154
#80222https://github.com/python/cpython/issues/80222
https://github.com/JamesParrott
JamesParrotthttps://github.com/JamesParrott
on Jul 4, 2024https://github.com/python/cpython/issues/121284#issuecomment-2207784078
medmundshttps://github.com/medmunds
on Aug 6, 2024https://github.com/python/cpython/issues/121284#event-13783149182
pythongh-121284: Fix email address header folding with parsed encoded…https://github.com/medmunds/cpython/commit/c540c9f6a5e1d7ebe14e2a4b737e8b1e76a7bb1b
pythongh-121284https://github.com/python/cpython/issues/121284
c540c9fhttps://github.com/medmunds/cpython/commit/c540c9f6a5e1d7ebe14e2a4b737e8b1e76a7bb1b
https://github.com/medmunds
medmundshttps://github.com/medmunds
on Aug 6, 2024https://github.com/python/cpython/issues/121284#issuecomment-2272084556
#80222https://github.com/python/cpython/issues/80222
#122754https://github.com/python/cpython/pull/122754
#80222https://github.com/python/cpython/issues/80222
#80222https://github.com/python/cpython/issues/80222
sethmlarsonhttps://github.com/sethmlarson
type-securityA security issuehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-security%22
topic-emailhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-email%22
on Aug 12, 2024https://github.com/python/cpython/issues/121284#event-13851592250
https://github.com/medmunds
medmundshttps://github.com/medmunds
on Nov 21, 2024https://github.com/python/cpython/issues/121284#issuecomment-2489857000
Ping!https://devguide.python.org/getting-started/pull-request-lifecycle/#reviewing
#122754https://github.com/python/cpython/pull/122754
picnixzhttps://github.com/picnixz
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
on Dec 3, 2024https://github.com/python/cpython/issues/121284#event-15508954126
https://github.com/medmunds
medmundshttps://github.com/medmunds
on Feb 17, 2025https://github.com/python/cpython/issues/121284#issuecomment-2664240704
workaroundhttps://github.com/django/django/blob/8dbecc88c80feb79f2150c308603c7129316e871/django/core/mail/message.py#L409-L442
https://github.com/bitdancer
bitdancerhttps://github.com/bitdancer
on Mar 4, 2025https://github.com/python/cpython/issues/121284#issuecomment-2695904787
https://github.com/medmunds
medmundshttps://github.com/medmunds
on Mar 4, 2025https://github.com/python/cpython/issues/121284#issuecomment-2696014567
encukouhttps://github.com/encukou
on Mar 18, 2025https://github.com/python/cpython/issues/121284#event-16832234350
encukouhttps://github.com/encukou
on Mar 18, 2025https://github.com/python/cpython/issues/121284#event-16832357473
[3.10] pythongh-121284: Fix email address header folding with parsed …https://github.com/encukou/cpython/commit/2d98d498602bc8b00b00b7af453107ca0cbb12a7
pythongh-121284https://github.com/python/cpython/issues/121284
2d98d49https://github.com/encukou/cpython/commit/2d98d498602bc8b00b00b7af453107ca0cbb12a7
[3.10] pythongh-121284: Fix email address header folding with parsed …https://github.com/encukou/cpython/commit/94caf672a7420dc56a93e0cd4c38c8e57a9df86d
pythongh-121284https://github.com/python/cpython/issues/121284
94caf67https://github.com/encukou/cpython/commit/94caf672a7420dc56a93e0cd4c38c8e57a9df86d
[3.9] pythongh-121284: Fix email address header folding with parsed e…https://github.com/encukou/cpython/commit/521fa7e50e285bf2de3404297f8cadbff56776da
pythongh-121284https://github.com/python/cpython/issues/121284
521fa7ehttps://github.com/encukou/cpython/commit/521fa7e50e285bf2de3404297f8cadbff56776da
[3.9] pythongh-121284: Fix email address header folding with parsed e…https://github.com/encukou/cpython/commit/d62e09b0c88c612bbebc10ec27b6318be98515c7
pythongh-121284https://github.com/python/cpython/issues/121284
d62e09bhttps://github.com/encukou/cpython/commit/d62e09b0c88c612bbebc10ec27b6318be98515c7
[3.9] pythongh-121284: Fix email address header folding with parsed e…https://github.com/encukou/cpython/commit/f6a03b8a6a80fb4d85d7d96be66903be08ebf9c4
pythongh-121284https://github.com/python/cpython/issues/121284
f6a03b8https://github.com/encukou/cpython/commit/f6a03b8a6a80fb4d85d7d96be66903be08ebf9c4
bitdancerhttps://github.com/bitdancer
on Mar 18, 2025https://github.com/python/cpython/issues/121284#event-16845075952
[3.13] gh-121284: Fix email address header folding with parsed encode…https://github.com/python/cpython/commit/31767e61008c404e51c415b86b443baf2318bfdf
gh-121284https://github.com/python/cpython/issues/121284
31767e6https://github.com/python/cpython/commit/31767e61008c404e51c415b86b443baf2318bfdf
[3.12] gh-121284: Fix email address header folding with parsed encode…https://github.com/python/cpython/commit/5dfb5e640ec03ff057dbd9f1e32bf6a493fd2f3d
gh-121284https://github.com/python/cpython/issues/121284
5dfb5e6https://github.com/python/cpython/commit/5dfb5e640ec03ff057dbd9f1e32bf6a493fd2f3d
colesburyhttps://github.com/colesbury
on Mar 20, 2025https://github.com/python/cpython/issues/121284#event-16915334479
pythongh-121284: Fix email address header folding with parsed encoded…https://github.com/colesbury/cpython/commit/026913a3b44c54b31b7200cd758ad1e69699aa5d
pythongh-121284https://github.com/python/cpython/issues/121284
026913ahttps://github.com/colesbury/cpython/commit/026913a3b44c54b31b7200cd758ad1e69699aa5d
ambvhttps://github.com/ambv
on Apr 3, 2025https://github.com/python/cpython/issues/121284#event-17117163001
[3.11] gh-121284: Fix email address header folding with parsed encode…https://github.com/python/cpython/commit/0a66052d8dec1a143bc77015ce7522ea812817ed
gh-121284https://github.com/python/cpython/issues/121284
0a66052https://github.com/python/cpython/commit/0a66052d8dec1a143bc77015ce7522ea812817ed
[3.10] gh-121284: Fix email address header folding with parsed encode…https://github.com/python/cpython/commit/cfaee20d7eaa1442c1a22ef695e60ac5660bfecd
gh-121284https://github.com/python/cpython/issues/121284
cfaee20https://github.com/python/cpython/commit/cfaee20d7eaa1442c1a22ef695e60ac5660bfecd
[3.9] gh-121284: Fix email address header folding with parsed encoded…https://github.com/python/cpython/commit/9a31386eec8715ab5842bbe8cfcc0fb5cf3631af
gh-121284https://github.com/python/cpython/issues/121284
9a31386https://github.com/python/cpython/commit/9a31386eec8715ab5842bbe8cfcc0fb5cf3631af
ambvhttps://github.com/ambv
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Apr 3, 2025https://github.com/python/cpython/issues/121284#event-17117173531
gentoo-bothttps://github.com/gentoo-bot
on Apr 9, 2025https://github.com/python/cpython/issues/121284#event-17194968487
[3.9] pythongh-121284: Fix email address header folding with parsed e…https://github.com/gentoo/cpython/commit/2a2752a279085bc51f92a32b622204d356a33fd1
pythongh-121284https://github.com/python/cpython/issues/121284
2a2752ahttps://github.com/gentoo/cpython/commit/2a2752a279085bc51f92a32b622204d356a33fd1
bitdancerhttps://github.com/bitdancer
on Jul 19, 2026https://github.com/python/cpython/issues/121284#event-28181432179
Improve bare_quoted_string tests.https://github.com/bitdancer/cpython/commit/b7bc1ceda8e58903918f33ce2d2078cf8622108a
b7bc1cehttps://github.com/bitdancer/cpython/commit/b7bc1ceda8e58903918f33ce2d2078cf8622108a
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/121284
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/121284
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
topic-emailhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-email%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
type-securityA security issuehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-security%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.