Title: Should we allow relative includes? (i.e. #include "../_ssl.h") · Issue #121223 · python/cpython · GitHub
Open Graph Title: Should we allow relative includes? (i.e. #include "../_ssl.h") · Issue #121223 · python/cpython
X Title: Should we allow relative includes? (i.e. #include "../_ssl.h") · Issue #121223 · python/cpython
Description: Feature or enhancement Proposal: Can we avoid the relative include? They tend to produce problems further down the road. Originally posted by @erlend-aasland in #120894 (comment) There are few more examples: $ git grep '#include .*\.\.\/...
Open Graph Description: Feature or enhancement Proposal: Can we avoid the relative include? They tend to produce problems further down the road. Originally posted by @erlend-aasland in #120894 (comment) There are few more...
X Description: Feature or enhancement Proposal: Can we avoid the relative include? They tend to produce problems further down the road. Originally posted by @erlend-aasland in #120894 (comment) There are few more...
Opengraph URL: https://github.com/python/cpython/issues/121223
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Should we allow relative includes? (i.e. #include \"../_ssl.h\")","articleBody":"# Feature or enhancement\n\n### Proposal:\n\n Can we avoid the relative include? They tend to produce problems further down the road.\n\n_Originally posted by @erlend-aasland in https://github.com/python/cpython/pull/120894#discussion_r1658402167_\n\nThere are few more examples:\n```\n$ git grep '#include .*\\.\\.\\/'\nInclude/internal/mimalloc/mimalloc/track.h:#include \"../src/prim/windows/etw.h\"\nModules/_blake2/blake2b_impl.c:#include \"../hashlib.h\"\nModules/_blake2/blake2s_impl.c:#include \"../hashlib.h\"\nModules/_ctypes/callproc.c:#include \"../_complex.h\" // complex\nModules/_hacl/internal/Hacl_Hash_MD5.h:#include \"../Hacl_Hash_MD5.h\"\nModules/_hacl/internal/Hacl_Hash_SHA1.h:#include \"../Hacl_Hash_SHA1.h\"\nModules/_hacl/internal/Hacl_Hash_SHA2.h:#include \"../Hacl_Hash_SHA2.h\"\nModules/_hacl/internal/Hacl_Hash_SHA3.h:#include \"../Hacl_Hash_SHA3.h\"\nModules/_ssl/cert.c:#include \"../_ssl.h\"\nModules/_ssl/misc.c:#include \"../_ssl.h\"\nModules/_testinternalcapi/set.c:#include \"../_testcapi/util.h\" // NULLABLE, RETURN_INT\nObjects/mimalloc/prim/osx/prim.c:#include \"../unix/prim.c\"\nParser/lexer/lexer.c:#include \"../tokenizer/helpers.h\"\nParser/tokenizer/file_tokenizer.c:#include \"../lexer/state.h\"\nParser/tokenizer/file_tokenizer.c:#include \"../lexer/lexer.h\"\nParser/tokenizer/file_tokenizer.c:#include \"../lexer/buffer.h\"\nParser/tokenizer/helpers.c:#include \"../lexer/state.h\"\nParser/tokenizer/helpers.h:#include \"../lexer/state.h\"\nParser/tokenizer/readline_tokenizer.c:#include \"../lexer/lexer.h\"\nParser/tokenizer/readline_tokenizer.c:#include \"../lexer/state.h\"\nParser/tokenizer/readline_tokenizer.c:#include \"../lexer/buffer.h\"\nParser/tokenizer/string_tokenizer.c:#include \"../lexer/state.h\"\nParser/tokenizer/utf8_tokenizer.c:#include \"../lexer/state.h\"\nPython/Python-tokenize.c:#include \"../Parser/lexer/state.h\"\nPython/Python-tokenize.c:#include \"../Parser/lexer/lexer.h\"\nPython/Python-tokenize.c:#include \"../Parser/tokenizer/tokenizer.h\"\nPython/Python-tokenize.c:#include \"../Parser/pegen.h\" // _PyPegen_byte_offset_to_character_offset()\n```\n\n### Has this already been discussed elsewhere?\n\nThis is a minor feature, which does not need previous discussion elsewhere\n\n### Links to previous discussion of this feature:\n\n_No response_","author":{"url":"https://github.com/skirpichev","@type":"Person","name":"skirpichev"},"datePublished":"2024-07-01T12:15:18.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/121223/cpython/issues/121223"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e527acf6-fbc2-c1f5-c167-627497af4601 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B0B2:177C15:3DBFFB:53494C:6A52D05A |
| html-safe-nonce | c032160525cf58aff437ac476ac46c67fbee42e68688313e9c2d9265c14c912f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMEIyOjE3N0MxNTozREJGRkI6NTM0OTRDOjZBNTJEMDVBIiwidmlzaXRvcl9pZCI6IjkzNzU1ODM2NDI2Njg3NzAxOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f44b2de72bd3188d78f9e8048ca514267c0765b2d2ada25c8c6cdadbe8d6e65d |
| hovercard-subject-tag | issue:2383689575 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/121223/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c6ec9e8a0c4da1ce3f3623bd0a6a9498fe9cd5e5fa71313c7535032f7ebe0e17/python/cpython/issues/121223 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c6ec9e8a0c4da1ce3f3623bd0a6a9498fe9cd5e5fa71313c7535032f7ebe0e17/python/cpython/issues/121223 |
| og:image:alt | Feature or enhancement Proposal: Can we avoid the relative include? They tend to produce problems further down the road. Originally posted by @erlend-aasland in #120894 (comment) There are few more... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | skirpichev |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width