René's URL Explorer Experiment


Title: Add assertFloatsAreIdentical/assertComplexAreIdentical to unittest (or kwarg to assertEqual)? · Issue #121039 · python/cpython · GitHub

Open Graph Title: Add assertFloatsAreIdentical/assertComplexAreIdentical to unittest (or kwarg to assertEqual)? · Issue #121039 · python/cpython

X Title: Add assertFloatsAreIdentical/assertComplexAreIdentical to unittest (or kwarg to assertEqual)? · Issue #121039 · python/cpython

Description: Feature or enhancement Proposal: Clones of assertFloatsAreIdentical() are scattered across the CPython tests: cpython/Lib/test/test_complex.py Line 74 in d8f8243 def assertFloatsAreIdentical(self, x, y): cpython/Lib/test/test_cmath.py Li...

Open Graph Description: Feature or enhancement Proposal: Clones of assertFloatsAreIdentical() are scattered across the CPython tests: cpython/Lib/test/test_complex.py Line 74 in d8f8243 def assertFloatsAreIdentical(self, ...

X Description: Feature or enhancement Proposal: Clones of assertFloatsAreIdentical() are scattered across the CPython tests: cpython/Lib/test/test_complex.py Line 74 in d8f8243 def assertFloatsAreIdentical(self, ...

Opengraph URL: https://github.com/python/cpython/issues/121039

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Add assertFloatsAreIdentical/assertComplexAreIdentical to unittest (or kwarg to assertEqual)?","articleBody":"# Feature or enhancement\r\n\r\n### Proposal:\r\n\r\nClones of assertFloatsAreIdentical() are scattered across the CPython tests:\r\nhttps://github.com/python/cpython/blob/d8f82432a36178a2376cc2d0984b02bb03f6d55f/Lib/test/test_complex.py#L74\r\nhttps://github.com/python/cpython/blob/d8f82432a36178a2376cc2d0984b02bb03f6d55f/Lib/test/test_cmath.py#L68\r\nhttps://github.com/python/cpython/blob/d8f82432a36178a2376cc2d0984b02bb03f6d55f/Lib/test/test_float.py#L1069\r\nhttps://github.com/python/cpython/blob/d8f82432a36178a2376cc2d0984b02bb03f6d55f/Lib/test/test_capi/test_getargs.py#L440\r\n\r\nMaybe it's worth to have a dedicated check?\r\n\r\nOr a special kwarg for the assertEqual method, to workaround ``NAN`` and ``-0.0`` values for floats/complexes.\r\n\r\nEdit:\r\n\r\nOr at least some support from Lib/test/support...  I was adding similar helper yet in another test file and that looks odd.\r\n\r\nNumpy has numpy.testing.assert_equal():\r\n```pycon\r\n\u003e\u003e\u003e np.testing.assert_equal([0.0], [+0.0])\r\n\u003e\u003e\u003e np.testing.assert_equal([0.0], [-0.0])\r\nTraceback (most recent call last):\r\n  ...\r\nAssertionError: \r\nItems are not equal:\r\nitem=0\r\n\r\n ACTUAL: 0.0\r\n DESIRED: -0.0\r\n\u003e\u003e\u003e np.testing.assert_equal([np.nan], [np.nan])\r\n\u003e\u003e\u003e np.testing.assert_equal([0.0], [np.nan])\r\nTraceback (most recent call last):\r\n  ...\r\nAssertionError: \r\nItems are not equal:\r\nitem=0\r\n\r\n ACTUAL: 0.0\r\n DESIRED: nan\r\n```\r\n\r\n### Has this already been discussed elsewhere?\r\n\r\nThis is a minor feature, which does not need previous discussion elsewhere\r\n\r\n### Links to previous discussion of this feature:\r\n\r\n_No response_\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-121071\n* gh-123840\n* gh-123841\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/skirpichev","@type":"Person","name":"skirpichev"},"datePublished":"2024-06-26T09:13:28.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/121039/cpython/issues/121039"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:87cf8f96-1ef9-bf00-5b95-77fa25098f7e
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE0F0:209A07:A2C844:DB1884:6A53140B
html-safe-nonce0371af954a9de586fad2732ed7594ae8d70676811f26e7bf207ad2e357cd204e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMEYwOjIwOUEwNzpBMkM4NDQ6REIxODg0OjZBNTMxNDBCIiwidmlzaXRvcl9pZCI6IjUzODA2MTI0NTE4NDYwMDE2NzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7ece8be862fcfd1a6526833b7de4f21f370ed366e20517656f219a2e85afe8e0
hovercard-subject-tagissue:2374801727
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/121039/issue_layout
twitter:imagehttps://opengraph.githubassets.com/4a508e4f3e97d51795cc45b6dbf24a19aff46796d409f3c4107a79ffc474df1a/python/cpython/issues/121039
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4a508e4f3e97d51795cc45b6dbf24a19aff46796d409f3c4107a79ffc474df1a/python/cpython/issues/121039
og:image:altFeature or enhancement Proposal: Clones of assertFloatsAreIdentical() are scattered across the CPython tests: cpython/Lib/test/test_complex.py Line 74 in d8f8243 def assertFloatsAreIdentical(self, ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameskirpichev
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/121039#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F121039
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F121039
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/121039
Reloadhttps://github.com/python/cpython/issues/121039
Reloadhttps://github.com/python/cpython/issues/121039
Please reload this pagehttps://github.com/python/cpython/issues/121039
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/121039
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Add assertFloatsAreIdentical/assertComplexAreIdentical to unittest (or kwarg to assertEqual)?https://github.com/python/cpython/issues/121039#top
testsTests in the Lib/test dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22tests%22
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
on Jun 26, 2024https://github.com/python/cpython/issues/121039#issue-2374801727
cpython/Lib/test/test_complex.pyhttps://github.com/python/cpython/blob/d8f82432a36178a2376cc2d0984b02bb03f6d55f/Lib/test/test_complex.py#L74
d8f8243https://github.com/python/cpython/commit/d8f82432a36178a2376cc2d0984b02bb03f6d55f
cpython/Lib/test/test_cmath.pyhttps://github.com/python/cpython/blob/d8f82432a36178a2376cc2d0984b02bb03f6d55f/Lib/test/test_cmath.py#L68
d8f8243https://github.com/python/cpython/commit/d8f82432a36178a2376cc2d0984b02bb03f6d55f
cpython/Lib/test/test_float.pyhttps://github.com/python/cpython/blob/d8f82432a36178a2376cc2d0984b02bb03f6d55f/Lib/test/test_float.py#L1069
d8f8243https://github.com/python/cpython/commit/d8f82432a36178a2376cc2d0984b02bb03f6d55f
cpython/Lib/test/test_capi/test_getargs.pyhttps://github.com/python/cpython/blob/d8f82432a36178a2376cc2d0984b02bb03f6d55f/Lib/test/test_capi/test_getargs.py#L440
d8f8243https://github.com/python/cpython/commit/d8f82432a36178a2376cc2d0984b02bb03f6d55f
gh-121039: add Floats/ComplexesAreIdenticalMixin to test.support.testcase #121071https://github.com/python/cpython/pull/121071
[3.13] gh-121039: add Floats/ComplexesAreIdenticalMixin to test.support.testcase (GH-121071) #123840https://github.com/python/cpython/pull/123840
[3.12] gh-121039: add Floats/ComplexesAreIdenticalMixin to test.support.testcase (GH-121071) #123841https://github.com/python/cpython/pull/123841
testsTests in the Lib/test dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22tests%22
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.