Title: Failing configure tests due to missing space · Issue #120671 · python/cpython · GitHub
Open Graph Title: Failing configure tests due to missing space · Issue #120671 · python/cpython
X Title: Failing configure tests due to missing space · Issue #120671 · python/cpython
Description: Bug report Bug description: When building CPython from source, I noticed some suspicious errors that seem to be related to a missing spaces in the configure script. It seems that most uses of as_fn_append correctly include a leading spac...
Open Graph Description: Bug report Bug description: When building CPython from source, I noticed some suspicious errors that seem to be related to a missing spaces in the configure script. It seems that most uses of as_fn...
X Description: Bug report Bug description: When building CPython from source, I noticed some suspicious errors that seem to be related to a missing spaces in the configure script. It seems that most uses of as_fn...
Opengraph URL: https://github.com/python/cpython/issues/120671
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Failing configure tests due to missing space","articleBody":"# Bug report\n\n### Bug description:\n\nWhen building CPython from source, I noticed some suspicious errors that seem to be related to a missing spaces in the configure script. It seems that most uses of `as_fn_append` correctly include a leading space before appending to a variable, however, there are several cases where this space has not been added which can lead to two arguments being concatenated:\n\n- https://github.com/python/cpython/blob/main/configure#L9617\n- https://github.com/python/cpython/blob/main/configure#L9735\n- https://github.com/python/cpython/blob/main/configure#L9780\n- https://github.com/python/cpython/blob/main/configure#L9821\n- https://github.com/python/cpython/blob/main/configure#L9862\n- https://github.com/python/cpython/blob/main/configure#L9903\n- https://github.com/python/cpython/blob/main/configure#L9944\n- https://github.com/python/cpython/blob/main/configure#L9996\n\nWhen compiling to Emscripten in Bazel, for example, I end up with `-sRELOCATABLE=1-Wstrict-prototypes` in one of my tests:\n```\nconfigure:9880: checking if we can enable /home/developer/.cache/bazel/_bazel_developer/25e07d78077dfe1eca932359d50e41ef/sandbox/processwrapper-sandbox/29/execroot/_main/external/emsdk/emscripten_toolchain/emcc.sh strict-prototypes warning\nconfigure:9900: /home/developer/.cache/bazel/_bazel_developer/25e07d78077dfe1eca932359d50e41ef/sandbox/processwrapper-sandbox/29/execroot/_main/external/emsdk/emscripten_toolchain/emcc.sh -c --sysroot=/home/developer/.cache/bazel/_bazel_developer/25e07d78077dfe1eca932359d50e41ef/sandbox/processwrapper-sandbox/29/execroot/_main/external/emscripten_bin_linux/emscripten/cache/sysroot -fdiagnostics-color -fno-strict-aliasing -funsigned-char -no-canonical-prefixes -Wall -iwithsysroot/include/c++/v1 -iwithsysroot/include/compat -iwithsysroot/include -isystem /home/developer/.cache/bazel/_bazel_developer/25e07d78077dfe1eca932359d50e41ef/sandbox/processwrapper-sandbox/29/execroot/_main/external/emscripten_bin_linux/lib/clang/19/include -Wno-builtin-macro-redefined -D__DATE__=redacted -D__TIMESTAMP__=redacted -D__TIME__=redacted -O2 -g0 -fwasm-exceptions -pthread -sRELOCATABLE=1-Wstrict-prototypes -Werror -I/home/developer/.cache/bazel/_bazel_developer/25e07d78077dfe1eca932359d50e41ef/sandbox/processwrapper-sandbox/29/execroot/_main/bazel-out/k8-fastbuild/bin/python/libpython.ext_build_deps/libffi/include conftest.c \u003e\u00265\nemcc: error: setting `RELOCATABLE` expects `bool` but got `str`\n```\n\n### CPython versions tested on:\n\n3.12\n\n### Operating systems tested on:\n\nOther\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-120822\n* gh-120985\n* gh-120986\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/allsey87","@type":"Person","name":"allsey87"},"datePublished":"2024-06-18T09:32:02.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":7},"url":"https://github.com/120671/cpython/issues/120671"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:78779400-3954-3cf0-baef-4aad7aa8490c |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D2B2:20F249:3C7215:551CF2:696A0A81 |
| html-safe-nonce | be276ce25fd0a78b8405c2f6a4cc5887b76b623585d5619b8f386ff41d0dafbb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkIyOjIwRjI0OTozQzcyMTU6NTUxQ0YyOjY5NkEwQTgxIiwidmlzaXRvcl9pZCI6IjgxNzA4NTM0MzkwMzQyMzE0MjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d501519c45ec2474b2a8093366628ed802fcca8ebfaaaaf905b135d9590be082 |
| hovercard-subject-tag | issue:2359400682 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/120671/issue_layout |
| twitter:image | https://opengraph.githubassets.com/305472093fe8c4cb304e82a5d93c4446a623c82c6bfcd9c8116eec59eaa213d2/python/cpython/issues/120671 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/305472093fe8c4cb304e82a5d93c4446a623c82c6bfcd9c8116eec59eaa213d2/python/cpython/issues/120671 |
| og:image:alt | Bug report Bug description: When building CPython from source, I noticed some suspicious errors that seem to be related to a missing spaces in the configure script. It seems that most uses of as_fn... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | allsey87 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 699227a00bbb7fe1eec276d2ae1c3a93068bc5ba483bd9dc4b2a27a8f4f2f595 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7266b2d935baa1c6474b16dd9feaa5ca30607261 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width