René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Python 3.12+ breaks backwards compatibility for logging QueueHandler with some Queue classes","articleBody":"# Bug report\r\n\r\n### Bug description:\r\n\r\nRelated bug: https://github.com/python/cpython/issues/111615\r\nRelated pull: https://github.com/python/cpython/pull/111638\r\nRelated [codes](https://github.com/python/cpython/blob/3.12/Lib/logging/config.py#L789-L804):\r\nhttps://github.com/python/cpython/blob/bd0d97ce3497da35d17daa329c294f4cb87196ee/Lib/logging/config.py#L789-L804\r\n\r\n#### reproducible example using Python 3.12.3\r\n\r\n```python\r\nimport logging.config\r\n\r\n\r\ndef main(q):\r\n    config = {\r\n        'version': 1,\r\n        'handlers': {\r\n            'sink': {\r\n                'class': 'logging.handlers.QueueHandler',\r\n                'queue': q,\r\n            },\r\n        },\r\n        'root': {\r\n            'handlers': ['sink'],\r\n        },\r\n    }\r\n    logging.config.dictConfig(config)\r\n\r\n\r\nif __name__ == '__main__':\r\n    import multiprocessing as mp\r\n    main(mp.Manager().Queue())\r\n    #import asyncio\r\n    #main(asyncio.Queue())  # broken too\r\n```\r\n\r\nerror:\r\n\r\n```\r\nTraceback (most recent call last):\r\n  File \"/usr/lib/python3.12/logging/config.py\", line 581, in configure\r\n    handler = self.configure_handler(handlers[name])\r\n              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n  File \"/usr/lib/python3.12/logging/config.py\", line 801, in configure_handler\r\n    raise TypeError('Invalid queue specifier %r' % qspec)\r\nTypeError: Invalid queue specifier \u003cAutoProxy[Queue] object, typeid 'Queue' at 0x7f8b07189d90\u003e\r\n\r\nThe above exception was the direct cause of the following exception:\r\n\r\nTraceback (most recent call last):\r\n  File \"/home/xxx/logging-queue-handler-bug.py\", line 33, in \u003cmodule\u003e\r\n    main(mp.Manager().Queue())\r\n  File \"/home/xxx/logging-queue-handler-bug.py\", line 29, in main\r\n    logging.config.dictConfig(config)\r\n  File \"/usr/lib/python3.12/logging/config.py\", line 914, in dictConfig\r\n    dictConfigClass(config).configure()\r\n  File \"/usr/lib/python3.12/logging/config.py\", line 588, in configure\r\n    raise ValueError('Unable to configure handler '\r\nValueError: Unable to configure handler 'sink'\r\n```\r\n\r\n#### Queue classes to check for logging QueueHandler\r\n\r\n* queue.Queue(), `\u003cqueue.Queue at 0x7fb86eeef170\u003e`, **works**.\r\n* multiprocessing\r\n    - multiprocessing.Queue(), `\u003cmultiprocessing.queues.Queue at 0x7fb871790500\u003e`, **works**.\r\n    - multiprocessing.Manager().Queue()  `\u003cAutoProxy[Queue] object, typeid 'Queue' at 0x7fb86ef4a840\u003e`, **broken**.\r\n       Its class is `multiprocessing.managers.AutoProxy[Queue]`, a subclass of `multiprocessing.managers.BaseProxy`.\r\n* asyncio.queues.Queue() `\u003cQueue at 0x7fb86f0be4e0 maxsize=0\u003e`, **broken**.\r\n* any other Queue?\r\n\r\n#### discuss: how to fix\r\n\r\nCheck all Queue classes mentioned above in\r\nhttps://github.com/python/cpython/blob/bd0d97ce3497da35d17daa329c294f4cb87196ee/Lib/logging/config.py#L792\r\n\r\nor just focus on handling special cases: str and dict, while leaving other cases un-checked (e.g., queue.Queue, multiprocessing.queues.Queue).\r\n\r\n\r\n### CPython versions tested on:\r\n\r\n3.12\r\n\r\n### Operating systems tested on:\r\n\r\nLinux\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-120030\n* gh-120034\n* gh-120035\n* gh-120067\n* gh-120071\n* gh-120072\n* gh-120090\n* gh-120092\n* gh-120093\n* gh-120476\n* gh-120531\n* gh-120532\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/shmilee","@type":"Person","name":"shmilee"},"datePublished":"2024-05-31T05:02:48.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":20},"url":"https://github.com/119819/cpython/issues/119819"}