René's URL Explorer Experiment


Title: Difference in _use_fd_functions in shutil.py and test_shutil.py · Issue #119048 · python/cpython · GitHub

Open Graph Title: Difference in _use_fd_functions in shutil.py and test_shutil.py · Issue #119048 · python/cpython

X Title: Difference in _use_fd_functions in shutil.py and test_shutil.py · Issue #119048 · python/cpython

Description: Bug report Bug description: When switching from os.listdir to os.scandir 7 years ago somebody forgot to update the definition of _use_fd_functions in test_shutil together with shutil module. in shutil: _use_fd_functions = ({os.open, os.s...

Open Graph Description: Bug report Bug description: When switching from os.listdir to os.scandir 7 years ago somebody forgot to update the definition of _use_fd_functions in test_shutil together with shutil module. in shu...

X Description: Bug report Bug description: When switching from os.listdir to os.scandir 7 years ago somebody forgot to update the definition of _use_fd_functions in test_shutil together with shutil module. in shu...

Opengraph URL: https://github.com/python/cpython/issues/119048

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Difference in _use_fd_functions in shutil.py and test_shutil.py","articleBody":"# Bug report\n\n### Bug description:\n\nWhen switching from `os.listdir` to `os.scandir` [7 years ago](https://github.com/python/cpython/commit/d4d79bc1ff91b04625c312f0219c89aabcd19ce4) somebody forgot to update the definition of _use_fd_functions in `test_shutil` together with `shutil` module.\n\nin shutil:\n```\n_use_fd_functions = ({os.open, os.stat, os.unlink, os.rmdir} \u003c=\n                     os.supports_dir_fd and\n                     os.scandir in os.supports_fd and\n                     os.stat in os.supports_follow_symlinks)\n```\n\nin test_shutil:\n```\n        _use_fd_functions = ({os.open, os.stat, os.unlink, os.rmdir} \u003c=\n                             os.supports_dir_fd and\n                             os.listdir in os.supports_fd and\n                             os.stat in os.supports_follow_symlinks)\n```\n\nI believe there is no need to calculate this variable twice so I'm gonna propose a PR where I use the value from shutil.py in its tests. Nobody will ever forget to update both places again.\n\n### CPython versions tested on:\n\nCPython main branch\n\n### Operating systems tested on:\n\n_No response_\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-157912\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/frenzymadness","@type":"Person","name":"frenzymadness"},"datePublished":"2024-05-14T18:48:16Z","url":"https://github.com/python/cpython/issues/119048"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:8be8eb0e-0022-2d75-a2e8-9acf198ebe97
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE668:172B92:359DA9A:476C3BD:6B020773
html-safe-nonce48b52e53a7c405ec39d0d6df376d67b377d97998b8f953a8d22552ab7b6dce26
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjY4OjE3MkI5MjozNTlEQTlBOjQ3NkMzQkQ6NkIwMjA3NzMiLCJ2aXNpdG9yX2lkIjoiNDIzOTU5MDM0NzQxNzcxNjU5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6ae7f185b9691954462909d9f274f057a1f1408d1cc62192fb03191b518cc125
hovercard-subject-tagissue:2296152049
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/119048/issue_layout
twitter:imagehttps://opengraph.githubassets.com/e3dcf619f5a0e78ec03b490106965a9f3629fd80affdb11a609111af15401ba7/python/cpython/issues/119048
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e3dcf619f5a0e78ec03b490106965a9f3629fd80affdb11a609111af15401ba7/python/cpython/issues/119048
og:image:altBug report Bug description: When switching from os.listdir to os.scandir 7 years ago somebody forgot to update the definition of _use_fd_functions in test_shutil together with shutil module. in shu...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamefrenzymadness
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/119048#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F119048
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F119048
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/119048
Reloadhttps://github.com/python/cpython/issues/119048
Reloadhttps://github.com/python/cpython/issues/119048
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/119048
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/119048
Difference in _use_fd_functions in shutil.py and test_shutil.pyhttps://github.com/python/cpython/issues/119048#top
testsTests in the Lib/test dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22tests%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/frenzymadness
frenzymadnesshttps://github.com/frenzymadness
on May 14, 2024https://github.com/python/cpython/issues/119048#issue-2296152049
7 years agohttps://github.com/python/cpython/commit/d4d79bc1ff91b04625c312f0219c89aabcd19ce4
gh-119048: Use shutil._use_fd_functions in test_rmtree_uses_safe_fd_v… #157912https://github.com/python/cpython/pull/157912
frenzymadnesshttps://github.com/frenzymadness
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
on May 14, 2024https://github.com/python/cpython/issues/119048#event-12806747229
https://github.com/frenzymadness
frenzymadnesshttps://github.com/frenzymadness
on May 14, 2024https://github.com/python/cpython/issues/119048#issuecomment-2110927190
https://github.com/frenzymadness
frenzymadnesshttps://github.com/frenzymadness
on May 14, 2024https://github.com/python/cpython/issues/119048#issuecomment-2110929544
@encukouhttps://github.com/encukou
https://github.com/encukou
encukouhttps://github.com/encukou
on May 30, 2024https://github.com/python/cpython/issues/119048#issuecomment-2139452398
@serhiy-storchakahttps://github.com/serhiy-storchaka
https://github.com/vasiliyk
vasiliykhttps://github.com/vasiliyk
on Sep 21, 2026https://github.com/python/cpython/issues/119048#issuecomment-5761586006
@encukouhttps://github.com/encukou
StanFromIrelandhttps://github.com/StanFromIreland
testsTests in the Lib/test dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22tests%22
on Sep 21, 2026https://github.com/python/cpython/issues/119048#event-31539494388
encukouhttps://github.com/encukou
on Sep 22, 2026https://github.com/python/cpython/issues/119048#event-31596497786
gh-119048: Use shutil._use_fd_functions directly in test (GH-157912)https://github.com/python/cpython/commit/9777e8a67776ce225bfa594b4aedae0f18d2e3be
gh-119048https://github.com/python/cpython/issues/119048
GH-157912https://github.com/python/cpython/pull/157912
9777e8ahttps://github.com/python/cpython/commit/9777e8a67776ce225bfa594b4aedae0f18d2e3be
encukouhttps://github.com/encukou
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Sep 22, 2026https://github.com/python/cpython/issues/119048#event-31596570689
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/119048
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/119048
testsTests in the Lib/test dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22tests%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.