René's URL Explorer Experiment


Title: Add `INSTRUCTION_SIZE` macro to code generator. · Issue #118423 · python/cpython · GitHub

Open Graph Title: Add `INSTRUCTION_SIZE` macro to code generator. · Issue #118423 · python/cpython

X Title: Add `INSTRUCTION_SIZE` macro to code generator. · Issue #118423 · python/cpython

Description: In bytecodes.c we use both next_instr - this_instr and 1 + INLINE_CACHE_ENTRIES_... to mean "instruction length". We should add a macro for the purpose that is understood by the code generator. Examples The somewhat confusing LOAD_IP(1 +...

Open Graph Description: In bytecodes.c we use both next_instr - this_instr and 1 + INLINE_CACHE_ENTRIES_... to mean "instruction length". We should add a macro for the purpose that is understood by the code generator. Exa...

X Description: In bytecodes.c we use both next_instr - this_instr and 1 + INLINE_CACHE_ENTRIES_... to mean "instruction length". We should add a macro for the purpose that is understood by the code gene...

Opengraph URL: https://github.com/python/cpython/issues/118423

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Add `INSTRUCTION_SIZE` macro to code generator.","articleBody":"In bytecodes.c we use both `next_instr - this_instr` and `1 + INLINE_CACHE_ENTRIES_...` to mean \"instruction length\".\r\nWe should add a macro for the purpose that is understood by the code generator.\r\n\r\n### Examples\r\n\r\nThe somewhat confusing `LOAD_IP(1 + INLINE_CACHE_ENTRIES_SEND);` would become `LOAD_IP(INSTRUCTION_LENGTH)` \r\n\r\n`frame->return_offset = (uint16_t)(next_instr - this_instr);` would become `frame->return_offset = INSTRUCTION_LENGTH;` which is both easier to understand and wouldn't be rejected as tier 2 code.\r\n\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-125467\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/markshannon","@type":"Person","name":"markshannon"},"datePublished":"2024-04-30T10:32:45Z","url":"https://github.com/python/cpython/issues/118423"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:e3da8e60-7ffe-3b9b-ee07-1de32e3e8325
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8758:26E210:4473BC:59CCFD:6B023C4E
html-safe-nonce3028f681dd2f7d3d00f3fcd2db0d18f1a50b5c1e25894c1052dffcea670024c9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NzU4OjI2RTIxMDo0NDczQkM6NTlDQ0ZEOjZCMDIzQzRFIiwidmlzaXRvcl9pZCI6IjQ3NjEzNDgzNjA0MjQ3OTkzMTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac440a3be3fd5fd3cb8f37ab8064f6d2fa7e372f45898ace41f2d3593bcee7d41f
hovercard-subject-tagissue:2271101866
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/118423/issue_layout
twitter:imagehttps://opengraph.githubassets.com/8c3e8148195d193ccd991172dcf1130f89ec9344f9f369686409033a5517dd8f/python/cpython/issues/118423
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8c3e8148195d193ccd991172dcf1130f89ec9344f9f369686409033a5517dd8f/python/cpython/issues/118423
og:image:altIn bytecodes.c we use both next_instr - this_instr and 1 + INLINE_CACHE_ENTRIES_... to mean "instruction length". We should add a macro for the purpose that is understood by the code generator. Exa...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemarkshannon
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/118423#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F118423
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F118423
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/118423
Reloadhttps://github.com/python/cpython/issues/118423
Reloadhttps://github.com/python/cpython/issues/118423
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/118423
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/118423
Add INSTRUCTION_SIZE macro to code generator.https://github.com/python/cpython/issues/118423#top
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
https://github.com/markshannon
markshannonhttps://github.com/markshannon
on Apr 30, 2024https://github.com/python/cpython/issues/118423#issue-2271101866
gh-118423: Add INSTRUCTION_SIZE macro to code generator #125467https://github.com/python/cpython/pull/125467
erlend-aaslandhttps://github.com/erlend-aasland
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
on Apr 30, 2024https://github.com/python/cpython/issues/118423#event-12655857987
picnixzhttps://github.com/picnixz
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
on Oct 14, 2024https://github.com/python/cpython/issues/118423#event-14639728574
markshannonhttps://github.com/markshannon
on Oct 29, 2024https://github.com/python/cpython/issues/118423#event-14988748238
gh-118423: Add `INSTRUCTION_SIZE` macro to code generator (GH-125467)https://github.com/python/cpython/commit/aab58a93efd09185e3622572d2624a31e0fe405b
gh-118423https://github.com/python/cpython/issues/118423
GH-125467https://github.com/python/cpython/pull/125467
aab58a9https://github.com/python/cpython/commit/aab58a93efd09185e3622572d2624a31e0fe405b
picnixzhttps://github.com/picnixz
on Dec 8, 2024https://github.com/python/cpython/issues/118423#event-15572736781
pythongh-118423: Add `INSTRUCTION_SIZE` macro to code generator (pyth…https://github.com/picnixz/cpython/commit/4e37dabb5990596d5d7d01b5c6e04380f0e3a02a
pythongh-118423https://github.com/python/cpython/issues/118423
pyth…https://github.com/python/cpython/pull/125467
4e37dabhttps://github.com/picnixz/cpython/commit/4e37dabb5990596d5d7d01b5c6e04380f0e3a02a
https://github.com/Fidget-Spinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
on Dec 23, 2024https://github.com/python/cpython/issues/118423#issuecomment-2559544923
Fidget-Spinnerhttps://github.com/Fidget-Spinner
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Dec 23, 2024https://github.com/python/cpython/issues/118423#event-15747482507
ebonnalhttps://github.com/ebonnal
on Jan 12, 2025https://github.com/python/cpython/issues/118423#event-15894559117
pythongh-118423: Add `INSTRUCTION_SIZE` macro to code generator (pyth…https://github.com/ebonnal/cpython/commit/c3936cf86d56101bd81793c16b804f82ca6455cc
pythongh-118423https://github.com/python/cpython/issues/118423
pyth…https://github.com/python/cpython/pull/125467
c3936cfhttps://github.com/ebonnal/cpython/commit/c3936cf86d56101bd81793c16b804f82ca6455cc
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/118423
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/118423
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.