René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Add `dir_fd` to `os.path.lexists()` \u0026 `os.path.isdir()`","articleBody":"# Feature or enhancement\r\n\r\n### Proposal:\r\n\r\n`glob` currently needs its own implementation of `os.path.lexists()` \u0026 `os.path.isdir()` to support `dir_fd`:\r\n\r\nhttps://github.com/python/cpython/blob/f74e51229c83e3265f905dc15283bfe0ec1a659e/Lib/glob.py#L201-L222\r\n\r\nWe could refactor this by adding `dir_fd` to `os.path.lexists()` \u0026 `os.path.isdir()`:\r\n\r\n```diff\r\n-def lexists(path):\r\n+def lexists(path, *, dir_fd: int | None = None):\r\n     \"\"\"Test whether a path exists.  Returns True for broken symbolic links\"\"\"\r\n     try:\r\n-        os.lstat(path)\r\n+        os.lstat(path, dir_fd=dir_fd)\r\n     except (OSError, ValueError):\r\n         return False\r\n     return True\r\n```\r\n\r\n```diff\r\n-def isdir(s):\r\n+def isdir(s, *, dir_fd: int | None = None):\r\n     \"\"\"Return true if the pathname refers to an existing directory.\"\"\"\r\n     try:\r\n-        st = os.stat(s)\r\n+        st = os.stat(s, dir_fd=dir_fd)\r\n     except (OSError, ValueError):\r\n         return False\r\n     return stat.S_ISDIR(st.st_mode)\r\n```\r\n\r\n*Note: `nt._path_isdir()` (\u0026 `nt._path_lexists()` when #117842 lands) need to raise an error for this.*\r\n\r\n### Has this already been discussed elsewhere?\r\n\r\nThis is a minor feature, which does not need previous discussion elsewhere\r\n\r\n### Links to previous discussion of this feature:\r\n\r\n_No response_","author":{"url":"https://github.com/nineteendo","@type":"Person","name":"nineteendo"},"datePublished":"2024-04-17T08:02:43.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":8},"url":"https://github.com/117967/cpython/issues/117967"}