René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"PyType_GetModuleByDef family for binary functions performance","articleBody":"# Feature or enhancement\r\n\r\n### Proposal:\r\n\r\nWhen implementing an extension module with a module state enabled,\r\nbinary tp slot functions (e.g. `nb_add`) need two `PyType_GetModuleByDef()` to be used like the following to compare the given types with a heap-type object in the module state, which can be slow:\r\n\r\n```c\r\nstatic PyObject *\r\nfoo_add(PyObject *left, PyObject *right)\r\n{\r\n    ...\r\n    PyObject *module = PyType_GetModuleByDef(Py_TYPE(left), \u0026module_def);\r\n    if (module == NULL) {\r\n        PyErr_Clear();\r\n        module = PyType_GetModuleByDef(Py_TYPE(right), \u0026module_def);\r\n    }\r\n    ...\r\n}\r\n```\r\n\r\n* 3.13.0 alpha5 `_decimal` (module state ver.)\r\n\r\n```py\r\nfrom timeit import timeit\r\nf = lambda s: timeit(s, 'import _decimal; d = _decimal.Decimal(1)')\r\na = f('d + 1')\r\nb = f('1 + d')\r\nprint('d + 1:', a)\r\nprint('1 + d:', b,  b / a)\r\n```\r\n```\r\nd + 1: 0.11202071857405826\r\n1 + d: 0.49533294743326095 4.421797625818569\r\n```\r\nThe difference mainly comes from a `TypeError` emission from `PyType_GetModuleByDef()`, so it would be nice if we could have a new function which receives two types and emits an error after checking them.\r\n\r\ncc @encukou\r\n\r\n### Related issue:\r\n* #103092\r\n\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-117661\n* gh-123100\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/neonene","@type":"Person","name":"neonene"},"datePublished":"2024-04-06T09:30:54.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":9},"url":"https://github.com/117578/cpython/issues/117578"}