Title: configparser.RawConfigParser._read is unmanageably complex · Issue #117348 · python/cpython · GitHub
Open Graph Title: configparser.RawConfigParser._read is unmanageably complex · Issue #117348 · python/cpython
X Title: configparser.RawConfigParser._read is unmanageably complex · Issue #117348 · python/cpython
Description: From the review: This function is already unmanageably complex (and complexity checks disabled in the backport). Adding this single boolean parameter has expanded this function from ~120 lines to almost 160 and increases the mccabe cyclo...
Open Graph Description: From the review: This function is already unmanageably complex (and complexity checks disabled in the backport). Adding this single boolean parameter has expanded this function from ~120 lines to a...
X Description: From the review: This function is already unmanageably complex (and complexity checks disabled in the backport). Adding this single boolean parameter has expanded this function from ~120 lines to a...
Opengraph URL: https://github.com/python/cpython/issues/117348
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"configparser.RawConfigParser._read is unmanageably complex","articleBody":"From the review:\r\n\r\n> This function is already unmanageably complex (and complexity checks [disabled in the backport](https://github.com/jaraco/configparser/blob/b244f597d871a83986d5146ab49a4e7c19f8b528/backports/configparser/__init__.py#L1039)). Adding this single boolean parameter has expanded this function from ~120 lines to almost 160 and increases the mccabe cyclometric complexity of this function from 25 to 31 (where a target complexity is \u003c10).\r\n> \r\n> ```\r\n> cpython main @ pip-run mccabe -- -m mccabe --min 14 Lib/configparser.py\r\n> 940:4: 'RawConfigParser._read' 25\r\n> cpython main @ gh pr checkout 117273\r\n> Switched to branch 'unnamed-section'\r\n> cpython unnamed-section @ pip-run mccabe -- -m mccabe --min 14 Lib/configparser.py\r\n> 961:4: 'RawConfigParser._read' 31\r\n> ```\r\n\r\n_Originally posted by @jaraco in https://github.com/python/cpython/pull/117273#discussion_r1541849160_\r\n \n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-117372\n* gh-117703\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/jaraco","@type":"Person","name":"jaraco"},"datePublished":"2024-03-28T20:45:35Z","url":"https://github.com/python/cpython/issues/117348"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:3b09a02f-719b-f8b5-1058-e3dd022ae451 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | EB9A:2AF0D8:A03429:C8ACFE:6B021B38 |
| html-safe-nonce | 5c192efbd90000c4ec2929bd6b0bb360511d217531bae0ea49a66337b474320c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjlBOjJBRjBEODpBMDM0Mjk6QzhBQ0ZFOjZCMDIxQjM4IiwidmlzaXRvcl9pZCI6IjQ2OTczMDYyNTMzOTc5OTAyMDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d5237fc46ec94186c222941768fc030bd470533038c0a618544b3c8e6995e4fe |
| hovercard-subject-tag | issue:2214114012 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/117348/issue_layout |
| twitter:image | https://opengraph.githubassets.com/5eec8872192ad08e3191f3870f38650ba4adce60c262fe1b7af8801f11574482/python/cpython/issues/117348 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5eec8872192ad08e3191f3870f38650ba4adce60c262fe1b7af8801f11574482/python/cpython/issues/117348 |
| og:image:alt | From the review: This function is already unmanageably complex (and complexity checks disabled in the backport). Adding this single boolean parameter has expanded this function from ~120 lines to a... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jaraco |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width