René's URL Explorer Experiment


Title: configparser.RawConfigParser._read is unmanageably complex · Issue #117348 · python/cpython · GitHub

Open Graph Title: configparser.RawConfigParser._read is unmanageably complex · Issue #117348 · python/cpython

X Title: configparser.RawConfigParser._read is unmanageably complex · Issue #117348 · python/cpython

Description: From the review: This function is already unmanageably complex (and complexity checks disabled in the backport). Adding this single boolean parameter has expanded this function from ~120 lines to almost 160 and increases the mccabe cyclo...

Open Graph Description: From the review: This function is already unmanageably complex (and complexity checks disabled in the backport). Adding this single boolean parameter has expanded this function from ~120 lines to a...

X Description: From the review: This function is already unmanageably complex (and complexity checks disabled in the backport). Adding this single boolean parameter has expanded this function from ~120 lines to a...

Opengraph URL: https://github.com/python/cpython/issues/117348

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"configparser.RawConfigParser._read is unmanageably complex","articleBody":"From the review:\r\n\r\n> This function is already unmanageably complex (and complexity checks [disabled in the backport](https://github.com/jaraco/configparser/blob/b244f597d871a83986d5146ab49a4e7c19f8b528/backports/configparser/__init__.py#L1039)). Adding this single boolean parameter has expanded this function from ~120 lines to almost 160 and increases the mccabe cyclometric complexity of this function from 25 to 31 (where a target complexity is \u003c10).\r\n> \r\n> ```\r\n> cpython main @ pip-run mccabe -- -m mccabe --min 14 Lib/configparser.py\r\n> 940:4: 'RawConfigParser._read' 25\r\n>  cpython main @ gh pr checkout 117273\r\n> Switched to branch 'unnamed-section'\r\n>  cpython unnamed-section @ pip-run mccabe -- -m mccabe --min 14 Lib/configparser.py\r\n> 961:4: 'RawConfigParser._read' 31\r\n> ```\r\n\r\n_Originally posted by @jaraco in https://github.com/python/cpython/pull/117273#discussion_r1541849160_\r\n            \n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-117372\n* gh-117703\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/jaraco","@type":"Person","name":"jaraco"},"datePublished":"2024-03-28T20:45:35Z","url":"https://github.com/python/cpython/issues/117348"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:3b09a02f-719b-f8b5-1058-e3dd022ae451
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idEB9A:2AF0D8:A03429:C8ACFE:6B021B38
html-safe-nonce5c192efbd90000c4ec2929bd6b0bb360511d217531bae0ea49a66337b474320c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjlBOjJBRjBEODpBMDM0Mjk6QzhBQ0ZFOjZCMDIxQjM4IiwidmlzaXRvcl9pZCI6IjQ2OTczMDYyNTMzOTc5OTAyMDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd5237fc46ec94186c222941768fc030bd470533038c0a618544b3c8e6995e4fe
hovercard-subject-tagissue:2214114012
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/117348/issue_layout
twitter:imagehttps://opengraph.githubassets.com/5eec8872192ad08e3191f3870f38650ba4adce60c262fe1b7af8801f11574482/python/cpython/issues/117348
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5eec8872192ad08e3191f3870f38650ba4adce60c262fe1b7af8801f11574482/python/cpython/issues/117348
og:image:altFrom the review: This function is already unmanageably complex (and complexity checks disabled in the backport). Adding this single boolean parameter has expanded this function from ~120 lines to a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejaraco
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/117348#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F117348
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F117348
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/117348
Reloadhttps://github.com/python/cpython/issues/117348
Reloadhttps://github.com/python/cpython/issues/117348
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/117348
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/117348
configparser.RawConfigParser._read is unmanageably complexhttps://github.com/python/cpython/issues/117348#top
https://github.com/jaraco
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
triagedThe issue has been accepted as valid by a triager.https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22triaged%22
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
https://github.com/jaraco
jaracohttps://github.com/jaraco
on Mar 28, 2024https://github.com/python/cpython/issues/117348#issue-2214114012
disabled in the backporthttps://github.com/jaraco/configparser/blob/b244f597d871a83986d5146ab49a4e7c19f8b528/backports/configparser/__init__.py#L1039
@jaracohttps://github.com/jaraco
#117273 (comment)https://github.com/python/cpython/pull/117273#discussion_r1541849160
gh-117348: Refactored RawConfigParser._read for simplicity and comprehensibility #117372https://github.com/python/cpython/pull/117372
gh-117348: restore import time performance of configparser #117703https://github.com/python/cpython/pull/117703
jaracohttps://github.com/jaraco
on Mar 28, 2024https://github.com/python/cpython/issues/117348#event-12287406708
https://github.com/jaraco
jaracohttps://github.com/jaraco
on Mar 28, 2024https://github.com/python/cpython/issues/117348#issuecomment-2026088558
jaraco:feature/refactor-configparser-read-complexityhttps://github.com/jaraco/cpython/tree/feature/refactor-configparser-read-complexity
#117273https://github.com/python/cpython/pull/117273
jaracohttps://github.com/jaraco
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
triagedThe issue has been accepted as valid by a triager.https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22triaged%22
on Mar 28, 2024https://github.com/python/cpython/issues/117348#event-12287438481
jaracohttps://github.com/jaraco
on Mar 29, 2024https://github.com/python/cpython/issues/117348#event-12298081019
gh-117348: Refactored RawConfigParser._read for similicity and compre…https://github.com/python/cpython/commit/019143fecbfc26e69800d28d2a9e3392a051780b
gh-117348https://github.com/python/cpython/issues/117348
019143fhttps://github.com/python/cpython/commit/019143fecbfc26e69800d28d2a9e3392a051780b
jaracohttps://github.com/jaraco
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Mar 29, 2024https://github.com/python/cpython/issues/117348#event-12298087967
NGRsoftlabhttps://github.com/NGRsoftlab
on Apr 2, 2024https://github.com/python/cpython/issues/117348#event-12319260697
Squashed commit of the following:https://github.com/NGRsoftlab/cpython/commit/1b5fe4cad096e32efee3a0477ef6f277ec2a2b96
1b5fe4chttps://github.com/NGRsoftlab/cpython/commit/1b5fe4cad096e32efee3a0477ef6f277ec2a2b96
Squashed commit of the following:https://github.com/NGRsoftlab/cpython/commit/a016a5413a6d8bd02939a6fb9afef90dbbb2fb54
a016a54https://github.com/NGRsoftlab/cpython/commit/a016a5413a6d8bd02939a6fb9afef90dbbb2fb54
jaracohttps://github.com/jaraco
on Apr 14, 2024https://github.com/python/cpython/issues/117348#event-12460152637
gh-117348: restore import time performance of configparser (#117703)https://github.com/python/cpython/commit/9c93b7402ba11d1d68e856516e56ca72989a7db9
gh-117348https://github.com/python/cpython/issues/117348
#117703https://github.com/python/cpython/pull/117703
9c93b74https://github.com/python/cpython/commit/9c93b7402ba11d1d68e856516e56ca72989a7db9
diegorussohttps://github.com/diegorusso
on Apr 17, 2024https://github.com/python/cpython/issues/117348#event-12505754202
pythongh-117348: Refactored RawConfigParser._read for similicity and …https://github.com/diegorusso/cpython/commit/90d0eebce09a4fd219ee9db72d0c665e5ea70922
pythongh-117348https://github.com/python/cpython/issues/117348
90d0eebhttps://github.com/diegorusso/cpython/commit/90d0eebce09a4fd219ee9db72d0c665e5ea70922
pythongh-117348: restore import time performance of configparser (pyt…https://github.com/diegorusso/cpython/commit/fb65a6c403f5246ebc30a7a16e940891af820888
pythongh-117348https://github.com/python/cpython/issues/117348
pyt…https://github.com/python/cpython/pull/117703
fb65a6chttps://github.com/diegorusso/cpython/commit/fb65a6c403f5246ebc30a7a16e940891af820888
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/117348
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/117348
jaracohttps://github.com/jaraco
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
triagedThe issue has been accepted as valid by a triager.https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22triaged%22
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.