René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"pystats: #116206 (Incremental GC implementation) broke pystats build","articleBody":"# Bug report\n\n### Bug description:\n\nSince #116206 was merged, pystats builds are broken:\n\n```\ngcc -c -fno-strict-overflow -Wsign-compare -DNDEBUG -g -O3 -Wall    -std=c11 -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wstrict-prototypes -Werror=implicit-function-declaration -fvisibility=hidden  -I./Include/internal -I./Include/internal/mimalloc  -I. -I./Include    -DPy_BUILD_CORE -o Python/gc.o Python/gc.c\nIn file included from ./Include/internal/pycore_interp.h:16,\n                 from ./Include/internal/pycore_ceval.h:13,\n                 from Python/gc.c:6:\nPython/gc.c: In function ‘gc_collect_young’:\nPython/gc.c:1287:24: error: ‘GCStats’ {aka ‘struct _gc_stats’} has no member named ‘objects_queued’; did you mean ‘objects_collected’?\n 1287 |         GC_STAT_ADD(0, objects_queued, count);\n      |                        ^~~~~~~~~~~~~~\n./Include/internal/pycore_code.h:307:82: note: in definition of macro ‘GC_STAT_ADD’\n  307 | #define GC_STAT_ADD(gen, name, n) do { if (_Py_stats) _Py_stats-\u003egc_stats[(gen)].name += (n); } while (0)\n      |                                                                                  ^~~~\nPython/gc.c: In function ‘completed_cycle’:\nPython/gc.c:1387:16: warning: unused variable ‘not_visited’ [-Wunused-variable]\n 1387 |     PyGC_Head *not_visited = \u0026gcstate-\u003eold[gcstate-\u003evisited_space^1].head;\n      |                ^~~~~~~~~~~\nPython/gc.c: In function ‘gc_collect_increment’:\nPython/gc.c:1424:20: error: ‘GCStats’ {aka ‘struct _gc_stats’} has no member named ‘objects_queued’; did you mean ‘objects_collected’?\n 1424 |     GC_STAT_ADD(1, objects_queued, region_size);\n      |                    ^~~~~~~~~~~~~~\n./Include/internal/pycore_code.h:307:82: note: in definition of macro ‘GC_STAT_ADD’\n  307 | #define GC_STAT_ADD(gen, name, n) do { if (_Py_stats) _Py_stats-\u003egc_stats[(gen)].name += (n); } while (0)\n      |                                                                                  ^~~~\nPython/gc.c:1424:36: error: ‘region_size’ undeclared (first use in this function)\n 1424 |     GC_STAT_ADD(1, objects_queued, region_size);\n      |                                    ^~~~~~~~~~~\n./Include/internal/pycore_code.h:307:91: note: in definition of macro ‘GC_STAT_ADD’\n  307 | #define GC_STAT_ADD(gen, name, n) do { if (_Py_stats) _Py_stats-\u003egc_stats[(gen)].name += (n); } while (0)\n      |                                                                                           ^\nPython/gc.c:1424:36: note: each undeclared identifier is reported only once for each function it appears in\n 1424 |     GC_STAT_ADD(1, objects_queued, region_size);\n      |                                    ^~~~~~~~~~~\n./Include/internal/pycore_code.h:307:91: note: in definition of macro ‘GC_STAT_ADD’\n  307 | #define GC_STAT_ADD(gen, name, n) do { if (_Py_stats) _Py_stats-\u003egc_stats[(gen)].name += (n); } while (0)\n      |                                                                                           ^\nPython/gc.c: In function ‘_PyGC_Collect’:\nPython/gc.c:1810:9: error: ‘_py_stats’ undeclared (first use in this function); did you mean ‘_Py_stats’?\n 1810 |     if (_py_stats) {\n      |         ^~~~~~~~~\n      |         _Py_stats\nmake: *** [Makefile:2970: Python/gc.o] Error 1\n```\n\n### CPython versions tested on:\n\nCPython main branch\n\n### Operating systems tested on:\n\nLinux\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-117123\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/mdboom","@type":"Person","name":"mdboom"},"datePublished":"2024-03-21T13:27:27.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/117122/cpython/issues/117122"}