Title: Function version numbers do not obey necessary invariants · Issue #117086 · python/cpython · GitHub
Open Graph Title: Function version numbers do not obey necessary invariants · Issue #117086 · python/cpython
X Title: Function version numbers do not obey necessary invariants · Issue #117086 · python/cpython
Description: Bug report Bug description: It is a necessary invariant of version numbers that an equal version number means that the objects are equivalent. That is, all operations on the two objects will give the same result. This works for class and...
Open Graph Description: Bug report Bug description: It is a necessary invariant of version numbers that an equal version number means that the objects are equivalent. That is, all operations on the two objects will give t...
X Description: Bug report Bug description: It is a necessary invariant of version numbers that an equal version number means that the objects are equivalent. That is, all operations on the two objects will give t...
Opengraph URL: https://github.com/python/cpython/issues/117086
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Function version numbers do not obey necessary invariants","articleBody":"# Bug report\n\n### Bug description:\n\nIt is a necessary invariant of version numbers that an equal version number means that the objects are equivalent. That is, all operations on the two objects will give the same result.\n\nThis works for class and dict version numbers as no version number is shared between different objects and any change to the object results in a new version number.\n\nHowever, we share version numbers for functions and that causes problems. https://github.com/python/cpython/issues/117051\nWe have good reasons for sharing version numbers. It allows much better optimization of closures. https://github.com/python/cpython/pull/98525\n\nWant we want is a scheme that allows us to share version numbers, but preserves the invariant that the same function number means a function that is functionally identical.\n\nAssuming that the function version gets modified whenever the function version is modified, if we want to share versions we only need to ensure the invariant when creating a function.\nWe do not need to ensure that all functions that are functionally identical share a version, just enough to optimize most common cases.\n\nA function consists of the following fields that we care about when optimizing:\n* Code object\n* Globals\n* Builtins\n* Defaults (only the number, not the actual values)\n\nIt is `MAKE_FUNCTION` that is responsible for setting the version number., which we get only from the code object, meaning that if the globals, builtins or defaults differ from any other function with the same code object, the version number is invalid.\n\n\n\n\n\n\n\n\n\n\n\n\n\n### CPython versions tested on:\n\n3.13, CPython main branch\n\n### Operating systems tested on:\n\n_No response_\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-117093\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/markshannon","@type":"Person","name":"markshannon"},"datePublished":"2024-03-20T16:00:02.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/117086/cpython/issues/117086"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:3b5788f2-a745-262a-f791-aa87a1d424b0 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E6B8:3D4591:1E974E7:2C239DC:6A565954 |
| html-safe-nonce | abb291342ae32d7baf8ff77d553e084adb6c75800938f628a24ed7ac4be456de |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkI4OjNENDU5MToxRTk3NEU3OjJDMjM5REM6NkE1NjU5NTQiLCJ2aXNpdG9yX2lkIjoiNjE3OTQyNDczOTEwMDM1MDgwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 63dead24943907987a0b8ccc5cb1a176d8d9353280359471cbf78e24cc4e0e9a |
| hovercard-subject-tag | issue:2197910838 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/117086/issue_layout |
| twitter:image | https://opengraph.githubassets.com/48b31e72c27e47cfa564aca26f72cc62c3fead0686f7ac17c9249ba0cbdd6619/python/cpython/issues/117086 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/48b31e72c27e47cfa564aca26f72cc62c3fead0686f7ac17c9249ba0cbdd6619/python/cpython/issues/117086 |
| og:image:alt | Bug report Bug description: It is a necessary invariant of version numbers that an equal version number means that the objects are equivalent. That is, all operations on the two objects will give t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | markshannon |
| hostname | github.com |
| expected-hostname | github.com |
| None | cffc1b7eb44a3dbb1e61c2a0523cad1f04e0368d730bf85ac498c992baf19e7d |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 233d2274d9c68198aa6cb23d1db680b5c0b58bba |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width