René's URL Explorer Experiment


Title: Optimizer calls `getenv` on every optimization run · Issue #116772 · python/cpython · GitHub

Open Graph Title: Optimizer calls `getenv` on every optimization run · Issue #116772 · python/cpython

X Title: Optimizer calls `getenv` on every optimization run · Issue #116772 · python/cpython

Description: Bug report Bug description: The optimizer currently calls getenv during every optimization attempt. This has a small, but statistically significant 0.5% impact on performance. Do we need to do this each time, or could we read it to a fla...

Open Graph Description: Bug report Bug description: The optimizer currently calls getenv during every optimization attempt. This has a small, but statistically significant 0.5% impact on performance. Do we need to do this...

X Description: Bug report Bug description: The optimizer currently calls getenv during every optimization attempt. This has a small, but statistically significant 0.5% impact on performance. Do we need to do this...

Opengraph URL: https://github.com/python/cpython/issues/116772

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Optimizer calls `getenv` on every optimization run","articleBody":"# Bug report\n\n### Bug description:\n\nThe optimizer currently calls `getenv` during every optimization attempt.  This has a small, but [statistically significant 0.5% impact on performance](https://github.com/faster-cpython/benchmarking-public/blob/main/results/bm-20240313-3.13.0a5%2B-cb999fb-JIT/bm-20240313-linux-x86_64-mdboom-dont_getenv-3.13.0a5%2B-cb999fb-vs-base.png).  Do we need to do this each time, or could we read it to a flag during initialization?\n\n```diff\ndiff --git a/Python/optimizer.c b/Python/optimizer.c\nindex 88c45f2e73c..b55556d30ab 100644\n--- a/Python/optimizer.c\n+++ b/Python/optimizer.c\n@@ -1010,8 +1010,7 @@ uop_optimize(\n         return err;\n     }\n     OPT_STAT_INC(traces_created);\n-    char *env_var = Py_GETENV(\"PYTHON_UOPS_OPTIMIZE\");\n-    if (env_var == NULL || *env_var == '\\0' || *env_var > '0') {\n+    if (true) {\n         err = _Py_uop_analyze_and_optimize(frame, buffer,\n                                            UOP_MAX_TRACE_LENGTH,\n                                            curr_stackentries, &dependencies);\n```\n\n\n### CPython versions tested on:\n\nCPython main branch\n\n### Operating systems tested on:\n\nLinux\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-126439\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/mdboom","@type":"Person","name":"mdboom"},"datePublished":"2024-03-14T00:43:19Z","url":"https://github.com/python/cpython/issues/116772"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:c44399d7-155f-3fed-a6dd-a628f6941626
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8BAC:3A73AA:3A8E43A:4A237C3:6B02368A
html-safe-nonce220aafa0e8df0f327adfd99be16fd6771e59bc76d2bff04fdd813e18d9f85200
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QkFDOjNBNzNBQTozQThFNDNBOjRBMjM3QzM6NkIwMjM2OEEiLCJ2aXNpdG9yX2lkIjoiNTcyMTM1NTg3NzAxMzkyNzU2MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd4b33368b9ec10fb4e53c1d713792a2c1a869732fb21d18a760adfad7ebbc527
hovercard-subject-tagissue:2185163001
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/116772/issue_layout
twitter:imagehttps://opengraph.githubassets.com/f90d241e195523243a044e38b7a059723f2f1cef93a80503d95f43e17bb48991/python/cpython/issues/116772
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f90d241e195523243a044e38b7a059723f2f1cef93a80503d95f43e17bb48991/python/cpython/issues/116772
og:image:altBug report Bug description: The optimizer currently calls getenv during every optimization attempt. This has a small, but statistically significant 0.5% impact on performance. Do we need to do this...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemdboom
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/116772#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F116772
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F116772
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/116772
Reloadhttps://github.com/python/cpython/issues/116772
Reloadhttps://github.com/python/cpython/issues/116772
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/116772
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/116772
Optimizer calls getenv on every optimization runhttps://github.com/python/cpython/issues/116772#top
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
performancePerformance or resource usagehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22performance%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/mdboom
mdboomhttps://github.com/mdboom
on Mar 14, 2024https://github.com/python/cpython/issues/116772#issue-2185163001
statistically significant 0.5% impact on performancehttps://github.com/faster-cpython/benchmarking-public/blob/main/results/bm-20240313-3.13.0a5%2B-cb999fb-JIT/bm-20240313-linux-x86_64-mdboom-dont_getenv-3.13.0a5%2B-cb999fb-vs-base.png
gh-116772: Cache getenv result in optimizer.c to reduce calls #126439https://github.com/python/cpython/pull/126439
mdboomhttps://github.com/mdboom
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
performancePerformance or resource usagehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22performance%22
on Mar 14, 2024https://github.com/python/cpython/issues/116772#event-12110769326
https://github.com/ronaldoussoren
ronaldoussorenhttps://github.com/ronaldoussoren
on Mar 16, 2024https://github.com/python/cpython/issues/116772#issuecomment-2001925046
picnixzhttps://github.com/picnixz
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
on Nov 6, 2024https://github.com/python/cpython/issues/116772#event-15150609893
https://github.com/savannahostrowski
savannahostrowskihttps://github.com/savannahostrowski
on Jan 23, 2026https://github.com/python/cpython/issues/116772#issuecomment-3791457637
#144082https://github.com/python/cpython/pull/144082
savannahostrowskihttps://github.com/savannahostrowski
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jan 23, 2026https://github.com/python/cpython/issues/116772#event-22249004531
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/116772
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/116772
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
performancePerformance or resource usagehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22performance%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.