René's URL Explorer Experiment


Title: `test_walk_above_recursion_limit` uses absolute limits · Issue #116057 · python/cpython · GitHub

Open Graph Title: `test_walk_above_recursion_limit` uses absolute limits · Issue #116057 · python/cpython

X Title: `test_walk_above_recursion_limit` uses absolute limits · Issue #116057 · python/cpython

Description: Bug report Bug description: os.walk and Path.walk both have a test verifying that they're not implemented recursively. However, their recursion limits are absolute rather than relative to the current frame. Since the test framework itsel...

Open Graph Description: Bug report Bug description: os.walk and Path.walk both have a test verifying that they're not implemented recursively. However, their recursion limits are absolute rather than relative to the curre...

X Description: Bug report Bug description: os.walk and Path.walk both have a test verifying that they're not implemented recursively. However, their recursion limits are absolute rather than relative to the c...

Opengraph URL: https://github.com/python/cpython/issues/116057

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`test_walk_above_recursion_limit` uses absolute limits","articleBody":"# Bug report\r\n\r\n### Bug description:\r\n\r\n`os.walk` and `Path.walk` both have a test verifying that they're not implemented recursively. However, their recursion limits are absolute rather than relative to the current frame. Since the test framework itself already consumes about 30 frames, it only takes a few extra frames to cause a spurious failure. This can easily happen when running the tests within another script, which happens in the Android testbed.\r\n\r\nFor example, if the limit in test_pathlib is reduced from 40 to 35:\r\n\r\n```\r\n======================================================================\r\nERROR: test_walk_above_recursion_limit (test.test_pathlib.test_pathlib.PosixPathTest.test_walk_above_recursion_limit)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/Users/msmith/git/python/cpython/Lib/pathlib/__init__.py\", line 241, in __str__\r\n    return self._str\r\n           ^^^^^^^^^\r\nAttributeError: 'PosixPath' object has no attribute '_str'\r\n\r\nDuring handling of the above exception, another exception occurred:\r\n\r\nTraceback (most recent call last):\r\n  File \"/Users/msmith/git/python/cpython/Lib/pathlib/__init__.py\", line 300, in drive\r\n    return self._drv\r\n           ^^^^^^^^^\r\nAttributeError: 'PosixPath' object has no attribute '_drv'\r\n\r\nDuring handling of the above exception, another exception occurred:\r\n\r\nTraceback (most recent call last):\r\n  File \"/Users/msmith/git/python/cpython/Lib/test/test_pathlib/test_pathlib.py\", line 1203, in test_walk_above_recursion_limit\r\n    list(base.walk())\r\n    ~~~~^^^^^^^^^^^^^\r\n  File \"/Users/msmith/git/python/cpython/Lib/pathlib/_abc.py\", line 875, in walk\r\n    scandir_obj = path._scandir()\r\n                  ~~~~~~~~~~~~~^^\r\n  File \"/Users/msmith/git/python/cpython/Lib/pathlib/__init__.py\", line 588, in _scandir\r\n    return os.scandir(self)\r\n           ~~~~~~~~~~^^^^^^\r\n  File \"/Users/msmith/git/python/cpython/Lib/pathlib/__init__.py\", line 177, in __fspath__\r\n    return str(self)\r\n           ~~~^^^^^^\r\n  File \"/Users/msmith/git/python/cpython/Lib/pathlib/__init__.py\", line 243, in __str__\r\n    self._str = self._format_parsed_parts(self.drive, self.root,\r\n                                          ^^^^^^^^^^\r\n  File \"/Users/msmith/git/python/cpython/Lib/pathlib/__init__.py\", line 302, in drive\r\n    self._drv, self._root, self._tail_cached = self._parse_path(self._raw_path)\r\n                                                                ^^^^^^^^^^^^^^\r\n  File \"/Users/msmith/git/python/cpython/Lib/pathlib/__init__.py\", line 293, in _raw_path\r\n    path = self.pathmod.join(*paths)\r\n           ~~~~~~~~~~~~~~~~~^^^^^^^^\r\n  File \"\u003cfrozen posixpath\u003e\", line 77, in join\r\nRecursionError: maximum recursion depth exceeded\r\n```\r\n\r\n\r\n### CPython versions tested on:\r\n\r\nCPython main branch\r\n\r\n### Operating systems tested on:\r\n\r\n* macOS\r\n* Android\r\n\r\n\u003c!-- gh-linked-prs --\u003e\r\n### Linked PRs\r\n* gh-116058\r\n\u003c!-- /gh-linked-prs --\u003e\r\n","author":{"url":"https://github.com/mhsmith","@type":"Person","name":"mhsmith"},"datePublished":"2024-02-28T17:48:20.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/116057/cpython/issues/116057"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:e3d30728-1d45-eacf-2f26-ffdf1d3fd292
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idAFEC:275F42:153E38E:1D2EFCC:696AA4BF
html-safe-nonce2d618ea35f4889f22e66766cefcf2c8fc072944bd3e386d733a7d6823a759f87
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRkVDOjI3NUY0MjoxNTNFMzhFOjFEMkVGQ0M6Njk2QUE0QkYiLCJ2aXNpdG9yX2lkIjoiNDUxMzUzNzI2ODYzNDAwMjYyMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac744530e4608d3cca8180e8f21555dbe4fbcced29174777e775b7aa6dcf83fd84
hovercard-subject-tagissue:2159503423
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/116057/issue_layout
twitter:imagehttps://opengraph.githubassets.com/bce44a3cce1c26c47101ed33baf749ad912492a653149c912539294174424f45/python/cpython/issues/116057
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bce44a3cce1c26c47101ed33baf749ad912492a653149c912539294174424f45/python/cpython/issues/116057
og:image:altBug report Bug description: os.walk and Path.walk both have a test verifying that they're not implemented recursively. However, their recursion limits are absolute rather than relative to the curre...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemhsmith
hostnamegithub.com
expected-hostnamegithub.com
Nonea51f97dbb9326f71c08ecb61577457d543c602124d1a2672871258ef37ac5261
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4bd0eac606c70914085176ef312ebdcd97a8cdf1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/116057#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F116057
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F116057
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/116057
Reloadhttps://github.com/python/cpython/issues/116057
Reloadhttps://github.com/python/cpython/issues/116057
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/116057
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/issues/116057
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/116057
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/116057
#116058https://github.com/python/cpython/pull/116058
test_walk_above_recursion_limit uses absolute limitshttps://github.com/python/cpython/issues/116057#top
#116058https://github.com/python/cpython/pull/116058
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/mhsmith
https://github.com/mhsmith
mhsmithhttps://github.com/mhsmith
on Feb 28, 2024https://github.com/python/cpython/issues/116057#issue-2159503423
gh-116057: Use relative recursion limits when testing os.walk and Path.walk #116058https://github.com/python/cpython/pull/116058
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.