Title: 3.12 starts to return an error when all tests in a test file are skipped · Issue #113661 · python/cpython · GitHub
Open Graph Title: 3.12 starts to return an error when all tests in a test file are skipped · Issue #113661 · python/cpython
X Title: 3.12 starts to return an error when all tests in a test file are skipped · Issue #113661 · python/cpython
Description: Bug report Bug description: See https://github.com/apache/thrift/blob/5cf71b2beec3c67a4c8452ddabbbc6ae43fff16f/lib/py/test/test_sslsocket.py for a full example, we skipped all tests in that file via: @unittest.skip("failing SSL test to b...
Open Graph Description: Bug report Bug description: See https://github.com/apache/thrift/blob/5cf71b2beec3c67a4c8452ddabbbc6ae43fff16f/lib/py/test/test_sslsocket.py for a full example, we skipped all tests in that file vi...
X Description: Bug report Bug description: See https://github.com/apache/thrift/blob/5cf71b2beec3c67a4c8452ddabbbc6ae43fff16f/lib/py/test/test_sslsocket.py for a full example, we skipped all tests in that file vi...
Opengraph URL: https://github.com/python/cpython/issues/113661
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"3.12 starts to return an error when all tests in a test file are skipped","articleBody":"# Bug report\n\n### Bug description:\n\nSee https://github.com/apache/thrift/blob/5cf71b2beec3c67a4c8452ddabbbc6ae43fff16f/lib/py/test/test_sslsocket.py for a full example, we skipped all tests in that file via:\n\n```python\n@unittest.skip(\"failing SSL test to be fixed in subsequent pull request\")\nclass TSSLSocketTest(unittest.TestCase):\n ...\n```\n\nOn python 3.11 this is fine with:\n\n```\n/usr/bin/python3 test/test_sslsocket.py\nsssssssssss\n----------------------------------------------------------------------\nRan 11 tests in 0.000s\n\nOK (skipped=11)\n```\n\nBut on python 3.12, this starts to become an error:\n\n```\n/opt/hostedtoolcache/Python/3.12.1/x64/bin/python test/test_sslsocket.py\nWARNING:thrift.transport.sslcompat:using legacy validation callback\nsssssssssss\n----------------------------------------------------------------------\nRan 0 tests in 0.000s\n\nNO TESTS RAN (skipped=11)\nmake[1]: *** [Makefile:645: py3-test] Error 5\n```\n\nI have to add a not-skipped dummy test to work around this (https://github.com/apache/thrift/pull/2914/files)\n\nIs this an intentional change? I found it weird that we consider a skipped test as a failure.\n\n### CPython versions tested on:\n\n3.12\n\n### Operating systems tested on:\n\nLinux\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-113856\n* gh-113875\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/fishy","@type":"Person","name":"fishy"},"datePublished":"2024-01-02T18:15:09.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":17},"url":"https://github.com/113661/cpython/issues/113661"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:2d532fca-172b-d0c3-b507-caa034c62ab0 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 97BC:D449A:21EEC3A:2C109AF:696B4ECA |
| html-safe-nonce | 95bd1dd177aad4dd8d205d9f46f42c82daa133cb4c2e22226e8fcc390d13b7ce |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5N0JDOkQ0NDlBOjIxRUVDM0E6MkMxMDlBRjo2OTZCNEVDQSIsInZpc2l0b3JfaWQiOiI0NDA5MjkzNjczNzQ5MDkxMzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 9f573d194c2ec2aad657338993564b3fc62f9b67000dcdaada103da550a7c73d |
| hovercard-subject-tag | issue:2062777439 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/113661/issue_layout |
| twitter:image | https://opengraph.githubassets.com/12deff4cb1b4cd5606fbe718b127783ae14993894ab6db2f0daede2cd272303d/python/cpython/issues/113661 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/12deff4cb1b4cd5606fbe718b127783ae14993894ab6db2f0daede2cd272303d/python/cpython/issues/113661 |
| og:image:alt | Bug report Bug description: See https://github.com/apache/thrift/blob/5cf71b2beec3c67a4c8452ddabbbc6ae43fff16f/lib/py/test/test_sslsocket.py for a full example, we skipped all tests in that file vi... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | fishy |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width