René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Should typing be calling getattr on arbitrary classes? ","articleBody":"# Bug report\r\n\r\n### Bug description:\r\n\r\nI was updating my CI to support python3.12 and ran into the following error that isn't present in the 3.12 builds https://github.com/Gobot1234/steam.py/actions/runs/7276342755/job/19825996032\r\n\r\nMRE:\r\n```python\r\nfrom enum import IntEnum\r\nfrom typing import Protocol\r\n\r\nclass classproperty:\r\n    def __init__(self, func):\r\n        self.__func__ = func\r\n\r\n    def __get__(self, instance, type):\r\n        return self.__func__(type)\r\n\r\nclass _CommentThreadType(IntEnum):\r\n    WorkshopAccountDeveloper = 2\r\n\r\nclass Commentable(Protocol):\r\n    @classproperty\r\n    def _COMMENTABLE_TYPE(cls):\r\n        return _CommentThreadType[cls.__name__]\r\n```\r\n\r\nTraceback on `main`:\r\n\r\n```pytb\r\nRunning Debug|x64 interpreter...\r\nTraceback (most recent call last):\r\n  File \"C:\\Users\\alexw\\coding\\test_protocol.py\", line 14, in \u003cmodule\u003e\r\n    class Commentable(Protocol):\r\n    ...\u003c2 lines\u003e...\r\n            return _CommentThreadType[cls.__name__]\r\n  File \"C:\\Users\\alexw\\coding\\cpython\\Lib\\typing.py\", line 1838, in __init__\r\n    cls.__callable_proto_members_only__ = all(\r\n                                          ~~~^\r\n        callable(getattr(cls, attr, None)) for attr in cls.__protocol_attrs__\r\n        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n    )\r\n    ^\r\n  File \"C:\\Users\\alexw\\coding\\cpython\\Lib\\typing.py\", line 1839, in \u003cgenexpr\u003e\r\n    callable(getattr(cls, attr, None)) for attr in cls.__protocol_attrs__\r\n             ~~~~~~~^^^^^^^^^^^^^^^^^\r\n  File \"C:\\Users\\alexw\\coding\\test_protocol.py\", line 9, in __get__\r\n    return self.__func__(type)\r\n           ~~~~~~~~~~~~~^^^^^^\r\n  File \"C:\\Users\\alexw\\coding\\test_protocol.py\", line 17, in _COMMENTABLE_TYPE\r\n    return _CommentThreadType[cls.__name__]\r\n           ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^\r\n  File \"C:\\Users\\alexw\\coding\\cpython\\Lib\\enum.py\", line 763, in __getitem__\r\n    return cls._member_map_[name]\r\n           ~~~~~~~~~~~~~~~~^^^^^^\r\nKeyError: 'Commentable'\r\n```\r\n\r\n\r\nShould typing be more careful about accessing random attributes on classes to prevent these kinds of errors in the future?\r\n\r\n### CPython versions tested on:\r\n\r\n3.12\r\n\r\n### Operating systems tested on:\r\n\r\nmacOS\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-113401\n* gh-113722\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/Gobot1234","@type":"Person","name":"Gobot1234"},"datePublished":"2023-12-20T14:50:35.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":9},"url":"https://github.com/113320/cpython/issues/113320"}