René's URL Explorer Experiment


Title: Useless code block in math.trunc() ? · Issue #111417 · python/cpython · GitHub

Open Graph Title: Useless code block in math.trunc() ? · Issue #111417 · python/cpython

X Title: Useless code block in math.trunc() ? · Issue #111417 · python/cpython

Description: Bug report Bug description: The math.trunc function has: cpython/Modules/mathmodule.c Lines 2073 to 2076 in f013b47 if (!_PyType_IsReady(Py_TYPE(x))) { if (PyType_Ready(Py_TYPE(x)) < 0) return NULL; } c.f. math.ceil or math.floor. This s...

Open Graph Description: Bug report Bug description: The math.trunc function has: cpython/Modules/mathmodule.c Lines 2073 to 2076 in f013b47 if (!_PyType_IsReady(Py_TYPE(x))) { if (PyType_Ready(Py_TYPE(x)) < 0) return NULL...

X Description: Bug report Bug description: The math.trunc function has: cpython/Modules/mathmodule.c Lines 2073 to 2076 in f013b47 if (!_PyType_IsReady(Py_TYPE(x))) { if (PyType_Ready(Py_TYPE(x)) < 0) return N...

Opengraph URL: https://github.com/python/cpython/issues/111417

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Useless code block in math.trunc() ?","articleBody":"# Bug report\n\n### Bug description:\n\nThe math.trunc function has:\nhttps://github.com/python/cpython/blob/f013b475047b2e9d377feda9f2e16e5cdef824d7/Modules/mathmodule.c#L2073-L2076\nc.f. [math.ceil](https://github.com/python/cpython/blob/f013b475047b2e9d377feda9f2e16e5cdef824d7/Modules/mathmodule.c#L1124-L1148) or [math.floor](https://github.com/python/cpython/blob/f013b475047b2e9d377feda9f2e16e5cdef824d7/Modules/mathmodule.c#L1193-L1217).\n\nThis seems to be a history artifact: the function was introduced in https://github.com/python/cpython/commit/400adb030a78c3fcb1eb458b25c990449fbf3c93 as a moved __builtins__.trunc(), while math.ceil/floor were here from the initial revision.\n\nI think it's safe to remove mentioned block.\n\nPS: Issue opened per @serhiy-storchaka suggestion in #110000.\n\n### CPython versions tested on:\n\nCPython main branch\n\n### Operating systems tested on:\n\n_No response_\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-111454\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/skirpichev","@type":"Person","name":"skirpichev"},"datePublished":"2023-10-28T01:44:01.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/111417/cpython/issues/111417"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:99b6345e-6b46-988a-5523-ad52c29bdf57
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id89A0:247E0C:27334CE:35306F7:696ADC71
html-safe-noncef1dcf2f2c9f1ab742c01a73659956a1e28ceb14436801915f750fdaf71379e8c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OUEwOjI0N0UwQzoyNzMzNENFOjM1MzA2Rjc6Njk2QURDNzEiLCJ2aXNpdG9yX2lkIjoiMjY2MTc0NTgyMzg1NzY5NTg1NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccebe73f39d959cbf277167335eeef07a1495d75804c63c9c5386eb60a91aebf6
hovercard-subject-tagissue:1966356804
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/111417/issue_layout
twitter:imagehttps://opengraph.githubassets.com/cbb0e9bbeb1ca03210ee947187d5b206478bdde4f8f364392a93fc0ba1c7d3d1/python/cpython/issues/111417
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cbb0e9bbeb1ca03210ee947187d5b206478bdde4f8f364392a93fc0ba1c7d3d1/python/cpython/issues/111417
og:image:altBug report Bug description: The math.trunc function has: cpython/Modules/mathmodule.c Lines 2073 to 2076 in f013b47 if (!_PyType_IsReady(Py_TYPE(x))) { if (PyType_Ready(Py_TYPE(x)) < 0) return NULL...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameskirpichev
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release524a93f2c1f36522a3b4be4c110467ee4172245d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/111417#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F111417
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F111417
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/111417
Reloadhttps://github.com/python/cpython/issues/111417
Reloadhttps://github.com/python/cpython/issues/111417
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/111417
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/issues/111417
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/111417
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/111417
Useless code block in math.trunc() ?https://github.com/python/cpython/issues/111417#top
extension-modulesC modules in the Modules dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22extension-modules%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/skirpichev
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
on Oct 28, 2023https://github.com/python/cpython/issues/111417#issue-1966356804
cpython/Modules/mathmodule.chttps://github.com/python/cpython/blob/f013b475047b2e9d377feda9f2e16e5cdef824d7/Modules/mathmodule.c#L2073-L2076
f013b47https://github.com/python/cpython/commit/f013b475047b2e9d377feda9f2e16e5cdef824d7
math.ceilhttps://github.com/python/cpython/blob/f013b475047b2e9d377feda9f2e16e5cdef824d7/Modules/mathmodule.c#L1124-L1148
math.floorhttps://github.com/python/cpython/blob/f013b475047b2e9d377feda9f2e16e5cdef824d7/Modules/mathmodule.c#L1193-L1217
400adb0https://github.com/python/cpython/commit/400adb030a78c3fcb1eb458b25c990449fbf3c93
@serhiy-storchakahttps://github.com/serhiy-storchaka
#110000https://github.com/python/cpython/pull/110000
gh-111417: Remove unused code block in math.trunc() and builtin_round_impl #111454https://github.com/python/cpython/pull/111454
extension-modulesC modules in the Modules dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22extension-modules%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.