Title: Typo in math_sumprod_impl() · Issue #111342 · python/cpython · GitHub
Open Graph Title: Typo in math_sumprod_impl() · Issue #111342 · python/cpython
X Title: Typo in math_sumprod_impl() · Issue #111342 · python/cpython
Description: cpython/Modules/mathmodule.c Line 2835 in 3f84a19 } else if (q_type_float && (PyLong_CheckExact(p_i) || PyBool_Check(q_i))) { Obviously, should be p_i in the last OR operand, c.f. L2824. Factored out from #110000. I think this should be ...
Open Graph Description: cpython/Modules/mathmodule.c Line 2835 in 3f84a19 } else if (q_type_float && (PyLong_CheckExact(p_i) || PyBool_Check(q_i))) { Obviously, should be p_i in the last OR operand, c.f. L2824. Factored o...
X Description: cpython/Modules/mathmodule.c Line 2835 in 3f84a19 } else if (q_type_float && (PyLong_CheckExact(p_i) || PyBool_Check(q_i))) { Obviously, should be p_i in the last OR operand, c.f. L2824. Fa...
Opengraph URL: https://github.com/python/cpython/issues/111342
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Typo in math_sumprod_impl()","articleBody":"https://github.com/python/cpython/blob/3f84a19e6291db682fc9a570e7612e80e2ffbbb5/Modules/mathmodule.c#L2835\r\nObviously, should be ``p_i`` in the last OR operand, c.f. [L2824](https://github.com/python/cpython/blob/3f84a19e6291db682fc9a570e7612e80e2ffbbb5/Modules/mathmodule.c#L2824).\r\n\r\nFactored out from #110000. I think this should be fixed regardless on the fate of that pr. 052d7de867 has also simple test for this if.\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-111416\n* gh-111419\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/skirpichev","@type":"Person","name":"skirpichev"},"datePublished":"2023-10-26T04:58:44.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/111342/cpython/issues/111342"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:f591fbf4-f544-586e-1164-64cfce0405a6 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 899C:22F52E:1646E02:1E88F39:696AA755 |
| html-safe-nonce | c53422241d84834238c1265a69ff072ba09f0c55b1046a13bd36d3e715f5b754 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTlDOjIyRjUyRToxNjQ2RTAyOjFFODhGMzk6Njk2QUE3NTUiLCJ2aXNpdG9yX2lkIjoiMzUwNTcxOTQ1NjAwNjA1NTc2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9cea92ec527beb5cbb6e242531820eb3c05df5144ad53eff3ce6456fe2135518 |
| hovercard-subject-tag | issue:1962706151 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/111342/issue_layout |
| twitter:image | https://opengraph.githubassets.com/b48ee9ee18d7f381d17681f05e1c5c90ffc145c021cc388c9218bc6d05acdeab/python/cpython/issues/111342 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b48ee9ee18d7f381d17681f05e1c5c90ffc145c021cc388c9218bc6d05acdeab/python/cpython/issues/111342 |
| og:image:alt | cpython/Modules/mathmodule.c Line 2835 in 3f84a19 } else if (q_type_float && (PyLong_CheckExact(p_i) || PyBool_Check(q_i))) { Obviously, should be p_i in the last OR operand, c.f. L2824. Factored o... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | skirpichev |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3eaf9b8cf1badcd7041a8ad480b9d9b28bea0ef1cc821ca9ff20f2cc7f4fe4b9 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | dd9a979046e6382bd084e2bd873bf65f797125ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width