Title: `_ssl.c` does not handle errors on module creation · Issue #111230 · python/cpython · GitHub
Open Graph Title: `_ssl.c` does not handle errors on module creation · Issue #111230 · python/cpython
X Title: `_ssl.c` does not handle errors on module creation · Issue #111230 · python/cpython
Description: Bug report sslmodule_init_constants does not return -1 when any of PyModule_Add* calls fail. For example, PyModule_AddIntConstant returns -1 on error, but it is never checked: cpython/Modules/_ssl.c Lines 5790 to 5831 in 96cbd1e PyModule...
Open Graph Description: Bug report sslmodule_init_constants does not return -1 when any of PyModule_Add* calls fail. For example, PyModule_AddIntConstant returns -1 on error, but it is never checked: cpython/Modules/_ssl....
X Description: Bug report sslmodule_init_constants does not return -1 when any of PyModule_Add* calls fail. For example, PyModule_AddIntConstant returns -1 on error, but it is never checked: cpython/Modules/_ssl....
Opengraph URL: https://github.com/python/cpython/issues/111230
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`_ssl.c` does not handle errors on module creation","articleBody":"# Bug report\n\n`sslmodule_init_constants` does not return `-1` when any of `PyModule_Add*` calls fail.\n\nFor example, `PyModule_AddIntConstant` returns `-1` on error, but it is never checked:\n\nhttps://github.com/python/cpython/blob/96cbd1e1db3447a33e5cc5cc2886ce79b61cc6eb/Modules/_ssl.c#L5790-L5831\n\nOther ``sslmodule_init_*` functions do check for errors correctly.\nI have a PR ready.\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-111232\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/sobolevn","@type":"Person","name":"sobolevn"},"datePublished":"2023-10-23T19:39:57.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/111230/cpython/issues/111230"}| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:a4f199f3-da22-b1f4-a05d-cf3ebd09c7eb |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | AADE:388B78:B7DA20:ED8529:696AFBC7 |
| html-safe-nonce | 60740eea5b0644b7cc8a869f2182e3c8e502954b422bc60cf94cc892381ad78f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQURFOjM4OEI3ODpCN0RBMjA6RUQ4NTI5OjY5NkFGQkM3IiwidmlzaXRvcl9pZCI6IjQ3OTk2NTk1NTAyODI4MDgyNjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 63ee8ef93f12cb577feda490d945a081c902c1d3a8d30e68b50889cfd6499b5b |
| hovercard-subject-tag | issue:1957898053 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/111230/issue_layout |
| twitter:image | https://opengraph.githubassets.com/14832d3fcab37d1a02cb9e1c4c7da1e61761dde0629f344b58c6496bcc85a7c6/python/cpython/issues/111230 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/14832d3fcab37d1a02cb9e1c4c7da1e61761dde0629f344b58c6496bcc85a7c6/python/cpython/issues/111230 |
| og:image:alt | Bug report sslmodule_init_constants does not return -1 when any of PyModule_Add* calls fail. For example, PyModule_AddIntConstant returns -1 on error, but it is never checked: cpython/Modules/_ssl.... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sobolevn |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width