René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Run ruff on Argument Clinic in CI","articleBody":"# Feature or enhancement\n\n### Proposal:\n\nAs @erlend-aasland and I have worked on adding type hints to Argument Clinic over the last few months, and applied various other modernisations to `Tools/clinic/`, running pyflakes on the code on a regular basis has caught numerous small bugs that periodically crept in due to a refactoring. Pyflakes has an _extremely_ low number of false positives, so it would be great to have this run as part of CI to catch these issues _before_ they're merged in.\n\nFollowing #109161, we now run `ruff` in CI on the `Lib/test/` directory, and ruff has implementations of all the pyflakes error codes. I propose that we add a CI check that runs the full set of pyflakes checks (via ruff) on `Tools/clinic/`.\n\n### Has this already been discussed elsewhere?\n\nThis is a minor feature, which does not need previous discussion elsewhere\n\n### Links to previous discussion of this feature:\n\n_No response_\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-110559\n* gh-110598\n* gh-110603\n* gh-110609\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/AlexWaygood","@type":"Person","name":"AlexWaygood"},"datePublished":"2023-10-09T12:03:35.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/110558/cpython/issues/110558"}