René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Improve CAPI tests of `set` and `frozenset`","articleBody":"# Feature or enhancement\n\nRight now CAPI tests of `set` and `frozenset` are quite outdated. They are defined as `.test_c_api` method on `set` objects, when `Py_DEBUG` is set:\n\nhttps://github.com/python/cpython/blob/7e30821b17b56bb5ed9799f62eb45e448cb52c8e/Objects/setobject.c#L2371-L2511\n\nThere are several things that I can see as problematic:\n- It is stored together with the production code\n- These tests are mixing CAPI (`PySet_Check`), internal CAPI (`_PySet_Update`), and internal function calls (`set_clear_internal`)\n- These tests are hard to parametrize since they are called as \n\nhttps://github.com/python/cpython/blob/7e30821b17b56bb5ed9799f62eb45e448cb52c8e/Lib/test/test_set.py#L638-L641\n\n- Multiple things are not tested: like `set` and `frozenset` subclasses\n- Test failures are not quite informative, because using C `assert`\n- This is a single huge test\n- This test is only run under debug builds and not under \"release\" builds\n\nI propose a plan to improve it:\n- [x] Move CAPI tests to `Modules/_testcapi/set.c` and add `Lib/test/test_capi/test_set.py`\n- [x] Move internal CAPI tests `Modules/_testinternalcapi/set.c` and make sure that they are executed in `test_capi.py`\n- [x] Delete `test_c_api` from `setobject.c`\n\nI plan to work on this and already have the PR for `1.` :)\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-110526\n* gh-110544\n* gh-110547\n* gh-110554\n* gh-110630\n* gh-110688\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/sobolevn","@type":"Person","name":"sobolevn"},"datePublished":"2023-10-08T20:21:17.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/110525/cpython/issues/110525"}