René's URL Explorer Experiment


Title: os.process_cpu_count(): get the number CPUs usable by the current process · Issue #109649 · python/cpython · GitHub

Open Graph Title: os.process_cpu_count(): get the number CPUs usable by the current process · Issue #109649 · python/cpython

X Title: os.process_cpu_count(): get the number CPUs usable by the current process · Issue #109649 · python/cpython

Description: Feature or enhancement os.cpu_count() returns the total number of CPUs that the current machine has. On Unix, sched_setaffinity() can reduce the number of CPU "usable" by a process. Currently, os.cpu_count() docstring contains a recipe h...

Open Graph Description: Feature or enhancement os.cpu_count() returns the total number of CPUs that the current machine has. On Unix, sched_setaffinity() can reduce the number of CPU "usable" by a process. Currently, os.c...

X Description: Feature or enhancement os.cpu_count() returns the total number of CPUs that the current machine has. On Unix, sched_setaffinity() can reduce the number of CPU "usable" by a process. Curre...

Opengraph URL: https://github.com/python/cpython/issues/109649

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"os.process_cpu_count(): get the number CPUs usable by the current process","articleBody":"# Feature or enhancement\r\n\r\nos.cpu_count() returns the total number of CPUs that the current machine has. On Unix, sched_setaffinity() can reduce the number of CPU \"usable\" by a process. Currently, os.cpu_count() docstring contains a recipe how to get the number of usable CPUs:\r\n\r\n```\r\n>>> import os; help(os.cpu_count)\r\ncpu_count()\r\n    Return the number of CPUs in the system; return None if indeterminable.\r\n    \r\n    This number is not equivalent to the number of CPUs the current process can\r\n    use.  The number of usable CPUs can be obtained with\r\n    ``len(os.sched_getaffinity(0))``\r\n```\r\n\r\nI propose to add an *affinity* optional keyword-only parameter to os.cpu_count() which would return ``len(os.sched_getaffinity(0))``.st\r\n\r\n**UPDATE:** Rename *usable* parameter to *affinity*.\r\n\r\n\u003c!-- gh-linked-prs -->\r\n### Linked PRs\r\n* gh-109652\r\n* gh-109907\n* gh-110165\n* gh-110169\n* gh-110226\n* gh-111689\n\u003c!-- /gh-linked-prs -->\r\n","author":{"url":"https://github.com/vstinner","@type":"Person","name":"vstinner"},"datePublished":"2023-09-21T14:14:27Z","url":"https://github.com/python/cpython/issues/109649"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:70a6f16c-cc8f-1a53-1005-d09e089d021c
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8718:E9D16:4257FED:53F4CA6:6B025CE3
html-safe-noncec0f061ccb3c72166162b6616a8a83a0fc7fa48b62c22a4b6a52fb7946a257abc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NzE4OkU5RDE2OjQyNTdGRUQ6NTNGNENBNjo2QjAyNUNFMyIsInZpc2l0b3JfaWQiOiI4MDY2OTIzNjAwMzY3MDM0NTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5740955ed36c5c5f7f4a94aabc7fc2b151411f26dd8c3fb304c0a87e90dd01b0
hovercard-subject-tagissue:1907086887
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/109649/issue_layout
twitter:imagehttps://opengraph.githubassets.com/b38ebeffd55a3fc7bf25be28cafd8f0a97e75fe5f8cd605aabbe72235242fe7f/python/cpython/issues/109649
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b38ebeffd55a3fc7bf25be28cafd8f0a97e75fe5f8cd605aabbe72235242fe7f/python/cpython/issues/109649
og:image:altFeature or enhancement os.cpu_count() returns the total number of CPUs that the current machine has. On Unix, sched_setaffinity() can reduce the number of CPU "usable" by a process. Currently, os.c...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevstinner
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/109649#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F109649
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F109649
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/109649
Reloadhttps://github.com/python/cpython/issues/109649
Reloadhttps://github.com/python/cpython/issues/109649
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/109649
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/109649
os.process_cpu_count(): get the number CPUs usable by the current processhttps://github.com/python/cpython/issues/109649#top
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
on Sep 21, 2023https://github.com/python/cpython/issues/109649#issue-1907086887
gh-109649: Add affinity parameter to os.cpu_count() #109652https://github.com/python/cpython/pull/109652
gh-109649: Add os.process_cpu_count() function #109907https://github.com/python/cpython/pull/109907
gh-109649: Use os.process_cpu_count() #110165https://github.com/python/cpython/pull/110165
[3.12] gh-109649: Enhance os.cpu_count() documentation #110169https://github.com/python/cpython/pull/110169
[3.11] [3.12] gh-109649: Enhance os.cpu_count() documentation (GH-110169) #110226https://github.com/python/cpython/pull/110226
gh-109649: Fix test_os.test_process_cpu_count_affinity() #111689https://github.com/python/cpython/pull/111689
Nexthttps://github.com/python/cpython/issues/109649?timeline_page=1
vstinnerhttps://github.com/vstinner
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
on Sep 21, 2023https://github.com/python/cpython/issues/109649#event-10436233839
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
on Sep 21, 2023https://github.com/python/cpython/issues/109649#issuecomment-1729678880
add os.cpu_count() #62114https://github.com/python/cpython/issues/62114
cpu_count() unreliable on Windows #67226https://github.com/python/cpython/issues/67226
os.cpu_count is problematic on sparc/solaris #73451https://github.com/python/cpython/issues/73451
os.cpu_count() returns wrong number of processors on system with > 64 logical processors #74766https://github.com/python/cpython/issues/74766
os.cpu_count() should return a count assigned to a container or that the process is restricted to #80235https://github.com/python/cpython/issues/80235
Support python -Xcpu_count= feature for container environment. #109595https://github.com/python/cpython/issues/109595
multiprocessing.cpu_count() should use hw.availcpu on Mac OS X #61646https://github.com/python/cpython/issues/61646
vstinnerhttps://github.com/vstinner
on Sep 21, 2023https://github.com/python/cpython/issues/109649#event-10436384913
pythongh-109649: Add usable parameter to os.cpu_count()https://github.com/vstinner/cpython/commit/477d57bfe1e129877a8609eef09cdf4cc5dcee3c
pythongh-109649https://github.com/python/cpython/issues/109649
477d57bhttps://github.com/vstinner/cpython/commit/477d57bfe1e129877a8609eef09cdf4cc5dcee3c
pythongh-109649: Add usable parameter to os.cpu_count()https://github.com/vstinner/cpython/commit/0f769ecd188d423f07f21633f996d05503ac68be
pythongh-109649https://github.com/python/cpython/issues/109649
0f769echttps://github.com/vstinner/cpython/commit/0f769ecd188d423f07f21633f996d05503ac68be
pythongh-109649: Add usable parameter to os.cpu_count()https://github.com/vstinner/cpython/commit/df887a816fa6ab25ca61666aa488b4c63d6737e0
pythongh-109649https://github.com/python/cpython/issues/109649
df887a8https://github.com/vstinner/cpython/commit/df887a816fa6ab25ca61666aa488b4c63d6737e0
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
on Sep 21, 2023https://github.com/python/cpython/issues/109649#issuecomment-1729709385
https://learn.microsoft.com/en-us/windows/win32/api/processtopologyapi/nf-processtopologyapi-getprocessgroupaffinityhttps://learn.microsoft.com/en-us/windows/win32/api/processtopologyapi/nf-processtopologyapi-getprocessgroupaffinity
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
on Sep 21, 2023https://github.com/python/cpython/issues/109649#issuecomment-1729713477
vstinnerhttps://github.com/vstinner
on Sep 21, 2023https://github.com/python/cpython/issues/109649#event-10438068103
pythongh-109649: Add affinity parameter to os.cpu_count()https://github.com/vstinner/cpython/commit/6872c18e0317702e1e015fc549899c5a5906ea98
pythongh-109649https://github.com/python/cpython/issues/109649
6872c18https://github.com/vstinner/cpython/commit/6872c18e0317702e1e015fc549899c5a5906ea98
vstinnerhttps://github.com/vstinner
on Sep 21, 2023https://github.com/python/cpython/issues/109649#event-10438081769
vstinnerhttps://github.com/vstinner
on Sep 21, 2023https://github.com/python/cpython/issues/109649#event-10438115529
pythongh-109649: Add affinity parameter to os.cpu_count()https://github.com/vstinner/cpython/commit/38ba1c39660975f086ff0f431d3c41154b84807d
pythongh-109649https://github.com/python/cpython/issues/109649
38ba1c3https://github.com/vstinner/cpython/commit/38ba1c39660975f086ff0f431d3c41154b84807d
pythongh-109649: Add affinity parameter to os.cpu_count()https://github.com/vstinner/cpython/commit/ae114ac90035d07f63a44db73586a64a9d37be13
pythongh-109649https://github.com/python/cpython/issues/109649
ae114achttps://github.com/vstinner/cpython/commit/ae114ac90035d07f63a44db73586a64a9d37be13
pythongh-109649: Add affinity parameter to os.cpu_count()https://github.com/vstinner/cpython/commit/276214403af8c88f66a463109709538ca1668f61
pythongh-109649https://github.com/python/cpython/issues/109649
2762144https://github.com/vstinner/cpython/commit/276214403af8c88f66a463109709538ca1668f61
pythongh-109649: Add os.process_cpu_count() functionhttps://github.com/vstinner/cpython/commit/48c68d2fc884e9a2074268c0559439b183648968
pythongh-109649https://github.com/python/cpython/issues/109649
48c68d2https://github.com/vstinner/cpython/commit/48c68d2fc884e9a2074268c0559439b183648968
pythongh-109649: Add os.process_cpu_count() functionhttps://github.com/vstinner/cpython/commit/e3554fa71916ca904922b195922f9ea02d207170
pythongh-109649https://github.com/python/cpython/issues/109649
e3554fahttps://github.com/vstinner/cpython/commit/e3554fa71916ca904922b195922f9ea02d207170
pythongh-109649: Add os.process_cpu_count() functionhttps://github.com/vstinner/cpython/commit/69c8bf46f2bd34551222d5e34405e5ca91254c14
pythongh-109649https://github.com/python/cpython/issues/109649
69c8bf4https://github.com/vstinner/cpython/commit/69c8bf46f2bd34551222d5e34405e5ca91254c14
vstinnerhttps://github.com/vstinner
on Sep 30, 2023https://github.com/python/cpython/issues/109649#event-10518169314
pythongh-109649: Use os.process_cpu_count()https://github.com/vstinner/cpython/commit/5a6d0437c615936c8e04b7af04888d203b091ef2
pythongh-109649https://github.com/python/cpython/issues/109649
5a6d043https://github.com/vstinner/cpython/commit/5a6d0437c615936c8e04b7af04888d203b091ef2
pythongh-109649: Use os.process_cpu_count()https://github.com/vstinner/cpython/commit/c1c59bf8d80090fe55a29f79e130dfa373076035
pythongh-109649https://github.com/python/cpython/issues/109649
c1c59bfhttps://github.com/vstinner/cpython/commit/c1c59bf8d80090fe55a29f79e130dfa373076035
pythongh-109649: Use os.process_cpu_count()https://github.com/vstinner/cpython/commit/6b15e90e8a2238415a6033690fc26a88f3e527b4
pythongh-109649https://github.com/python/cpython/issues/109649
6b15e90https://github.com/vstinner/cpython/commit/6b15e90e8a2238415a6033690fc26a88f3e527b4
pythongh-109649: Enhance os.cpu_count() documentationhttps://github.com/vstinner/cpython/commit/208ef27d2f6ff4f73714f8fdd6fc5c9408e94e83
pythongh-109649https://github.com/python/cpython/issues/109649
208ef27https://github.com/vstinner/cpython/commit/208ef27d2f6ff4f73714f8fdd6fc5c9408e94e83
pythongh-109649: Enhance os.cpu_count() documentationhttps://github.com/vstinner/cpython/commit/b370b73cff134830bae0f368c5bd9c6bc0385bf7
pythongh-109649https://github.com/python/cpython/issues/109649
b370b73https://github.com/vstinner/cpython/commit/b370b73cff134830bae0f368c5bd9c6bc0385bf7
gh-109649: Use os.process_cpu_count() (#110165)https://github.com/python/cpython/commit/a46e96076898d126c9f276aef1934195aac34b4e
gh-109649https://github.com/python/cpython/issues/109649
#110165https://github.com/python/cpython/pull/110165
a46e960https://github.com/python/cpython/commit/a46e96076898d126c9f276aef1934195aac34b4e
Yhg1shttps://github.com/Yhg1s
on Oct 2, 2023https://github.com/python/cpython/issues/109649#event-10527754220
[3.12] gh-109649: Enhance os.cpu_count() documentation (#110169)https://github.com/python/cpython/commit/5245b97e132ae071e2b574224e0788cab62fdcc9
gh-109649https://github.com/python/cpython/issues/109649
#110169https://github.com/python/cpython/pull/110169
5245b97https://github.com/python/cpython/commit/5245b97e132ae071e2b574224e0788cab62fdcc9
miss-islingtonhttps://github.com/miss-islington
on Oct 2, 2023https://github.com/python/cpython/issues/109649#event-10527757312
[3.12] pythongh-109649: Enhance os.cpu_count() documentation (pythonG…https://github.com/miss-islington/cpython/commit/cfc236c1caf74010647b7d74e0477f7a58eeaa19
pythongh-109649https://github.com/python/cpython/issues/109649
pythonG…https://github.com/python/cpython/pull/110169
cfc236chttps://github.com/miss-islington/cpython/commit/cfc236c1caf74010647b7d74e0477f7a58eeaa19
gpsheadhttps://github.com/gpshead
on Oct 3, 2023https://github.com/python/cpython/issues/109649#event-10532172004
[3.11] [3.12] gh-109649: Enhance os.cpu_count() documentation (GH-110169https://github.com/python/cpython/commit/bf6843e91f70a9956acb8a1cdd0564d3598b9a6e
gh-109649https://github.com/python/cpython/issues/109649
GH-110169https://github.com/python/cpython/pull/110169
bf6843ehttps://github.com/python/cpython/commit/bf6843e91f70a9956acb8a1cdd0564d3598b9a6e
vstinnerhttps://github.com/vstinner
on Nov 3, 2023https://github.com/python/cpython/issues/109649#event-10854675371
pythongh-109649: Fix test_os.test_process_cpu_count_affinity()https://github.com/vstinner/cpython/commit/2db7d4ff537b7999104b8b807cac6053ba23ce86
pythongh-109649https://github.com/python/cpython/issues/109649
2db7d4fhttps://github.com/vstinner/cpython/commit/2db7d4ff537b7999104b8b807cac6053ba23ce86
gh-109649: Fix test_os.test_process_cpu_count_affinity() (#111689)https://github.com/python/cpython/commit/244e37b22a826eeb37bc057193bbff7138bc6ac3
gh-109649https://github.com/python/cpython/issues/109649
#111689https://github.com/python/cpython/pull/111689
244e37bhttps://github.com/python/cpython/commit/244e37b22a826eeb37bc057193bbff7138bc6ac3
aiskhttps://github.com/aisk
on Feb 11, 2024https://github.com/python/cpython/issues/109649#event-11766812311
pythongh-109649: Fix test_os.test_process_cpu_count_affinity() (pytho…https://github.com/aisk/cpython/commit/36895e1661136d4bbc05eb1b23a5d068d92ace39
pythongh-109649https://github.com/python/cpython/issues/109649
pytho…https://github.com/python/cpython/pull/111689
36895e1https://github.com/aisk/cpython/commit/36895e1661136d4bbc05eb1b23a5d068d92ace39
Glyphackhttps://github.com/Glyphack
on Sep 2, 2024https://github.com/python/cpython/issues/109649#event-14106065647
pythongh-109649: Add os.process_cpu_count() function (python#109907)https://github.com/Glyphack/cpython/commit/7662bfc357d2c4185096b325ed985a8deb6a5c17
pythongh-109649https://github.com/python/cpython/issues/109649
python#109907https://github.com/python/cpython/pull/109907
7662bfchttps://github.com/Glyphack/cpython/commit/7662bfc357d2c4185096b325ed985a8deb6a5c17
pythongh-109649: Use os.process_cpu_count() (python#110165)https://github.com/Glyphack/cpython/commit/c3bc035dcfaf62798a8755e463895f4422f0869d
pythongh-109649https://github.com/python/cpython/issues/109649
python#110165https://github.com/python/cpython/pull/110165
c3bc035https://github.com/Glyphack/cpython/commit/c3bc035dcfaf62798a8755e463895f4422f0869d
pythongh-109649: Fix test_os.test_process_cpu_count_affinity() (pytho…https://github.com/Glyphack/cpython/commit/dcd6d004e720957c0cb81afe4684a2cf7d94ea38
pythongh-109649https://github.com/python/cpython/issues/109649
pytho…https://github.com/python/cpython/pull/111689
dcd6d00https://github.com/Glyphack/cpython/commit/dcd6d004e720957c0cb81afe4684a2cf7d94ea38
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/109649
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/109649
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.