René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Update logging library module lock to use context manager to acquire/release lock.","articleBody":"# Feature or enhancement\n\n### Proposal:\n\n\nCurrent implementation relies on both `_acquireLock()` and `_releaseLock()` being called, otherwise a lock may never be released:\n\n```python\ndef _acquireLock():\n    \"\"\"\n    Acquire the module-level lock for serializing access to shared data.\n\n    This should be released with _releaseLock().\n    \"\"\"\n    if _lock:\n        try:\n            _lock.acquire()\n        except BaseException:\n            _lock.release()\n            raise\n\ndef _releaseLock():\n    \"\"\"\n    Release the module-level lock acquired by calling _acquireLock().\n    \"\"\"\n    if _lock:\n        _lock.release()\n```\nThe majority of usages of `_acquireLock()` manually add a try/except/finally block to ensure that the lock is released if an exception is thrown. Some usages of `_acquireLock()` have no safety.\n\nThe proposal is to alter the usage of `_acquireLock()` to be a context manager that deals with acquiring and releasing automatically rather than requiring try/except/finally blocks to be used anywhere the function is called. \n\nFor example,\nusage before:\n```python\n_acquireLock()\ntry:\n    ...\nfinally:\n    _releaseLock()\n```\nproposed usage:\n```python\nwith _acquireLock():\n    ...\n```\n\n\n\n### Has this already been discussed elsewhere?\n\nThis is a minor feature, which does not need previous discussion elsewhere\n\n### Links to previous discussion of this feature:\n\n_No response_\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-109462\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/dcollison","@type":"Person","name":"dcollison"},"datePublished":"2023-09-15T17:06:25.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/109461/cpython/issues/109461"}