Title: Build fails with recent libedit versions · Issue #109191 · python/cpython · GitHub
Open Graph Title: Build fails with recent libedit versions · Issue #109191 · python/cpython
X Title: Build fails with recent libedit versions · Issue #109191 · python/cpython
Description: Bug report Bug description: readline_set_completion_display_matches_hook_impl will use either VFunction (if _RL_FUNCTION_TYPEDEF is defined) or rl_compdisp_func_t. The former is deprecated but available in current readline, while the lat...
Open Graph Description: Bug report Bug description: readline_set_completion_display_matches_hook_impl will use either VFunction (if _RL_FUNCTION_TYPEDEF is defined) or rl_compdisp_func_t. The former is deprecated but avai...
X Description: Bug report Bug description: readline_set_completion_display_matches_hook_impl will use either VFunction (if _RL_FUNCTION_TYPEDEF is defined) or rl_compdisp_func_t. The former is deprecated but avai...
Opengraph URL: https://github.com/python/cpython/issues/109191
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Build fails with recent libedit versions","articleBody":"# Bug report\n\n### Bug description:\n\n`readline_set_completion_display_matches_hook_impl` will use either `VFunction` (if `_RL_FUNCTION_TYPEDEF` is defined) or `rl_compdisp_func_t`. The former is deprecated but available in current readline, while the latter has historically not been available in libedit. However, libedit recently added `rl_compdisp_func_t` and removed `VFunction` entirely: http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libedit/readline/readline.h.diff?r1=1.53\u0026r2=1.54\u0026sortby=date\n\nWe ship a recent libedit in MacPorts, so we see a compilation failure like this:\n```\n./Modules/readline.c:448:10: error: use of undeclared identifier 'VFunction'; did you mean 'function'?\n (VFunction *)on_completion_display_matches_hook : 0;\n ^~~~~~~~~\n```\n\nIt's easy enough for us to patch around this, but I guess if compatibility with both current libedit and the older version shipped by Apple is desired, there needs to be another check for the availability of this type.\n\n### CPython versions tested on:\n\n3.12\n\n### Operating systems tested on:\n\nmacOS\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-110239\n* gh-110562\n* gh-110575\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/jmroot","@type":"Person","name":"jmroot"},"datePublished":"2023-09-09T15:41:09.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/109191/cpython/issues/109191"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:3d61015f-0c7e-6394-bbee-b08dfcd1a5b1 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | EB9A:21E6C4:E73C74:142CD65:696A3CB4 |
| html-safe-nonce | 5b86394caa6a300261a050256367353395decdcb53c52edc05d162221c2c0365 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjlBOjIxRTZDNDpFNzNDNzQ6MTQyQ0Q2NTo2OTZBM0NCNCIsInZpc2l0b3JfaWQiOiI4OTk1MDIzMzg5Mjk3NjIyMTk2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | cadd33c86eb9ad29115826ea9f98ffdaa94f668ef6b14644dca309fc922a7f4e |
| hovercard-subject-tag | issue:1888791193 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/109191/issue_layout |
| twitter:image | https://opengraph.githubassets.com/b42787bb5f15aff272fbbd714b081376a84a9b0e4a1f4125f968e532674bea87/python/cpython/issues/109191 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b42787bb5f15aff272fbbd714b081376a84a9b0e4a1f4125f968e532674bea87/python/cpython/issues/109191 |
| og:image:alt | Bug report Bug description: readline_set_completion_display_matches_hook_impl will use either VFunction (if _RL_FUNCTION_TYPEDEF is defined) or rl_compdisp_func_t. The former is deprecated but avai... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jmroot |
| hostname | github.com |
| expected-hostname | github.com |
| None | 321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 13581a31d51edf4a3aca179e10890a4d4f9b6d76 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width