Title: `CookieJar.extract_cookies()` does not clear expired cookies set with a domain · Issue #108931 · python/cpython · GitHub
Open Graph Title: `CookieJar.extract_cookies()` does not clear expired cookies set with a domain · Issue #108931 · python/cpython
X Title: `CookieJar.extract_cookies()` does not clear expired cookies set with a domain · Issue #108931 · python/cpython
Description: Bug report Bug description: SUMMARY: http.cookiejar.CookieJar does not delete expired cookies with a domain unless the domain name has a leading period. DETAILS: If CookieJar.set_cookie() is given a cookie that specifies a domain, then w...
Open Graph Description: Bug report Bug description: SUMMARY: http.cookiejar.CookieJar does not delete expired cookies with a domain unless the domain name has a leading period. DETAILS: If CookieJar.set_cookie() is given ...
X Description: Bug report Bug description: SUMMARY: http.cookiejar.CookieJar does not delete expired cookies with a domain unless the domain name has a leading period. DETAILS: If CookieJar.set_cookie() is given ...
Opengraph URL: https://github.com/python/cpython/issues/108931
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`CookieJar.extract_cookies()` does not clear expired cookies set with a domain","articleBody":"# Bug report\r\n\r\n### Bug description:\r\n\r\nSUMMARY: `http.cookiejar.CookieJar` does not delete expired cookies with a domain unless the domain name has a leading period.\r\n\r\nDETAILS: If `CookieJar.set_cookie()` is given a cookie that specifies a domain, then when `CookieJar.extract_cookies()` is called with a response that tries to expire the cookie, the cookie will not be removed, since `CookieJar._cookie_from_cookie_tuple()` is prepending a period to the domain name and only attempting to clear a cookie with a domain with a leading period. [RFC 6265 Section 4.1.2.3](https://datatracker.ietf.org/doc/html/rfc6265#section-4.1.2.3) says, \"a leading %x2E (\".\"), if present, is ignored,\" but that `http.cookiejar` code is not correctly ignoring it. I think the simplest fix is for `CookieJar._cookie_from_cookie_tuple()` to call `self.clear()` twice, once with a domain with a leading period and once without a leading period.\r\n\r\nHere's an example using `httpx`:\r\n```python\r\nimport asyncio\r\nimport httpx\r\nfrom aiohttp import web\r\n\r\nCOOKIE = 'TestCookie'\r\nDOMAIN = 'localhost'\r\nPORT = 8088\r\n\r\nasync def handler(request):\r\n rsp = web.Response(text='OK')\r\n rsp.del_cookie(COOKIE, domain=DOMAIN)\r\n return rsp\r\n\r\nasync def server():\r\n server = web.Server(handler)\r\n runner = web.ServerRunner(server)\r\n await runner.setup()\r\n site = web.TCPSite(runner, DOMAIN, PORT)\r\n await site.start()\r\n\r\nasync def httpx_client():\r\n async with httpx.AsyncClient(timeout=100_000) as client:\r\n client.cookies.set(COOKIE, 'deprecated', domain=DOMAIN)\r\n print(client.cookies.jar)\r\n await client.get(f'http://{DOMAIN}:{PORT}')\r\n print(client.cookies.jar)\r\n\r\nasync def main():\r\n await server()\r\n await httpx_client()\r\n\r\nasyncio.run(main())\r\n```\r\n\r\nHere's an example using only standard library modules:\r\n```python\r\nimport email.message\r\nimport urllib.request, urllib.response\r\nfrom http.cookiejar import Cookie, CookieJar\r\n\r\nCOOKIE = 'TestCookie'\r\nDOMAIN = 'localhost'\r\nPORT = 8088\r\n\r\njar = CookieJar()\r\ncookie = Cookie(comment=None, comment_url=None, discard=True, domain=DOMAIN,\r\n domain_initial_dot=False, domain_specified=True, expires=None,\r\n name=COOKIE, path='/', path_specified=True, port=None, port_specified=False,\r\n rest={'HttpOnly': None}, secure=False, value='deprecated', version=0\r\n)\r\njar.set_cookie(cookie)\r\nprint(jar)\r\n\r\nhost = f'{DOMAIN}:{PORT}'\r\nreq = urllib.request.Request(f'http://{host}', headers={'Host': host})\r\nexpires = 'expires=Thu, 01 Jan 1970 00:00:00 GMT'\r\nresp_headers = {\r\n 'content-length': '2',\r\n 'content-type': 'text/plain; charset=utf-8',\r\n 'date': 'Tue, 05 Sep 2023 12:38:18 GMT',\r\n 'server': 'Python/3.10 aiohttp/3.8.5',\r\n 'set-cookie': f'TestCookie=\"\"; Domain={DOMAIN}; {expires}; Max-Age=0; Path=/'\r\n}\r\nheaders = email.message.Message()\r\nfor key, val in resp_headers.items():\r\n headers[key] = val\r\nresp = urllib.response.addinfourl(fp=None, url=f'http://{host}', headers=headers)\r\n\r\njar.extract_cookies(resp, req)\r\nprint(jar)\r\n```\r\n\r\n### CPython versions tested on:\r\n\r\n3.10, 3.11\r\n\r\n### Operating systems tested on:\r\n\r\nLinux, Windows","author":{"url":"https://github.com/ppena-LiveData","@type":"Person","name":"ppena-LiveData"},"datePublished":"2023-09-05T16:04:35Z","url":"https://github.com/python/cpython/issues/108931"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:2bc57b21-7690-4947-925b-4b93c547b3a6 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 95DE:19AA62:3BC1E9E:4BD0BF9:6B020294 |
| html-safe-nonce | b195a9d7769caaab1b614aa152f8ab55386d99f463d42470eb96ee1a2faff7ae |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NURFOjE5QUE2MjozQkMxRTlFOjRCRDBCRjk6NkIwMjAyOTQiLCJ2aXNpdG9yX2lkIjoiNjMwMjQzMjk2NjUxOTAzNjM2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 439e9479d4b10dfb275dc8fcff75e366301b19134d97bbe9d64a9766119c8459 |
| hovercard-subject-tag | issue:1882267343 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/108931/issue_layout |
| twitter:image | https://opengraph.githubassets.com/b6449501fc3531c6df2f82d6241a05d4adde529a9c9fc10126096e53208bac5b/python/cpython/issues/108931 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b6449501fc3531c6df2f82d6241a05d4adde529a9c9fc10126096e53208bac5b/python/cpython/issues/108931 |
| og:image:alt | Bug report Bug description: SUMMARY: http.cookiejar.CookieJar does not delete expired cookies with a domain unless the domain name has a leading period. DETAILS: If CookieJar.set_cookie() is given ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ppena-LiveData |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width