René's URL Explorer Experiment


Title: `CookieJar.extract_cookies()` does not clear expired cookies set with a domain · Issue #108931 · python/cpython · GitHub

Open Graph Title: `CookieJar.extract_cookies()` does not clear expired cookies set with a domain · Issue #108931 · python/cpython

X Title: `CookieJar.extract_cookies()` does not clear expired cookies set with a domain · Issue #108931 · python/cpython

Description: Bug report Bug description: SUMMARY: http.cookiejar.CookieJar does not delete expired cookies with a domain unless the domain name has a leading period. DETAILS: If CookieJar.set_cookie() is given a cookie that specifies a domain, then w...

Open Graph Description: Bug report Bug description: SUMMARY: http.cookiejar.CookieJar does not delete expired cookies with a domain unless the domain name has a leading period. DETAILS: If CookieJar.set_cookie() is given ...

X Description: Bug report Bug description: SUMMARY: http.cookiejar.CookieJar does not delete expired cookies with a domain unless the domain name has a leading period. DETAILS: If CookieJar.set_cookie() is given ...

Opengraph URL: https://github.com/python/cpython/issues/108931

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`CookieJar.extract_cookies()` does not clear expired cookies set with a domain","articleBody":"# Bug report\r\n\r\n### Bug description:\r\n\r\nSUMMARY: `http.cookiejar.CookieJar` does not delete expired cookies with a domain unless the domain name has a leading period.\r\n\r\nDETAILS: If `CookieJar.set_cookie()` is given a cookie that specifies a domain, then when `CookieJar.extract_cookies()` is called with a response that tries to expire the cookie, the cookie will not be removed, since `CookieJar._cookie_from_cookie_tuple()` is prepending a period to the domain name and only attempting to clear a cookie with a domain with a leading period. [RFC 6265 Section 4.1.2.3](https://datatracker.ietf.org/doc/html/rfc6265#section-4.1.2.3) says, \"a leading %x2E (\".\"), if present, is ignored,\" but that `http.cookiejar` code is not correctly ignoring it. I think the simplest fix is for `CookieJar._cookie_from_cookie_tuple()` to call `self.clear()` twice, once with a domain with a leading period and once without a leading period.\r\n\r\nHere's an example using `httpx`:\r\n```python\r\nimport asyncio\r\nimport httpx\r\nfrom aiohttp import web\r\n\r\nCOOKIE = 'TestCookie'\r\nDOMAIN = 'localhost'\r\nPORT = 8088\r\n\r\nasync def handler(request):\r\n    rsp = web.Response(text='OK')\r\n    rsp.del_cookie(COOKIE, domain=DOMAIN)\r\n    return rsp\r\n\r\nasync def server():\r\n    server = web.Server(handler)\r\n    runner = web.ServerRunner(server)\r\n    await runner.setup()\r\n    site = web.TCPSite(runner, DOMAIN, PORT)\r\n    await site.start()\r\n\r\nasync def httpx_client():\r\n    async with httpx.AsyncClient(timeout=100_000) as client:\r\n        client.cookies.set(COOKIE, 'deprecated', domain=DOMAIN)\r\n        print(client.cookies.jar)\r\n        await client.get(f'http://{DOMAIN}:{PORT}')\r\n        print(client.cookies.jar)\r\n\r\nasync def main():\r\n    await server()\r\n    await httpx_client()\r\n\r\nasyncio.run(main())\r\n```\r\n\r\nHere's an example using only standard library modules:\r\n```python\r\nimport email.message\r\nimport urllib.request, urllib.response\r\nfrom http.cookiejar import Cookie, CookieJar\r\n\r\nCOOKIE = 'TestCookie'\r\nDOMAIN = 'localhost'\r\nPORT = 8088\r\n\r\njar = CookieJar()\r\ncookie = Cookie(comment=None, comment_url=None, discard=True, domain=DOMAIN,\r\n    domain_initial_dot=False, domain_specified=True, expires=None,\r\n    name=COOKIE, path='/', path_specified=True, port=None, port_specified=False,\r\n    rest={'HttpOnly': None}, secure=False, value='deprecated', version=0\r\n)\r\njar.set_cookie(cookie)\r\nprint(jar)\r\n\r\nhost = f'{DOMAIN}:{PORT}'\r\nreq = urllib.request.Request(f'http://{host}', headers={'Host': host})\r\nexpires = 'expires=Thu, 01 Jan 1970 00:00:00 GMT'\r\nresp_headers = {\r\n    'content-length': '2',\r\n    'content-type': 'text/plain; charset=utf-8',\r\n    'date': 'Tue, 05 Sep 2023 12:38:18 GMT',\r\n    'server': 'Python/3.10 aiohttp/3.8.5',\r\n    'set-cookie': f'TestCookie=\"\"; Domain={DOMAIN}; {expires}; Max-Age=0; Path=/'\r\n}\r\nheaders = email.message.Message()\r\nfor key, val in resp_headers.items():\r\n    headers[key] = val\r\nresp = urllib.response.addinfourl(fp=None, url=f'http://{host}', headers=headers)\r\n\r\njar.extract_cookies(resp, req)\r\nprint(jar)\r\n```\r\n\r\n### CPython versions tested on:\r\n\r\n3.10, 3.11\r\n\r\n### Operating systems tested on:\r\n\r\nLinux, Windows","author":{"url":"https://github.com/ppena-LiveData","@type":"Person","name":"ppena-LiveData"},"datePublished":"2023-09-05T16:04:35Z","url":"https://github.com/python/cpython/issues/108931"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:2bc57b21-7690-4947-925b-4b93c547b3a6
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id95DE:19AA62:3BC1E9E:4BD0BF9:6B020294
html-safe-nonceb195a9d7769caaab1b614aa152f8ab55386d99f463d42470eb96ee1a2faff7ae
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NURFOjE5QUE2MjozQkMxRTlFOjRCRDBCRjk6NkIwMjAyOTQiLCJ2aXNpdG9yX2lkIjoiNjMwMjQzMjk2NjUxOTAzNjM2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac439e9479d4b10dfb275dc8fcff75e366301b19134d97bbe9d64a9766119c8459
hovercard-subject-tagissue:1882267343
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/108931/issue_layout
twitter:imagehttps://opengraph.githubassets.com/b6449501fc3531c6df2f82d6241a05d4adde529a9c9fc10126096e53208bac5b/python/cpython/issues/108931
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b6449501fc3531c6df2f82d6241a05d4adde529a9c9fc10126096e53208bac5b/python/cpython/issues/108931
og:image:altBug report Bug description: SUMMARY: http.cookiejar.CookieJar does not delete expired cookies with a domain unless the domain name has a leading period. DETAILS: If CookieJar.set_cookie() is given ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameppena-LiveData
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/108931#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F108931
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F108931
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/108931
Reloadhttps://github.com/python/cpython/issues/108931
Reloadhttps://github.com/python/cpython/issues/108931
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/108931
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/108931
CookieJar.extract_cookies() does not clear expired cookies set with a domainhttps://github.com/python/cpython/issues/108931#top
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/ppena-LiveData
ppena-LiveDatahttps://github.com/ppena-LiveData
on Sep 5, 2023https://github.com/python/cpython/issues/108931#issue-1882267343
RFC 6265 Section 4.1.2.3https://datatracker.ietf.org/doc/html/rfc6265#section-4.1.2.3
ppena-LiveDatahttps://github.com/ppena-LiveData
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
on Sep 5, 2023https://github.com/python/cpython/issues/108931#event-10285609026
iritkatrielhttps://github.com/iritkatriel
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
on Nov 25, 2023https://github.com/python/cpython/issues/108931#event-11060566740
sidlovescodinghttps://github.com/sidlovescoding
on Nov 11, 2026https://github.com/python/cpython/issues/108931#event-35747202897
pythongh-108931: Remove expired cookies stored without a leading dothttps://github.com/sidlovescoding/Cpython/commit/0f8f52b5408ddbf1e244f9368e9352a1c76ace8b
pythongh-108931https://github.com/python/cpython/issues/108931
0f8f52bhttps://github.com/sidlovescoding/Cpython/commit/0f8f52b5408ddbf1e244f9368e9352a1c76ace8b
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/108931
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/108931
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.