René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Argument Clinic: make it possible to clone __init__ functions","articleBody":"See https://github.com/python/cpython/issues/93057#issuecomment-1675380260\r\n\r\nIn sqlite3, both `sqlite3.connect` and `sqlite3.Connection.__init__` have the same param spec. This has led to the far-from-optimal status quo:\r\n\r\nhttps://github.com/python/cpython/blob/d93b4ac2ff7bce07fb1c8805f43838818598191c/Modules/_sqlite/module.c#L51-L69\r\n\r\nhttps://github.com/python/cpython/blob/d93b4ac2ff7bce07fb1c8805f43838818598191c/Modules/_sqlite/connection.c#L215-L239\r\n\r\nInstead, we want to be able to do this in connection.c:\r\n\r\n```c\r\n/*[clinic input]\r\nsqlite3.Connection.__init__ as pysqlite_connection_init\r\n    database: object\r\n    timeout: double = 5.0\r\n    detect_types: int = 0\r\n    isolation_level: IsolationLevel = \"\"\r\n    check_same_thread: bool = True\r\n    factory: object(c_default='(PyObject*)clinic_state()-\u003eConnectionType') = ConnectionType\r\n    cached_statements as cache_size: int = 128\r\n    uri: bool = False\r\n    *\r\n    autocommit: Autocommit(c_default='LEGACY_TRANSACTION_CONTROL') = sqlite3.LEGACY_TRANSACTION_CONTROL\r\n[clinic start generated code]*/\r\n\r\nstatic int\r\npysqlite_connection_init_impl(pysqlite_Connection *self, PyObject *database,\r\n                              double timeout, int detect_types,\r\n                              const char *isolation_level,\r\n                              int check_same_thread, PyObject *factory,\r\n                              int cache_size, int uri,\r\n                              enum autocommit_mode autocommit)\r\n/*[clinic end generated code: output=cba057313ea7712f input=a0949fb85339104d]*/\r\n{\r\n    // __init__ function is here; fast forward ...\r\n}\r\n\r\n/*[clinic input]\r\n# Save the clinic output config.\r\noutput push\r\n\r\n# Create a new destination 'connect' for the docstring and methoddef only.\r\ndestination connect new file '{dirname}/clinic/_sqlite3.connect.c.h'\r\noutput everything suppress\r\noutput docstring_definition connect\r\noutput methoddef_define connect\r\n\r\n# Now, define the connect function.\r\nsqlite3.connect as pysqlite_connect = sqlite3.Connection.__init__\r\n\r\n[clinic start generated code]*/\r\n/*[clinic end generated code: output=da39a3ee5e6b4b0d input=7913cd0b3bfc1b4a]*/\r\n\r\n/*[clinic input]\r\n# Restore the clinic output config.\r\noutput pop\r\n[clinic start generated code]*/\r\n```\r\n\r\nThe methoddef and docstring for `sqlite3.connect` could then be included in module.c.\r\n\r\nHowever, to achieve this, we need to teach Argument Clinic how to clone `__init__` functions.\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-107885\n* gh-107974\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/erlend-aasland","@type":"Person","name":"erlend-aasland"},"datePublished":"2023-08-11T21:21:13.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/107880/cpython/issues/107880"}