René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Argument Clinic includes internal headers in generated output unconditionally","articleBody":"It seems like Argument Clinic generates code that define `Py_BUILD_CORE` and includes internal headers unconditionally; for example, a file with a `METH_O` function will have no need for those:\r\n\r\n\u003cdetails\u003e\r\n\r\n```c\r\n/*[clinic input]\r\npreserve\r\n[clinic start generated code]*/\r\n\r\n#if defined(Py_BUILD_CORE) \u0026\u0026 !defined(Py_BUILD_CORE_MODULE)\r\n#  include \"pycore_gc.h\"            // PyGC_Head\r\n#  include \"pycore_runtime.h\"       // _Py_ID()\r\n#endif\r\n\r\n\r\nPyDoc_STRVAR(func__doc__,\r\n\"func($module, a, /)\\n\"\r\n\"--\\n\"\r\n\"\\n\");\r\n\r\n#define FUNC_METHODDEF    \\\r\n    {\"func\", (PyCFunction)func, METH_O, func__doc__},\r\n/*[clinic end generated code: output=851b6645c29cfa0d input=a9049054013a1b77]*/\r\n```\r\n\r\n\u003c/details\u003e\r\n\r\nOTOH, a `METH_KEYWORDS` function needs those:\r\n\r\n\u003cdetails\u003e\r\n\r\n```c\r\n/*[clinic input]\r\npreserve\r\n[clinic start generated code]*/\r\n\r\n#if defined(Py_BUILD_CORE) \u0026\u0026 !defined(Py_BUILD_CORE_MODULE)\r\n#  include \"pycore_gc.h\"            // PyGC_Head\r\n#  include \"pycore_runtime.h\"       // _Py_ID()\r\n#endif\r\n\r\n\r\nPyDoc_STRVAR(func__doc__,\r\n\"func($module, /, a, b)\\n\"\r\n\"--\\n\"\r\n\"\\n\");\r\n\r\n#define FUNC_METHODDEF    \\\r\n    {\"func\", _PyCFunction_CAST(func), METH_FASTCALL|METH_KEYWORDS, func__doc__},\r\n\r\nstatic PyObject *\r\nfunc_impl(PyObject *module, PyObject *a, PyObject *b);\r\n\r\nstatic PyObject *\r\nfunc(PyObject *module, PyObject *const *args, Py_ssize_t nargs, PyObject *kwnames)\r\n{\r\n    PyObject *return_value = NULL;\r\n    #if defined(Py_BUILD_CORE) \u0026\u0026 !defined(Py_BUILD_CORE_MODULE)\r\n\r\n    #define NUM_KEYWORDS 2\r\n    static struct {\r\n        PyGC_Head _this_is_not_used;\r\n        PyObject_VAR_HEAD\r\n        PyObject *ob_item[NUM_KEYWORDS];\r\n    } _kwtuple = {\r\n        .ob_base = PyVarObject_HEAD_INIT(\u0026PyTuple_Type, NUM_KEYWORDS)\r\n        .ob_item = { \u0026_Py_ID(a), \u0026_Py_ID(b), },\r\n    };\r\n    #undef NUM_KEYWORDS\r\n    #define KWTUPLE (\u0026_kwtuple.ob_base.ob_base)\r\n\r\n    #else  // !Py_BUILD_CORE\r\n    #  define KWTUPLE NULL\r\n    #endif  // !Py_BUILD_CORE\r\n\r\n    static const char * const _keywords[] = {\"a\", \"b\", NULL};\r\n    static _PyArg_Parser _parser = {\r\n        .keywords = _keywords,\r\n        .fname = \"func\",\r\n        .kwtuple = KWTUPLE,\r\n    };\r\n    #undef KWTUPLE\r\n    PyObject *argsbuf[2];\r\n    PyObject *a;\r\n    PyObject *b;\r\n\r\n    args = _PyArg_UnpackKeywords(args, nargs, NULL, kwnames, \u0026_parser, 2, 2, 0, argsbuf);\r\n    if (!args) {\r\n        goto exit;\r\n    }\r\n    a = args[0];\r\n    b = args[1];\r\n    return_value = func_impl(module, a, b);\r\n\r\nexit:\r\n    return return_value;\r\n}\r\n/*[clinic end generated code: output=e790cd95ffc517a0 input=a9049054013a1b77]*/\r\n```\r\n\r\n\u003c/details\u003e\r\n\r\nArgument Clinic should check if those defines/includes are needed before generating the output.\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-108486\n* gh-108581\n* gh-108715\n* gh-108726\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/erlend-aasland","@type":"Person","name":"erlend-aasland"},"datePublished":"2023-08-03T20:39:44.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":6},"url":"https://github.com/107603/cpython/issues/107603"}