René's URL Explorer Experiment


Title: `test_monitoring` has duplicated tests · Issue #106193 · python/cpython · GitHub

Open Graph Title: `test_monitoring` has duplicated tests · Issue #106193 · python/cpython

X Title: `test_monitoring` has duplicated tests · Issue #106193 · python/cpython

Description: Based on python/core-workflow#505 by @hugovk Lib/test/test_monitoring.py:973:5: F811 redefinition of unused 'test_line_then_instruction' from line 950 Lib/test/test_monitoring.py:978:5: F811 redefinition of unused 'test_instruction_then_...

Open Graph Description: Based on python/core-workflow#505 by @hugovk Lib/test/test_monitoring.py:973:5: F811 redefinition of unused 'test_line_then_instruction' from line 950 Lib/test/test_monitoring.py:978:5: F811 redefi...

X Description: Based on python/core-workflow#505 by @hugovk Lib/test/test_monitoring.py:973:5: F811 redefinition of unused 'test_line_then_instruction' from line 950 Lib/test/test_monitoring.py:978:5: F81...

Opengraph URL: https://github.com/python/cpython/issues/106193

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`test_monitoring` has duplicated tests","articleBody":"Based on https://github.com/python/core-workflow/issues/505 by @hugovk \r\n\r\n```\r\nLib/test/test_monitoring.py:973:5: F811 redefinition of unused 'test_line_then_instruction' from line 950\r\nLib/test/test_monitoring.py:978:5: F811 redefinition of unused 'test_instruction_then_line' from line 955\r\n```\r\n\r\nBefore rename: `Ran 49 tests in 0.014s`\r\nAfter rename:\r\n\r\n```\r\n======================================================================\r\nERROR: test_instruction_then_line (test.test_monitoring.TestInstallIncrementallly.test_instruction_then_line)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/Users/sobolev/Desktop/cpython/Lib/test/test_monitoring.py\", line 956, in test_instruction_then_line\r\n    recorders = [ InstructionRecorder, LineRecorderLowNoise ]\r\n                                       ^^^^^^^^^^^^^^^^^^^^\r\nNameError: name 'LineRecorderLowNoise' is not defined\r\n\r\n======================================================================\r\nERROR: test_line_then_instruction (test.test_monitoring.TestInstallIncrementallly.test_line_then_instruction)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/Users/sobolev/Desktop/cpython/Lib/test/test_monitoring.py\", line 953, in test_line_then_instruction\r\n    recorders = recorders, must_include = self.EXPECTED_LI)\r\n                                          ^^^^^^^^^^^^^^^^\r\nAttributeError: 'TestInstallIncrementallly' object has no attribute 'EXPECTED_LI'\r\n\r\n----------------------------------------------------------------------\r\nRan 51 tests in 0.045s\r\n\r\nFAILED (errors=2)\r\ntest test_monitoring failed\r\ntest_monitoring failed (2 errors)\r\n\r\n== Tests result: FAILURE ==\r\n\r\n1 test failed:\r\n    test_monitoring\r\n\r\nTotal duration: 94 ms\r\nTests result: FAILURE\r\n```\r\n\r\nBased on the missing runtime parts in these tests, we can just remove the first two ones, I guess.\r\n\r\nBoth of these tests were introduced in https://github.com/python/cpython/commit/411b1692811b2ecac59cb0df0f920861c7cf179a by @markshannon \n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-109139\n* gh-110897\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/sobolevn","@type":"Person","name":"sobolevn"},"datePublished":"2023-06-28T10:51:41.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/106193/cpython/issues/106193"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:6a90f824-8aad-9b5a-f13e-0f66bcb45019
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDD5C:28D973:2C5C75:3EAE28:696A4C4D
html-safe-nonce810c2320bb3ca3d7d690117cb226888a8de5f0da9ae7eb222fcc4fa87f2e9830
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDVDOjI4RDk3MzoyQzVDNzU6M0VBRTI4OjY5NkE0QzREIiwidmlzaXRvcl9pZCI6IjU1NTg1ODU5NDgxNzAwMjU3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8d977636888897825e645558493e7190bd5536228c0752aca986aa94199c1f4e
hovercard-subject-tagissue:1778696332
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/106193/issue_layout
twitter:imagehttps://opengraph.githubassets.com/c2a1cf07f4b10addbfca39249ed7e50898f481f7aad03591696effd4c30ce028/python/cpython/issues/106193
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c2a1cf07f4b10addbfca39249ed7e50898f481f7aad03591696effd4c30ce028/python/cpython/issues/106193
og:image:altBased on python/core-workflow#505 by @hugovk Lib/test/test_monitoring.py:973:5: F811 redefinition of unused 'test_line_then_instruction' from line 950 Lib/test/test_monitoring.py:978:5: F811 redefi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesobolevn
hostnamegithub.com
expected-hostnamegithub.com
None3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release63c426b30d262aba269ef14c40e3c817b384cd61
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/106193#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F106193
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F106193
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/106193
Reloadhttps://github.com/python/cpython/issues/106193
Reloadhttps://github.com/python/cpython/issues/106193
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/106193
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/issues/106193
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/106193
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/106193
#109139https://github.com/python/cpython/pull/109139
test_monitoring has duplicated testshttps://github.com/python/cpython/issues/106193#top
#109139https://github.com/python/cpython/pull/109139
https://github.com/sobolevn
3.12only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.12%22
3.13bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.13%22
testsTests in the Lib/test dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22tests%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/sobolevn
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
on Jun 28, 2023https://github.com/python/cpython/issues/106193#issue-1778696332
python/core-workflow#505https://github.com/python/core-workflow/issues/505
@hugovkhttps://github.com/hugovk
411b169https://github.com/python/cpython/commit/411b1692811b2ecac59cb0df0f920861c7cf179a
@markshannonhttps://github.com/markshannon
gh-106193: Rename and fix duplicated tests in test_monitoring #109139https://github.com/python/cpython/pull/109139
[3.12] gh-106193: Rename and fix duplicated tests in test_monitoring (GH-109139) #110897https://github.com/python/cpython/pull/110897
sobolevnhttps://github.com/sobolevn
3.12only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.12%22
3.13bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.13%22
testsTests in the Lib/test dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22tests%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.