Title: `test_monitoring` has duplicated tests · Issue #106193 · python/cpython · GitHub
Open Graph Title: `test_monitoring` has duplicated tests · Issue #106193 · python/cpython
X Title: `test_monitoring` has duplicated tests · Issue #106193 · python/cpython
Description: Based on python/core-workflow#505 by @hugovk Lib/test/test_monitoring.py:973:5: F811 redefinition of unused 'test_line_then_instruction' from line 950 Lib/test/test_monitoring.py:978:5: F811 redefinition of unused 'test_instruction_then_...
Open Graph Description: Based on python/core-workflow#505 by @hugovk Lib/test/test_monitoring.py:973:5: F811 redefinition of unused 'test_line_then_instruction' from line 950 Lib/test/test_monitoring.py:978:5: F811 redefi...
X Description: Based on python/core-workflow#505 by @hugovk Lib/test/test_monitoring.py:973:5: F811 redefinition of unused 'test_line_then_instruction' from line 950 Lib/test/test_monitoring.py:978:5: F81...
Opengraph URL: https://github.com/python/cpython/issues/106193
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`test_monitoring` has duplicated tests","articleBody":"Based on https://github.com/python/core-workflow/issues/505 by @hugovk \r\n\r\n```\r\nLib/test/test_monitoring.py:973:5: F811 redefinition of unused 'test_line_then_instruction' from line 950\r\nLib/test/test_monitoring.py:978:5: F811 redefinition of unused 'test_instruction_then_line' from line 955\r\n```\r\n\r\nBefore rename: `Ran 49 tests in 0.014s`\r\nAfter rename:\r\n\r\n```\r\n======================================================================\r\nERROR: test_instruction_then_line (test.test_monitoring.TestInstallIncrementallly.test_instruction_then_line)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n File \"/Users/sobolev/Desktop/cpython/Lib/test/test_monitoring.py\", line 956, in test_instruction_then_line\r\n recorders = [ InstructionRecorder, LineRecorderLowNoise ]\r\n ^^^^^^^^^^^^^^^^^^^^\r\nNameError: name 'LineRecorderLowNoise' is not defined\r\n\r\n======================================================================\r\nERROR: test_line_then_instruction (test.test_monitoring.TestInstallIncrementallly.test_line_then_instruction)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n File \"/Users/sobolev/Desktop/cpython/Lib/test/test_monitoring.py\", line 953, in test_line_then_instruction\r\n recorders = recorders, must_include = self.EXPECTED_LI)\r\n ^^^^^^^^^^^^^^^^\r\nAttributeError: 'TestInstallIncrementallly' object has no attribute 'EXPECTED_LI'\r\n\r\n----------------------------------------------------------------------\r\nRan 51 tests in 0.045s\r\n\r\nFAILED (errors=2)\r\ntest test_monitoring failed\r\ntest_monitoring failed (2 errors)\r\n\r\n== Tests result: FAILURE ==\r\n\r\n1 test failed:\r\n test_monitoring\r\n\r\nTotal duration: 94 ms\r\nTests result: FAILURE\r\n```\r\n\r\nBased on the missing runtime parts in these tests, we can just remove the first two ones, I guess.\r\n\r\nBoth of these tests were introduced in https://github.com/python/cpython/commit/411b1692811b2ecac59cb0df0f920861c7cf179a by @markshannon \n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-109139\n* gh-110897\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/sobolevn","@type":"Person","name":"sobolevn"},"datePublished":"2023-06-28T10:51:41.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/106193/cpython/issues/106193"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:6a90f824-8aad-9b5a-f13e-0f66bcb45019 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DD5C:28D973:2C5C75:3EAE28:696A4C4D |
| html-safe-nonce | 810c2320bb3ca3d7d690117cb226888a8de5f0da9ae7eb222fcc4fa87f2e9830 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDVDOjI4RDk3MzoyQzVDNzU6M0VBRTI4OjY5NkE0QzREIiwidmlzaXRvcl9pZCI6IjU1NTg1ODU5NDgxNzAwMjU3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8d977636888897825e645558493e7190bd5536228c0752aca986aa94199c1f4e |
| hovercard-subject-tag | issue:1778696332 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/106193/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c2a1cf07f4b10addbfca39249ed7e50898f481f7aad03591696effd4c30ce028/python/cpython/issues/106193 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c2a1cf07f4b10addbfca39249ed7e50898f481f7aad03591696effd4c30ce028/python/cpython/issues/106193 |
| og:image:alt | Based on python/core-workflow#505 by @hugovk Lib/test/test_monitoring.py:973:5: F811 redefinition of unused 'test_line_then_instruction' from line 950 Lib/test/test_monitoring.py:978:5: F811 redefi... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sobolevn |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 63c426b30d262aba269ef14c40e3c817b384cd61 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width