Title: Improve the constructors of AST nodes · Issue #105858 · python/cpython · GitHub
Open Graph Title: Improve the constructors of AST nodes · Issue #105858 · python/cpython
X Title: Improve the constructors of AST nodes · Issue #105858 · python/cpython
Description: Currently, the constructors for AST nodes accept arbitrary keyword arguments and don't enforce any value: >>> node=ast.FunctionDef(what="is this") >>> node.what 'is this' >>> node.name Traceback (most recent call last): File "
Open Graph Description: Currently, the constructors for AST nodes accept arbitrary keyword arguments and don't enforce any value: >>> node=ast.FunctionDef(what="is this") >>> node.what 'is this' >>> node.name Traceback (m...
X Description: Currently, the constructors for AST nodes accept arbitrary keyword arguments and don't enforce any value: >>> node=ast.FunctionDef(what="is this") >>> node.what '...
Opengraph URL: https://github.com/python/cpython/issues/105858
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Improve the constructors of AST nodes","articleBody":"Currently, the constructors for AST nodes accept arbitrary keyword arguments and don't enforce any value:\r\n\r\n```pycon\r\n\u003e\u003e\u003e node=ast.FunctionDef(what=\"is this\")\r\n\u003e\u003e\u003e node.what\r\n'is this'\r\n\u003e\u003e\u003e node.name\r\nTraceback (most recent call last):\r\n File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\r\nAttributeError: 'FunctionDef' object has no attribute 'name'\r\n```\r\n\r\nProblems with the current situation:\r\n- To make a correct AST node, you have to pass *every* attribute, including ones that could sensibly default to an empty list\r\n- You cannot rely on attributes like `name` being present\r\n- It's possible to create useless, broken AST nodes like the above\r\n- Introspection tools can't easily tell what the signature of the constructor is supposed to be\r\n- Adding new fields to an AST node causes various compatibility issues (#104799) \r\n\r\nProposed solution for 3.13:\r\n- Default all fields to some sensible value if they are not provided to the constructor: an empty list for list fields, and None for other fields.\r\n- Emit a DeprecationWarning if the constructor is passed arguments that it doesn't recognize (e.g., `what` above). In 3.15, this will raise an error.\r\n- Add a `__text_signature__` to the AST classes indicating the expected signature.\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-105880\n* gh-116025\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/JelleZijlstra","@type":"Person","name":"JelleZijlstra"},"datePublished":"2023-06-16T15:28:14.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":6},"url":"https://github.com/105858/cpython/issues/105858"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:3877fbfb-5a2f-69f0-33c6-002e96c1d83d |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A5AC:133D16:ADB75:E70AE:6969C42B |
| html-safe-nonce | d9a03860619d98b09ea3b08557145ec1540031a0ef3ac538353567ee4618c65e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNUFDOjEzM0QxNjpBREI3NTpFNzBBRTo2OTY5QzQyQiIsInZpc2l0b3JfaWQiOiI3ODcyNTQwMzczNzUyMDcxMjExIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | dc4a8a34df019a7a0ab5ac3a5d79a9fba0605c5e6de0b5d474ad8d1b0f5b77e0 |
| hovercard-subject-tag | issue:1760856310 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/105858/issue_layout |
| twitter:image | https://opengraph.githubassets.com/5055d69d040bac28209c69e4c11ae2dded66afa2041150db76511bd968b1c06e/python/cpython/issues/105858 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5055d69d040bac28209c69e4c11ae2dded66afa2041150db76511bd968b1c06e/python/cpython/issues/105858 |
| og:image:alt | Currently, the constructors for AST nodes accept arbitrary keyword arguments and don't enforce any value: >>> node=ast.FunctionDef(what="is this") >>> node.what 'is this' >>> node.name Traceback (m... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JelleZijlstra |
| hostname | github.com |
| expected-hostname | github.com |
| None | acedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 83c08c21cdda978090dc44364b71aa5bc6dcea79 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width